From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C314C433ED for ; Fri, 9 Apr 2021 12:13:15 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5A9F60241 for ; Fri, 9 Apr 2021 12:13:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5A9F60241 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gWVnIvBI3SmnOIL7J1IRMv43dkvreOsNm2OnFnf/+zM=; b=i98O3RnDYEv9LqJRaNm7xRUUK wL1xc+Qx3r1TIN/c7DL/TBG2awwhqSlZLujrpLF2yipspGc8NiZUNoa944vjUGjvK6dTMu1tUSzrX Qk2FfW/iXDvk26su7UvP/qUN1BFBjF/R3gnZVWa6+mY9UzX247BXXHYNNWsd1J/Qwg81/R5oRXGS+ lrxty0QAkl2FXWKmF4kCeSTZxx7l+9UOBjBb4ey+2e6XMYrKQ1KYgzWv9z7CG0yqD3Iv2yomYb0fv jym5BfA1VzKxasjnWk5IFNl0VM2rGAA0b8kQdZCjyb0hMXmNdOQoDnmSFJFONXuoC4HnZYNSFv5AD 7MUsdeZfw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUpyq-000hBk-W4; Fri, 09 Apr 2021 12:11:21 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUpyi-000hAQ-GB for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 12:11:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1617970272; x=1649506272; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pj589dPDrfBMl7h8ml1hAiVOTepA292L6WK9IZ1E5UI=; b=haDzkdocBkyp0Md5adtN+9Sut0SYwcc0sBHpYUd8bbLLg/dDVF37FbX1 wpRQNyJ+S/jzvCi6avkTGK5fsD01TCk0CrcighBENqj486B8Tg4vfNUlr tiouHRBGCXGrfHeby6+nzB5YMfdwHgv4QiW1OOgCnpuHg9rCbGbL241Az 1yQVRT1ZRkXmQAHeztGC7606TN38fBMPhHzH6aPxcxungVpmj+gIJPq9Z lc/4+tBAGnIxfOfI0QQ2/dNDAKid3Aj+bzjcDzLV+3W3Ku96LP7E39tXH KRppLzmUgQ0Yv2WIXUGe8WA0V635t1k1V0Fes6zX4heFaUaTCqFbK+QVr w==; IronPort-SDR: JA53T9zrfEtXKw0Zk6CRz2ZsANOI12L2tTxiO2eJOboeQkX7ZuBHJ514nrFacUpCx02LnvrxHk 87luaRcDR7qiiKyljx9CCUMElxIWEKDSOLLPmMyew5bDRNjhJljv99XuZwl7jEnvXImMni1HwO Tx3JpgenGqvLj7W7hONYclOuF9VBVz7jXB+3ZxaJ/G9Ddo3cZgu45pdzUqWDazvvULQnzY12Qd oQb1FIqd+xK4kfQs97MZJH0SNvIHZmwmFzDtH0dNRTL1Rke9UovSK5vPulV1Y3YxzUl4yFuQ16 /9E= X-IronPort-AV: E=Sophos;i="5.82,209,1613458800"; d="scan'208";a="110253554" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Apr 2021 05:11:10 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 9 Apr 2021 05:11:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2 via Frontend Transport; Fri, 9 Apr 2021 05:11:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GlxXuxpUTR4LLpVXf/fNgvwThcOIOGTgpR7n7YOFyf8kAoRc0/Lu0RzmiH25ywoFOqhfCcSNcaKq9hVOqEQajV3Td/Hm5RLPvLpi9YXPSzD80IdGigNtxAGBL9wf50WNnFvgpkkGmCD4Uz2AtdMm8rY9IQpPbeoLiD5qyn1sVzLo+cY2ie+oDXl5/VI9nDXZSIAvlfIvspmVnD41RjHyGe4Cw16Y7zHloJBj9g4mhYf56DBZMC1BmiwtyswqZphyWw1PTXeuvb5EAq5eSRCXcXX3B0bKA2EOUqPL15Rif1Tzq60IrFaN2j5R/HHL3gX+rQNcA378kPjxx0NlBbuuhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gAyMt6EIokCy5ggDPBpb3Dz/homynVKhm+GvF1DnDcI=; b=FgxNVVNeNk1HXc2DUe+RZlyeYfgqVtKUoV3ztjxc+v8gi/+kfQNpF/JDZmcFOav1GX6K4bUQDSHD1HTjhi0YHUWT008b1rVk8zk2YaDacAjMrxZ2frzhhMP8kJgBxFOL6IfWjCjB0v3YkTPT4QU4SGp1H78tJmIDGvaN7F5Ts8dpuU930h9AMk4A4T4DcpH0GXJWURDZxN9xg6yf5VILbJlmuvJv3j5HRta48MTiQsQZsPZ89JE2S9UzibrD10cGyf27w8mSlFt7tuEsKUbBzRzJE9Tf1OKmA5Zt2xxZEcPB8+iQ8Nvq+AJ0kRVKCPtMFCSfUEWX029/K3PPb5Nbjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gAyMt6EIokCy5ggDPBpb3Dz/homynVKhm+GvF1DnDcI=; b=UbmTXRdfw0aIZ4PJXLQ84UaLVx2ay4e2v1REwjMjuVADQ16TKXncTEjq5yqm7p/+JAHVAj8gq1tJ2Kope2RJ88p1EC8sfNLqyp8UStXXuc35ZbWQkTbxXLENbMyecnlb75TCFxnIHcSjtPqG6VE660UV8/zb+jZtd86uW14sOio= Received: from DM6PR11MB2777.namprd11.prod.outlook.com (2603:10b6:5:bf::31) by DM6PR11MB3083.namprd11.prod.outlook.com (2603:10b6:5:65::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Fri, 9 Apr 2021 12:11:09 +0000 Received: from DM6PR11MB2777.namprd11.prod.outlook.com ([fe80::380f:b21a:cba2:7c18]) by DM6PR11MB2777.namprd11.prod.outlook.com ([fe80::380f:b21a:cba2:7c18%5]) with mapi id 15.20.4020.021; Fri, 9 Apr 2021 12:11:08 +0000 From: To: Subject: Re: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement Thread-Topic: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement Thread-Index: AQHXLRnq9RpxBsB7oU+h+ykUgcKl36qsGKOA Date: Fri, 9 Apr 2021 12:11:08 +0000 Message-ID: <20210409121107.mcjo6cbsequjd3v4@sekiro> References: <20210409082522.625168-1-tudor.ambarus@microchip.com> In-Reply-To: <20210409082522.625168-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: microchip.com; dkim=none (message not signed) header.d=none;microchip.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [109.210.128.197] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68be5f5e-b187-4b8e-0c47-08d8fb508f16 x-ms-traffictypediagnostic: DM6PR11MB3083: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RLd0Up32wQfIrjlGaTPX+1UDk7UMdAan/66pi1mQBRZ+qic3ALI1HfwS006xbayybnPq2N0wKMz/jgJn+JdV7YoElFOGoXxLV3XR5Pq2l7ihpSgdIEuWTuaEVhwv7hnBsmML7JguDK/Mk1pGKvyxnz3W0Cn4y7CPzuYYfcyT4HlG1GI/SAAmzRc+m3RfOKQd1CXqeH4kw88AlA82LVyhZ2f+Cqcp64QbP2jJv07AUdSiLTUYbicO/IJtTXppAoH6RKboZ+ep5R3FU+7qa7xbeE2ig694OJEJFxDwzJx3Y9mOQGVEjPICi9WZUJkJbbkr2XoDa7kkaGWSlYba+b0pRI8/yIkpyLO566vx2N/EGIKCoCKk+RMzXOn6YMHuQewCHNpqdigT7kf/iF6SCZlC5zpSCCuWf2BbCLH3OCHzL9nY0knLfUtJSABY66TG4faxskdPs02cQAKDN1dD3FRMm4f+yhyfuSBkPSyr1J+2em81zDHfsFTcyIH6T80rRZUBZVYP/ssxsZY8wSlQXiGTM/yDSXfvF/3b8FaHoPJh5BSxv5DBbY2CkOAL2f4ITimknbrC5AWoKPO5Ha2gTp/aO8AUosRoPKNAGwHobN5lHRgQYGxoE7FFNI0xFnLdS3beR9/q75QDWMCE1Ypj8NDXvhLPMl5BqjzbEubYaL8ZhZ8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2777.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(39860400002)(396003)(366004)(136003)(346002)(376002)(91956017)(66556008)(1076003)(33716001)(66476007)(76116006)(26005)(6506007)(66946007)(64756008)(4326008)(2906002)(6636002)(54906003)(66446008)(5660300002)(38100700001)(186003)(9686003)(86362001)(71200400001)(478600001)(6862004)(6486002)(8676002)(6512007)(316002)(8936002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?IsEqUIzI0kyQlmcll8SrZoHckAOboGrKg6TOgmIVX7E8so1MrJtkg4pxaFc1?= =?us-ascii?Q?SkKOTdg2G+d1YxHm8klIIz7Tj2Ppx5jkSXaqAslR/rtuzFZ00xE7VPvI2j5B?= =?us-ascii?Q?iy1h40YqcrXPolYsjfTaOvu1C5lc84UUXqAJ2hL614hygvXTg8ctk4XyAew8?= =?us-ascii?Q?TYv8oS62hh0OPgzdJL6wt8CmWN4bCqdvftOf3aVC/vQfFhgxgo2+osKKzdxO?= =?us-ascii?Q?6rqaItEEfgnhoyNnZh74kG6kMlzb1o0iAFWm23Wc4G8bZz0IVkQftZ8hZR3l?= =?us-ascii?Q?XSsx1NwzQnmz4spAJqUzY4dOkkT2RWWNDLWUnER2MsjRXfwKk/ofIhcanxcs?= =?us-ascii?Q?Wmdm1Gll/OMAUHAwLEaTK4++PdegGhVlHAnhknOnddavWuUBpM46jb7X5MVB?= =?us-ascii?Q?d0j24W0FE5jTQnDgfT/HC6ofIR8EnF1JtVKc+inI7EuR7k+ZiaiGWQyTM8M+?= =?us-ascii?Q?mQc2OWZewdZ9KoLetVoVIZPc1HT0U3RR5Io5ZrdWEAqEdqkBkD85ZCrVwRkd?= =?us-ascii?Q?G56TRv2/9/nMOG2ROJBCRcVldoBkmtMjgwoardsJAatvZ+0OyotMqBK58fW0?= =?us-ascii?Q?hSpFA/+7gc7MiF39SrKT7X/LkqiCT6BBopQwPMPUl7kMtT15QJUF0w2Q1NP2?= =?us-ascii?Q?QK9ZC8V9Z0Ln8GbBoYjhJ8CcbJKxNWx6NzyUyL/f1LXlpB13jJJrmOc20k5G?= =?us-ascii?Q?qF0m7AZNbdvzIHJdRlM5WIr75wviEsMRQIYuaeJr+8YBFNjvU4azCOFjUFZM?= =?us-ascii?Q?6EyxWiQO1SNLXHJsZtvdVVvXOfl6s7amoWK5IaZJbfxVjpGWIi2La3DxTkG4?= =?us-ascii?Q?3Swo72scdLtv3g9yHc8929lRenSJdKxQbA6APYmrysDvFr+tskHHxzaS5F7t?= =?us-ascii?Q?eFo4oesCnFMlVXPjTs3+XqFooU7BoJ6cwRBSsWulor+T3WeitHyQajxfQnCP?= =?us-ascii?Q?5RmnxBKjy616nswldKo+PiJH1o1VG890yA9XdrBlsJDP66LtYhCHwKjD7EH0?= =?us-ascii?Q?U0dY9HMfB10iyFOhR9i4SWtLivCLLJq8X5VYWAd2PdI+20TzOj4qOxOO68hF?= =?us-ascii?Q?Q2iq/8e3gugEX7yzIUoFwdrI0piLTnihj0r7vaERH4qA78flf9a9NakrCW84?= =?us-ascii?Q?bVwRggOC6EE2nrs/MgWwgLj93hUtOQb/owIPd5P5GraatZ1QTvZNHDzNO9ey?= =?us-ascii?Q?l8iJPglsK/EofWwaxS7lNfo+zzmQg3FJjxnT4zw8v9gZufSnWMbt6hIxaszi?= =?us-ascii?Q?8kFFBm0Cvk9/ZhT//Ae5iQArEK75VSouVtRiJDR1aJAoInAOVAzvUUcp/o5p?= =?us-ascii?Q?xDhUu044oisHqoB68CupKnjlDequvLnAnQmgWwoMDww6xA=3D=3D?= Content-ID: <85BA562FCFCBD44C95621F4F6C025A7C@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2777.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68be5f5e-b187-4b8e-0c47-08d8fb508f16 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2021 12:11:08.8068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KG0pB6vVtEdkk6VgGPnqBX6KcAAcyI8l4cbK3YGOgg29yXvtr11dLmPbsEIC6J6NVPP4j0dZjqwXH4QSzsQ7laTW6UswSba3M1t8Wo0yNdA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3083 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_131113_003741_3C448D10 X-CRM114-Status: GOOD ( 20.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 09, 2021 at 11:25:22AM +0300, Tudor Ambarus wrote: > The slew rate was enabled by default for each configuration of the > pin. In case the pin had more than one configuration, even if > we set the slew rate as disabled in the device tree, the next pin > configuration would set again the slew rate enabled by default, > overwriting the slew rate disablement. > Instead of enabling the slew rate by default for each pin configuration, > enable the slew rate by default just once per pin, regardless of the > number of configurations. This way the slew rate disablement will also > work for cases where pins have multiple configurations. > > Fixes: 440b144978ba ("pinctrl: at91-pio4: add support for slew-rate") > Signed-off-by: Tudor Ambarus Acked-by: Ludovic Desroches Thanks. > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c > index a5d328808e4c..4c01d8471ffa 100644 > --- a/drivers/pinctrl/pinctrl-at91-pio4.c > +++ b/drivers/pinctrl/pinctrl-at91-pio4.c > @@ -801,6 +801,10 @@ static int atmel_conf_pin_config_group_set(struct pinctrl_dev *pctldev, > > conf = atmel_pin_config_read(pctldev, pin_id); > > + /* Keep slew rate enabled by default. */ > + if (atmel_pioctrl->slew_rate_support) > + conf |= ATMEL_PIO_SR_MASK; > + > for (i = 0; i < num_configs; i++) { > unsigned int param = pinconf_to_config_param(configs[i]); > unsigned int arg = pinconf_to_config_argument(configs[i]); > @@ -808,10 +812,6 @@ static int atmel_conf_pin_config_group_set(struct pinctrl_dev *pctldev, > dev_dbg(pctldev->dev, "%s: pin=%u, config=0x%lx\n", > __func__, pin_id, configs[i]); > > - /* Keep slew rate enabled by default. */ > - if (atmel_pioctrl->slew_rate_support) > - conf |= ATMEL_PIO_SR_MASK; > - > switch (param) { > case PIN_CONFIG_BIAS_DISABLE: > conf &= (~ATMEL_PIO_PUEN_MASK); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel