From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E54F0C433ED for ; Fri, 9 Apr 2021 18:43:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F31C610FC for ; Fri, 9 Apr 2021 18:43:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F31C610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WlwTyRzoBAGxHCQhepMBTXARM0KugPKzFebCx/Fuz9g=; b=cmEIQtfWq3rKG6XRwFIoHHNcK VYfOiOxNooz83iiFSR7PtTeBElxStxOwiiO+GC/lh25K1A/wbOTdbIKIq3EtsmjP99h5HQO8DG3Qe WCFnZPH+NsMkWbKNq+Uoro8EWKFF8CW20ZP1Yf92roajdroUY7NTp/MAm9AAAjYAHVh+gzYAVshHx XaCvqXy1/3CCDbkRB88feKWJ3oN9ejWgACoP17hfJ488s9hpZg+YOH+aZGoXn6z9HxrqZI9YYfxuy Pnw4xbGnixF+FQ8vOP1vNAf5H7uVsx135k8pMoYF+xF/XOtqOUFZkzpMPfV8vr0kVPkU0wdbunbSr duvWhOAJA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUw4N-001MM8-LV; Fri, 09 Apr 2021 18:41:27 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUw4K-001MM3-TJ for linux-arm-kernel@desiato.infradead.org; Fri, 09 Apr 2021 18:41:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4MvFSu+iSn/dauM/cnTOpr/Gc9vHIrXjG/A41VJDYI4=; b=5FRqjQ/TI0PCrRNOhb1y9sEGxL swBa6o9LZAhULlNc9nF7erjyCCXo+TdVWpvP0bIc7VUzdQri8Qc6+YGmdtaS8iap6UZ5c+NU5lrE+ BBHvEap1YeNkV0vofSybnXeZgiXEDLW6jDvhv04mGyTJ5E6+bQBMV1kSOYYuYcxQ6HOav4mU2jiO2 bhTgaWhc6bsDmddWl3bpYvGfMc09mFV3xpbqlWUGdCfhl96UbSHOJdZimwigAiGeB2bvMPLHxPWrP u4ByZVYnvA2JTd7kRhyX+sLtWsNFAj93Y1LbdmsQaIc4nraGEN9d3Xq/aPMRROzPpU0X2gppWweiC tOgmV8oQ==; Received: from mail-ot1-f44.google.com ([209.85.210.44]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUw4I-004jZA-0N for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 18:41:23 +0000 Received: by mail-ot1-f44.google.com with SMTP id t23-20020a0568301e37b02901b65ab30024so6627660otr.4 for ; Fri, 09 Apr 2021 11:41:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4MvFSu+iSn/dauM/cnTOpr/Gc9vHIrXjG/A41VJDYI4=; b=DEBL4nW4YECVqVYu1b9+ucvfaVNUue+7ULYIDRH9MvPyzv8WmppX9E7UzzKdW+Wkd1 MUoUQF8Hs4PhvQko5OoGwizIDqUqiFSEsu6Zuat5/lQBIDZQNdqBqLvTuSRFMVO5Jyzc Hj6qvOfm6RndoajWk6uzkR+KGGwuIezynF4XnvPH9ZGNpmbdjeReZKPRNLPJRW26/F4S sRHKTNOCAVD6Q8yydckgAJ1HwNDfPRJ05qzowUbbsdhkkTXYeo+BC+JKBRNq8TuDrLac eeMtLDdTsGvjSJW3Aa4hm20dtvdDqEBzq1Ti8Z+Xrmqgw/9huuCFsKZpwX+pxYpFPqMu 7P+Q== X-Gm-Message-State: AOAM530HqHQRGmo74QY04uOtK0kvQ5DpbV0u94RIWQr6bVCwk+fdQJks RvHijD21XiOH6QX2/vfbwZdraCdPBw== X-Google-Smtp-Source: ABdhPJzGKW/WQeP+HhyULbXe22Y/RLS1g/vF+rFi385EeuxrtQnl324VEHdsSv/nFS6zXrD211MquA== X-Received: by 2002:a9d:68ce:: with SMTP id i14mr12827904oto.151.1617993680723; Fri, 09 Apr 2021 11:41:20 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j11sm667128ooo.45.2021.04.09.11.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 11:41:20 -0700 (PDT) Received: (nullmailer pid 3937011 invoked by uid 1000); Fri, 09 Apr 2021 18:41:18 -0000 Date: Fri, 9 Apr 2021 13:41:18 -0500 From: Rob Herring To: Steven Lee Cc: Andrew Jeffery , Ulf Hansson , Joel Stanley , Adrian Hunter , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , "open list:ASPEED SD/MMC DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , ryan_chen@aspeedtech.com, chin-ting_kuo@aspeedtech.com Subject: Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-of-aspeed: Add power-gpio and power-switch-gpio Message-ID: <20210409184118.GA3934798@robh.at.kernel.org> References: <20210408015218.20560-1-steven_lee@aspeedtech.com> <20210408015218.20560-2-steven_lee@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210408015218.20560-2-steven_lee@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_114122_284123_AEE36F46 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 08, 2021 at 09:52:17AM +0800, Steven Lee wrote: > AST2600-A2 EVB provides the reference design for enabling SD bus power > and toggling SD bus signal voltage by GPIO pins. > Add the definition and example for power-gpio and power-switch-gpio > properties. > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to power > load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is connected to > a 1.8v and a 3.3v power load switch that providing signal voltage to > SD1 bus. > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > disabled. > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 signal > voltage is 3.3v. Otherwise, 1.8v power load switch will be enabled, SD1 > signal voltage becomes 1.8v. > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and GPIOV3 > as power-switch-gpio. > > Signed-off-by: Steven Lee > --- > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > index 987b287f3bff..515a74614f3c 100644 > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > @@ -37,6 +37,14 @@ properties: > clocks: > maxItems: 1 > description: The SD/SDIO controller clock gate > + power-gpio: '-gpios' is the preferred form even if just 1. > + description: > + The GPIO for enabling/disabling SD bus power. > + maxItems: 1 blank line > + power-switch-gpio: > + description: > + The GPIO for toggling the signal voltage between 3.3v and 1.8v. > + maxItems: 1 > > patternProperties: > "^sdhci@[0-9a-f]+$": > @@ -61,6 +69,14 @@ patternProperties: > sdhci,auto-cmd12: > type: boolean > description: Specifies that controller should use auto CMD12 > + power-gpio: > + description: > + The GPIO for enabling/disabling SD bus power. > + maxItems: 1 > + power-switch-gpio: > + description: > + The GPIO for toggling the signal voltage between 3.3v and 1.8v. > + maxItems: 1 > required: > - compatible > - reg > @@ -80,6 +96,7 @@ required: > examples: > - | > #include > + #include > sdc@1e740000 { > compatible = "aspeed,ast2500-sd-controller"; > reg = <0x1e740000 0x100>; > @@ -94,6 +111,10 @@ examples: > interrupts = <26>; > sdhci,auto-cmd12; > clocks = <&syscon ASPEED_CLK_SDIO>; > + power-gpio = <&gpio0 ASPEED_GPIO(V, 0) > + GPIO_ACTIVE_HIGH>; > + power-switch-gpio = <&gpio0 ASPEED_GPIO(V, 1) > + GPIO_ACTIVE_HIGH>; > }; > > sdhci1: sdhci@200 { > @@ -102,5 +123,9 @@ examples: > interrupts = <26>; > sdhci,auto-cmd12; > clocks = <&syscon ASPEED_CLK_SDIO>; > + power-gpio = <&gpio0 ASPEED_GPIO(V, 2) > + GPIO_ACTIVE_HIGH>; > + power-switch-gpio = <&gpio0 ASPEED_GPIO(V, 3) > + GPIO_ACTIVE_HIGH>; > }; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel