From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77FB1C433ED for ; Sat, 10 Apr 2021 16:01:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03006611C2 for ; Sat, 10 Apr 2021 16:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03006611C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BCmwZ+tVA5Tsp1N7m4PKztKGiHBYgjIrggNM1Q2Mij8=; b=lsvymrsgJ9puP2+YSvKiY3iZj jZJDM+vmjpY+jmaYR0aYmeyPkadYFzZIpJkoyAzGlf9DM63mLucx6nJxxjx8YrTW1FTapDGfxcNUH DB49P5lmwUwbqXNCmWHyP6nSSaUF8reM0BVLBU5sV89nhO/PjATe+lD61WPmuMSL6AxjNlhipyu5A bTXryU1Fa3NqtrHFtO/PM93OIeHs6D1ZmwkGabMmvddpi2EwzNJOS3wdyWZWJ7ljcmdhKMcILzwHK oT8JGedN9rIiYZ8y9HM0vIYNeLkC4K/2KgvYQapkAz+QgORu+LjR/a3MYSY/u/EyWrfPzIbU5vjBV kgcBf0v+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVG0c-0034cW-IO; Sat, 10 Apr 2021 15:58:54 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVG0Z-0034c7-K2 for linux-arm-kernel@desiato.infradead.org; Sat, 10 Apr 2021 15:58:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CzOBLJLIpMaSm2apRythmsTcqiiwrKSDjrbInU9e0SA=; b=oCq7aMjSkqNVKs1sJRCm9Y3AVh y0pV9cKRsZYZU3ZmejLs2S3z7ivY0FCD53leI4JGDZ0RZ9Tx2Kov9oqWeggoxvqIWoSEgpEZVeb2z HZuiom9VREJHfjWopHLayBqBZL3RrjTVan8kqrEQAW1FJgMCacmf6dR6wNlnbPmfaJoUWSjXjckuV jGjt0MGO7dAGEDynbFGAp4uDNG0k9cDvYDEka2j4RV7Adcj7avnFAa7M+4R1+sazgmjWRmkhjuecY A2Ik/AIZgH0gdLMksMwd5beuKfggjTPnp2ategzcWz2cabI5oufF4nHMDt3nIe9OoPdqzyYMrt1b8 O+WbDnog==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVG0W-005AqA-UN for linux-arm-kernel@lists.infradead.org; Sat, 10 Apr 2021 15:58:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CzOBLJLIpMaSm2apRythmsTcqiiwrKSDjrbInU9e0SA=; b=c5UKjvS8rNqagvElEmnq5mWQ2 sOG6gW99tI6xwZXqcrM0Omsn7OTm2fu3665e5SLzAUZcWgmuvpx4LsuO8/sfRyv5AHrB1VxlWAb+2 zb8sbnGIvkTUbOVv1OeaDlPYJRbaBVxn9aQ7OEXrvQXVMJ89mFmJItp1FPI6+1z4kCSLRgjYKV6Eq 1ehY/+L/+7Sd24BuLZQuq1uqmViCX215IU2khq8hUKbTdXz6jbowwCm1+k1w9WhYpo20Mm1p3GXMQ lWvTKWoggbyjkpAqlg4ihTHh2CWrkU497gIFI6Q5aTR6qrgU8es4zjrms5ywWgA05k/kw4Fv0Ni50 rysPj65UQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52272) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVFwk-0003Cf-AS; Sat, 10 Apr 2021 16:54:54 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lVFwf-0005Xb-GK; Sat, 10 Apr 2021 16:54:49 +0100 Date: Sat, 10 Apr 2021 16:54:49 +0100 From: Russell King - ARM Linux admin To: Matthew Wilcox Cc: Ilias Apalodimas , Jesper Dangaard Brouer , kernel test robot , Linux-MM , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, open list , linux-fsdevel@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Linux ARM , "David S. Miller" , Ivan Khoronzhuk , Matteo Croce , "netdev@vger.kernel.org" , Grygorii Strashko Subject: Re: Bogus struct page layout on 32-bit Message-ID: <20210410155449.GI1463@shell.armlinux.org.uk> References: <20210409185105.188284-3-willy@infradead.org> <202104100656.N7EVvkNZ-lkp@intel.com> <20210410024313.GX2531743@casper.infradead.org> <20210410082158.79ad09a6@carbon> <20210410140652.GY2531743@casper.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210410140652.GY2531743@casper.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210410_085848_986603_12A68B3E X-CRM114-Status: UNSURE ( 9.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 10, 2021 at 03:06:52PM +0100, Matthew Wilcox wrote: > How about moving the flags into the union? A bit messy, but we don't > have to play games with __packed__. Yes, that is probably the better solution, avoiding the games to try and get the union appropriately placed on 32-bit systems. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel