From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 313E0C433ED for ; Sun, 11 Apr 2021 14:02:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF9716103D for ; Sun, 11 Apr 2021 14:02:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF9716103D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nuEL/lIthxkYXZLUjXruwIbpkBlZD2tVCzPz63SH16w=; b=VTiY7zZfMaibmky9d0b3qf5qd bHclGHsifo6njTHMDDioUYjHw4nq0KMHx9MwIOzH3jEGL8R0Jvz/tV+iQOxDsWdh3VDwEwIXqjKjS g4npqr/hC+MWVH8TljGGCniy/TQVHWdBvD+tw7vaMPjl7JcqkeHaJ39kTKA7ULfgExHVkmnZZGnE2 VTRmkgrk8URrykfopB3iStLU8TBBfsB+PJIejfWNvqe1/pvS2NS/K7LtsCrWMtKaEoKq3rBc3S3Dl ze8Y57ZCJEHv6WkSHngx+ICf/X9N7NyaxI8z5BO1ghgGKGlyey3Ui26jiLQesuoDMUx+k0ahiAdrL c38HerQDw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVadW-004YK9-BE; Sun, 11 Apr 2021 14:00:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVadS-004YJt-Pk for linux-arm-kernel@desiato.infradead.org; Sun, 11 Apr 2021 14:00:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=nuZrvQwDvKqXvl286aYcV9+Macxv9ifmRwkQ//fTh50=; b=h3XCxycR1YAT/YmovDUFU4Mxnu 3vIWsAorPdsUioOI0NLr6Gb/1QcUuD7Lx03C4sNXS3l96f5XkV2drSfuuoxv6s88W0z9XpIgho1nZ 0hLBQqPcpRBCzeivII3r47zG+Vl7/4I0ogy259tUYRnMcFiuR2cqdbwL2O8xeu57KoPfEA0nbphwu M4KHD0nWhPMr6Bctqi62qSEVP3FXQMCM0X/HHxgr0rXRhX7U/xVT5Mx/W30cpMzDzJcqhM1aJUGa3 xqIY5jAmkFHB4fOShc2avnTAFkKSrhxGbrT2y+TpAJGSso6N+2PXrnWhWVSAFpymlLLP1okHYDQ3R xAWWeXwQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVadP-005Y7M-N8 for linux-arm-kernel@lists.infradead.org; Sun, 11 Apr 2021 14:00:21 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 55A8B611AD; Sun, 11 Apr 2021 14:00:15 +0000 (UTC) Date: Sun, 11 Apr 2021 15:00:39 +0100 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: adc: exynos: drop unneeded variable assignment Message-ID: <20210411150039.1dcc76b8@jic23-huawei> In-Reply-To: <20210410164728.8096-1-krzysztof.kozlowski@canonical.com> References: <20210410164728.8096-1-krzysztof.kozlowski@canonical.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210411_070019_829067_F9EC3221 X-CRM114-Status: GOOD ( 18.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 10 Apr 2021 18:47:28 +0200 Krzysztof Kozlowski wrote: > The initialization of 'ret' variable in probe function is shortly after > overwritten. This initialization is simply not used. > > Addresses-Coverity: Unused value > Signed-off-by: Krzysztof Kozlowski Too late for this cycle, but I've queued it up for the next one. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if we missed anything. Thanks, Jonathan > --- > drivers/iio/adc/exynos_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c > index 784c10deeb1a..2d8e36408f0e 100644 > --- a/drivers/iio/adc/exynos_adc.c > +++ b/drivers/iio/adc/exynos_adc.c > @@ -794,7 +794,7 @@ static int exynos_adc_probe(struct platform_device *pdev) > struct s3c2410_ts_mach_info *pdata = dev_get_platdata(&pdev->dev); > struct iio_dev *indio_dev = NULL; > bool has_ts = false; > - int ret = -ENODEV; > + int ret; > int irq; > > indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(struct exynos_adc)); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel