From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8EB1C433ED for ; Mon, 12 Apr 2021 00:11:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 720BF61003 for ; Mon, 12 Apr 2021 00:11:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 720BF61003 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=aaLzKNaN+pLDpzcw/T7YzwtCcYB/bIF9uwSg543t3iA=; b=B9tqjQNk8stO4LXeTXJVgkEqP7 oBUf6TXJpHVJQzwF7H+kTOy3z7mszH+t7vTKdlyzvzE98oAa2qosIEOtgwqUvqLXD8c37UVsDHmQK TiGSII0Y2vGWaJEciZn3G4Hg/fGCMo9how2LoJfhTmmVkCv+cKA7nJgKVDKEHB4Ghdb1GBPs57EN4 aRh5yoz6r0u0zI1Ge8BpVFdJ2pzAPhLT4d6vZwe9Gro6RG+5ClXAuG9HA4mTTDy3Ke9SpXs3Qd3Qb 5Y4bo6OftD7o21QGKyYye11uyHAQVs706MPvBBuS/bqFNTtWcnsKM58sslTCv4x3WpFe3ym9nR5+t wuaT511g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVk8Q-005KY3-SC; Mon, 12 Apr 2021 00:08:59 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVk8O-005KXt-PN for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 00:08:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To:References; bh=Jga2KjeYhxCZiFmqqzk7EHxzmnZZEOwBUTSWWtgZKQ0=; b=jsmyoofizpipZyxBxGOt3+lUd2 xlw+Sv/pgmt5wRbJN9RHJv+Ue2gBwsrnk+2+Kydi1QvQOUi/8BFROaBV4waM6cEOehXCsWNY9C0SE tfN00K8tlzpY6VloVNi1rI/aGgeeMKtyRYP9t2rm5mdsxoIgCedc3AqFSqiquVFcFrgr7iwimJocg M3iqnGNTlLG+V/bwLjlce1Y+D+Q8owyzDl+pV9iuJsrV8tGzCYmX2zZiQFYkQ4gn1YAJ8IaP2zTD9 YW9q0VccUFBjuF0K4yLZanBaPRI1trHiRnSd+KQ1vE46ROxW0WNHUKT7Zpbl+ahuFuGgXsO5XzK/S Z49ijxpA==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVk8L-005npE-VG for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 00:08:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 936CE1FB; Sun, 11 Apr 2021 17:08:41 -0700 (PDT) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1AB1F3F694; Sun, 11 Apr 2021 17:08:39 -0700 (PDT) From: Andre Przywara To: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Michael Weiser , Daniel Kulesz Subject: [PATCH] arm64: dts: allwinner: Revert SD card CD GPIO for Pine64-LTS Date: Mon, 12 Apr 2021 01:08:13 +0100 Message-Id: <20210412000813.13071-1-andre.przywara@arm.com> X-Mailer: git-send-email 2.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210411_170854_091433_7903CED1 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 941432d00768 ("arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card") enabled the card detect GPIO for the SOPine module, along the way with the Pine64-LTS, which share the same base .dtsi. This was based on the observation that the Pine64-LTS has as "push-push" SD card socket, and that the schematic mentions the card detect GPIO. After having received two reports about failing SD card access with that patch, some more research and polls on that subject revealed that there are at least two different versions of the Pine64-LTS out there: - On some boards (including mine) the card detect pin is "stuck" at high, regardless of an microSD card being inserted or not. - On other boards the card-detect is working, but is active-high, by virtue of an explicit inverter circuit, as shown in the schematic. To cover all versions of the board out there, and don't take any chances, let's revert the introduction of the CD GPIO, and go back to the non-removable property for the Pine64-LTS. That should avoid regressions and should work for everyone. The SOPine card detect has proven to be working, so let's keep that GPIO in place. Fixes: 941432d00768 ("arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card") Reported-by: Michael Weiser Reported-by: Daniel Kulesz Signed-off-by: Andre Przywara --- arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts index e79ce49e7e6a..843338e19694 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64-lts.dts @@ -21,5 +21,5 @@ }; &mmc0 { - cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 push-push switch */ + non-removable; /* card detect is broken on some boards */ }; -- 2.17.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel