From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6296C433ED for ; Mon, 12 Apr 2021 08:17:10 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A4A0600EF for ; Mon, 12 Apr 2021 08:17:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A4A0600EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zPnZzIGjSWhTbIgyNLdYaeuisftUYG2tO/iZ+pA9/yE=; b=fMp6XyMSdTbUK2Mzzu9+CWtyF VfF9V6r71aNTRD2147Ku+d0q7nv12gT7E2SYhIBg3CBBMesYOk9BxKtsGudVOfnwkDf31rgcqyc6y sGKroXA2+Ilb13Bls4HbB2O9LXbvecVU7JEJNdXn6fgtjNtXqgWyqKFzVw4Z0ouIwO5N55awsTFQ4 2y+xq2T9GfcmlIumsXPEkDB6ncogK8Kp15HYLDShSLjiqdgwS/qjbGRmx+vbdCFRi3RwCFG/RUESI gavBeTCPo1oZBnz+1K92SwGWWbgdXZnAEVjeuPixxdmKdZlRdTB1HLSKzxhwkHH6uD2ECVP6LQwqS KnawMt7Pw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVrjG-0064iK-NI; Mon, 12 Apr 2021 08:15:35 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVrjC-0064hh-LO; Mon, 12 Apr 2021 08:15:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CaFPVzFbf7fzB0behm4q3vs+AcCwPNn/fO4/oYpeYXg=; b=2f5PY66IwdDhTdA0u8sxsXzumn jHU0dVH51RzcwxzEB1HYSQD6R/VdwP+MW56jjP9CZMCI0/KvBWwt29rIGBq/i5oXmAyLnPkgf9p4i 1jEUOyr3+lhc38yfXhfPP2GNwKjje0W4W0X+0TEPWMGNStvJjuXSyGZ5MtPPg8B1SDcuEeZpMU/2A p4Dgb0k77jzVseXyGSmTA6LbZBejlPE3wWgLHU3ZlaGCx7bEY14qk51a4t2ioxMGMwwSBa3SatOPS 91ANcpmJDI7HmygzAe2GhDUzwEyt7qKcqisWDD+PDZkvJ02uIdaKj8Lfr6FjV+CXGtJpHptiZf0k5 9j5oK2PA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVrj9-005xuz-WD; Mon, 12 Apr 2021 08:15:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F7FB600EF; Mon, 12 Apr 2021 08:15:18 +0000 (UTC) Date: Mon, 12 Apr 2021 09:15:15 +0100 From: Catalin Marinas To: Andrew Morton Cc: Andrey Konovalov , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Nathan Chancellor , Arnd Bergmann , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , "moderated list:ARM/Mediatek SoC..." , Walter Wu Subject: Re: [PATCH v4] kasan: remove redundant config option Message-ID: <20210412081515.GB2060@arm.com> References: <20210226012531.29231-1-walter-zh.wu@mediatek.com> <20210330223637.f3c73a78c64587e615d26766@linux-foundation.org> <20210411105332.GA23778@arm.com> <20210411150316.d60aa0b5174adf2370538809@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210411150316.d60aa0b5174adf2370538809@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_011524_073425_5FCC4325 X-CRM114-Status: GOOD ( 27.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 11, 2021 at 03:03:16PM -0700, Andrew Morton wrote: > On Sun, 11 Apr 2021 11:53:33 +0100 Catalin Marinas wrote: > > On Tue, Mar 30, 2021 at 10:36:37PM -0700, Andrew Morton wrote: > > > On Mon, 29 Mar 2021 16:54:26 +0200 Andrey Konovalov wrote: > > > > Looks like my patch "kasan: fix KASAN_STACK dependency for HW_TAGS" > > > > that was merged into 5.12-rc causes a build time warning: > > > > > > > > include/linux/kasan.h:333:30: warning: 'CONFIG_KASAN_STACK' is not > > > > defined, evaluates to 0 [-Wundef] > > > > #if defined(CONFIG_KASAN) && CONFIG_KASAN_STACK > > > > > > > > The fix for it would either be reverting the patch (which would leave > > > > the initial issue unfixed) or applying this "kasan: remove redundant > > > > config option" patch. > > > > > > > > Would it be possible to send this patch (with the fix-up you have in > > > > mm) for the next 5.12-rc? > > > > > > > > Here are the required tags: > > > > > > > > Fixes: d9b571c885a8 ("kasan: fix KASAN_STACK dependency for HW_TAGS") > > > > Cc: stable@vger.kernel.org > > > > > > Got it, thanks. I updated the changelog to mention the warning fix and > > > moved these ahead for a -rc merge. > > > > Is there a chance this patch makes it into 5.12? I still get the warning > > with the latest Linus' tree (v5.12-rc6-408-g52e44129fba5) when enabling > > KASAN_HW_TAGS. > > Trying. We're still awaiting a tested fix for > https://lkml.kernel.org/r/CA+fCnZf1ABrQg0dsxtoZa9zM1BSbLYq_Xbu+xi9cv8WAZxdC2g@mail.gmail.com Thanks Andrew. I didn't realise it was sent and then dropped. However, we should decouple (or rather reorder) the two patches. There's no functional dependency between removing the redundant config option (a fix for an existing commit) and adding support for KASAN_SW_TAGS with gcc-11, only a conflict in scripts/Makefile.kasan. Walter's original patch applies on top of vanilla 5.12-rc3: https://lkml.kernel.org/r/20210226012531.29231-1-walter-zh.wu@mediatek.com -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel