From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE0AC433B4 for ; Mon, 12 Apr 2021 08:38:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42E4360241 for ; Mon, 12 Apr 2021 08:38:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42E4360241 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Vfp6C9aEEKcNvDzp1t9T6I8ZrNZIq4MqTmrc+HiouZ8=; b=SubZ6PVSUgjKq561AneBhLAl+ BYXLEzK4snkVEaNkqs0sro1d7fE1nTJHJASR0A+3TMN5q3+1Hqkeato4Lpa0J2oaRx0gyjniv16Gq 5WjovVqWl3lPIhypqLT2t0ZbLg7lnhLGd+/yveHZi+AEksacQuki3OBoj3SYqpL5W2mzJYGfMH70N WbuAVhgJXfiVm6NrJ48/BTrGpthx6tSzK0Yth/RZEIrwmfe3Z3L1Ca+I9PLHCv4iTXPlblnzUvOO7 XhSALc4RszVFwW6yg2x6uD21heGwlH6K7Czac+cjflX/TkMs335sirT0tfCCWas93JqnRVA7XLpVC 7qGxJJRLg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVs3U-0067f9-OM; Mon, 12 Apr 2021 08:36:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVs3R-0067et-Dt for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 08:36:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HRhjYluxZformnP5jjzi3Llar19URgX6oT6zKlL2H8w=; b=NEgc7LQrs5V2CGVNvgbQMVxI/7 BNkyOLobpig+9K44zFefAW8uEMQ68Yp8MFXj7cK6Yl1Sp4XusoNPwg0+U5v+M2vta4GFiwc4vf9b7 apXtCyiei47OiFHYrzWur9F2CqDMMcVqmH6WjnASHnm8xxkM4lJmEWzoZNd74VPJOqcNWPjuO6+jh Y5puOkwv17xzvhGGxykYyISDNVWQU5DUT/AtLGlw+URNE01cpu9K0+Yc7O22BTYJXb6xuMW2pgeU1 8EMXYli6tLS8Oa7d9XNYq+DGI63Dv41SXtpqljlc+F4av5RYV7jjYrvJPTDSoGkwobMJKjBHwrjw0 1cXwNOPQ==; Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVs3N-005yus-Fi for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 08:36:19 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13C8a95Y076261; Mon, 12 Apr 2021 03:36:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1618216569; bh=HRhjYluxZformnP5jjzi3Llar19URgX6oT6zKlL2H8w=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=mKC01w7NmPQWUEyG++WeWiaipp4mQsa/faIlB4l/+3jZ7j2ie+/wiWyXQeNMJlVcT dfD+k/zIWGzHSHDZ/z7n6lW2C6zx9j+a4WCYq82hogFXojaxUW0JvQSb/IiIe6uM43 /JLbCbvPZMYzbWWMPOKLtpOm6XAM/2sVpEbSJoPc= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13C8a97j105316 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 12 Apr 2021 03:36:09 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 12 Apr 2021 03:36:09 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 12 Apr 2021 03:36:09 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13C8a8BO032018; Mon, 12 Apr 2021 03:36:09 -0500 Date: Mon, 12 Apr 2021 14:06:07 +0530 From: Pratyush Yadav To: Laurent Pinchart CC: Tomi Valkeinen , Nishanth Menon , Benoit Parrot , , Rob Herring , , Tony Lindgren , Vignesh Raghavendra Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: remove ov5640 Message-ID: <20210412083605.qnpf2mxy3rcaj7dv@ti.com> References: <20210412075306.102884-1-tomi.valkeinen@ideasonboard.com> <20210412075306.102884-2-tomi.valkeinen@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_013617_686385_596E891E X-CRM114-Status: GOOD ( 26.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Vignesh On 12/04/21 11:00AM, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Mon, Apr 12, 2021 at 10:53:06AM +0300, Tomi Valkeinen wrote: > > AM654 EVM boards are not shipped with OV5640 sensor module, it is a > > separate purchase. OV5640 module is also just one of the possible > > sensors or capture boards you can connect. > > > > However, for some reason, OV5640 has been added to the board dts file, > > making it cumbersome to use other sensors. > > > > Remove the OV5640 from the dts file so that it is easy to use other > > sensors via DT overlays. > > > > Signed-off-by: Tomi Valkeinen > > --- > > .../arm64/boot/dts/ti/k3-am654-base-board.dts | 27 ------------------- > > 1 file changed, 27 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > > index fe3043943906..76358b4944e1 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > > +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > > @@ -85,12 +85,6 @@ sw6 { > > gpios = <&wkup_gpio0 27 GPIO_ACTIVE_LOW>; > > }; > > }; > > - > > - clk_ov5640_fixed: clock { > > - compatible = "fixed-clock"; > > - #clock-cells = <0>; > > - clock-frequency = <24000000>; > > - }; > > }; > > > > &wkup_pmx0 { > > @@ -288,22 +282,6 @@ &main_i2c1 { > > pinctrl-0 = <&main_i2c1_pins_default>; > > clock-frequency = <400000>; > > > > - ov5640: camera@3c { > > - compatible = "ovti,ov5640"; > > - reg = <0x3c>; > > - > > - clocks = <&clk_ov5640_fixed>; > > - clock-names = "xclk"; > > - > > - port { > > - csi2_cam0: endpoint { > > - remote-endpoint = <&csi2_phy0>; > > - clock-lanes = <0>; > > - data-lanes = <1 2>; > > - }; > > - }; > > - }; > > - > > }; > > As for patch 1/2, you could drop the two nodes completely. Same question > about overlay availability. The &main_i2c1 node was added much before the OV5640 node in 19a1768fc34a (arm64: dts: ti: k3-am654-base-board: Add I2C nodes, 2018-11-13). I wonder if there is any reason for having it present even if there are no subnodes. One reason that I can think of is that this node defines the pinmux configuration and clock frequency which makes more sense here than in an overlay. > > > > > &main_i2c2 { > > @@ -497,11 +475,6 @@ flash@0{ > > }; > > > > &csi2_0 { > > - csi2_phy0: endpoint { > > - remote-endpoint = <&csi2_cam0>; > > - clock-lanes = <0>; > > - data-lanes = <1 2>; > > - }; > > }; I agree with Laurent that the entire &csi2_0 node can be dropped. Have you tested the CAL driver with this node removed and no overlay to add it back? Can it handle the error gracefully or does it crash and burn? > > > > &mcu_cpsw { > > -- > Regards, > > Laurent Pinchart -- Regards, Pratyush Yadav Texas Instruments Inc. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel