From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C2DC433B4 for ; Mon, 12 Apr 2021 08:46:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0113561277 for ; Mon, 12 Apr 2021 08:46:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0113561277 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/ed5HEwerlqvLGOe3DPGC7hZ/OBwvR1Go+yz9BC3Gks=; b=ji4Ja9jcXE9pFChbA4PJlVdyJ vRTMz0aechCpp0RdrfFRkhaJrt0dqjiWCWPI6tAzoh+yB4wLB2W4oKoJbyjZ2c8xsZ9IKGZU1SAyT jQH3KO4pb/3h041fmKqWJguGjz8u078oridOq8AQCH4zYiOYrII8SWI5o4r7wE/mcjA5+1WddG62U YjWsbHIMB5QhFiMq/h/h//BQJtx3igSA0M511rnV68fpyILBvFzJyfTOX1Phb5GZPFPH+Nn5st1O7 qQvHANgGFkm52DsZ3COVXdZNzM4sNDBCXh32Tud3ViqqTd5HTEwZ/ddpLINJaIPBvWcDwmeYN3yjA lilpCAimg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVsAv-0068Us-Sb; Mon, 12 Apr 2021 08:44:06 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVsAs-0068UM-Al for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 08:44:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=kBwmmfEhnxnMkwjBfKpRa+OtUqiDVgf+6Uq1v3KjUJM=; b=GhVjInnAryKEJUxyJvcFlWmFgT CeI1c00xoE9YgJ6kY09lUwGyVYHS12mO0IKLIR4uWKDNivae4OoXA0hZgYsShIMhVF7lDZPgHhyhv nLzmSOXiQpb2+zKsi+DBoHXzz7AmER7cpcnDsFR7ewM2evyeP3gy6pHRsv6OghUk8d6mUxN46riO6 bMFSrxV2IA0BrUjVKFpgXRKgJ4OnoLAMSin4X5K0nEHVrFY2B/zNVNmjL7l+oSYYF/f2yGmJH7m8R 4PNMgNp62U77bswHN4iy18Bg+uUUBEfi7pLI71wFmoFTa1jCR2N0mvmyuIuv6A3yafjbp4ISo2yrx dMqXmUnQ==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVsAp-005zGP-7l for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 08:44:01 +0000 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FJhsv5GGBz688MV; Mon, 12 Apr 2021 16:36:35 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Mon, 12 Apr 2021 10:43:46 +0200 Received: from localhost (10.47.93.73) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 12 Apr 2021 09:43:45 +0100 Date: Mon, 12 Apr 2021 09:42:19 +0100 From: Jonathan Cameron To: Kunihiko Hayashi CC: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Marc Zyngier , , , , "Jassi Brar" , Masami Hiramatsu Subject: Re: [PATCH v10 1/3] PCI: portdrv: Add pcie_port_service_get_irq() function Message-ID: <20210412094219.000031ca@Huawei.com> In-Reply-To: <1617985338-19648-2-git-send-email-hayashi.kunihiko@socionext.com> References: <1617985338-19648-1-git-send-email-hayashi.kunihiko@socionext.com> <1617985338-19648-2-git-send-email-hayashi.kunihiko@socionext.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.47.93.73] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_014359_602109_43D082CB X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 10 Apr 2021 01:22:16 +0900 Kunihiko Hayashi wrote: > Add pcie_port_service_get_irq() that returns the virtual IRQ number > for specified portdrv service. Trivial comment inline. > > Cc: Lorenzo Pieralisi > Signed-off-by: Kunihiko Hayashi > Reviewed-by: Rob Herring > Acked-by: Bjorn Helgaas > --- > drivers/pci/pcie/portdrv.h | 1 + > drivers/pci/pcie/portdrv_core.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h > index 2ff5724..628a3de 100644 > --- a/drivers/pci/pcie/portdrv.h > +++ b/drivers/pci/pcie/portdrv.h > @@ -144,4 +144,5 @@ static inline void pcie_pme_interrupt_enable(struct pci_dev *dev, bool en) {} > #endif /* !CONFIG_PCIE_PME */ > > struct device *pcie_port_find_device(struct pci_dev *dev, u32 service); > +int pcie_port_service_get_irq(struct pci_dev *dev, u32 service); > #endif /* _PORTDRV_H_ */ > diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c > index e1fed664..b60f0f3 100644 > --- a/drivers/pci/pcie/portdrv_core.c > +++ b/drivers/pci/pcie/portdrv_core.c > @@ -477,7 +477,22 @@ struct device *pcie_port_find_device(struct pci_dev *dev, > } > EXPORT_SYMBOL_GPL(pcie_port_find_device); > > +/* /** this is kernel-doc style, so why not mark it as such? > + * pcie_port_service_get_irq - get irq of the service > + * @dev: PCI Express port the service is associated with > + * @service: For the service to find > + * > + * Get IRQ number associated with given service on a pci_dev. > + */ > +int pcie_port_service_get_irq(struct pci_dev *dev, u32 service) > +{ > + struct pcie_device *pciedev; > + > + pciedev = to_pcie_device(pcie_port_find_device(dev, service)); > + > + return pciedev->irq; > +} > + > /** > * pcie_port_device_remove - unregister PCI Express port service devices > * @dev: PCI Express port the service devices to unregister are associated with _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel