From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75EABC433ED for ; Mon, 12 Apr 2021 23:55:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1DB361244 for ; Mon, 12 Apr 2021 23:55:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1DB361244 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tduv5lpoE36trP1If57woCXPFphDbVsH9BPJbOLyYeU=; b=YKVm80AGUpNm2Dtu0Jfz/iSYV Kk5HEHaTrEZBDQ8tS730Js1i0UZobzd2bNu4Mhe2eO6tD1o0ZYqjoWrtUrFpgyAD5Hh+aiB4osUFs 8/6JEmc+FJn4Csgd+amxasprdTnCH6icCK7CMAJGQqrGhLVBCfkxQnWx8YeCldE1/gZarMQl4KcVe /2zi9qzSREmahnFBx+EQJtCmmP+CIX1Sn4EUOGMIvpSFoCdPH70b3KBILjnNT69PizlklhhNNQBMv 3Y7oSGhd3PHg5RmyZ7yl4z7VAUcfEPHaBW4jEB0SE2fpQbNWm4GI4CkF1ibaSm9RepjJREMlhx+W5 toAmisnRQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW6NN-007vFK-DT; Mon, 12 Apr 2021 23:53:53 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW6NF-007vEq-H3 for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 23:53:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cgT1HApdmZ6zS0OsJ1xfBAFlpTT4bt9tHkmOVAqIDmE=; b=D3plxSIFw92izaSMuFQXUpEDBd gLlwDo0zlaMVe/xda+FCB4sp2J/U5AAjoubtnnvxxJSl/LDTL7WWrc6dWUxqR+Zq6JWzH/XlS8dqg EZfnqWxZZKtu3/nxRUOEK/cM1R17ylWxY44SqAPnNHrlYWp9S3IoDgbPKnw9pqvZiREjIQfZYydc8 ncuPoyY8+oB0CVPQ1RFxsKqqRgKN4726wZ0LQSEjFD+3R/SwTQBiSDd9SIOEM7uv5k1Y/eUWRRQW1 Ob54eed2RNciNujoXavEByMrysSiW+vRsrwiGVjvkr4xLhLNc/GfBHyMxrnl73Ek4Qr1nDvESslz/ hOgmT8Jg==; Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW6NC-006dUA-PD for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 23:53:44 +0000 Received: by mail-oi1-x22c.google.com with SMTP id l131so10203040oih.0 for ; Mon, 12 Apr 2021 16:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cgT1HApdmZ6zS0OsJ1xfBAFlpTT4bt9tHkmOVAqIDmE=; b=rLfqXGY3INUuJ2aRB/CzZnSw4KvS7BIaZPNNa/NJ1C6Dt/jGgiBhZl2iKVpg8KnTtY 7MPjxY1QIymJLvhWtu9lX2CCNfmk4y2TeONlYDrYiocw2TnD2jtNeJESwir3O3aSb30X 8AivrzRbyZLO64KNIsm0/yeVJ5bYFWdhV/anHLWvC+dcrkChxvWGjXgvDqKMhfr9NVAq uqzTsxGZkBkL+EAFLngxQnUc74zp5KTUZ9CBDmPrOIygQjfBgLBmTAnT9FXGd2vzTkow MBAD3KghXlIfSODGL/ftQxpjE9Cw3y+aAwyDmTs4yy1p3c+y+6Cc8eUmuzR2vK7K2QQj 0GzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cgT1HApdmZ6zS0OsJ1xfBAFlpTT4bt9tHkmOVAqIDmE=; b=Zgf/F7Bi6sb4GSegcJ+5dxbGTs9J1a+jt5FJZYDAO3AbC4nbz0u4l8lPM5wC1g/iiE Nf+wsSqn3rX/OvRzhnXdUU8nQ747mPbyh8u8x5+khXbQsos3d7Ci9+UZd6o7SZXE1/Wt JVwW+Yqcd06+XtTg2jrcQRno1hfK/esUAAhwP5CCQR6LI9pm0hgg/b4g5e/xgbrmVO/e QkmaHeVXmwdlXpSWfA3vH4M8aKPhHkdhQofOvetZ2dkHBPVxtUEhE8McxM71hcmn+rDS 8JCSIbj2qYxt/CNmkDV5z0XfPH02v3KJ0nQk0ibkOpz7yzRsPY/NJJuEP3hzgEKD0K9m jAHA== X-Gm-Message-State: AOAM533ND2KroVYbLxhw0jDF3s1AGnOqoHm5Atn0u+BT4q/mipWybVMG 0AlXvRG8LXa/ICbHnYuYu4OpkQ== X-Google-Smtp-Source: ABdhPJwB8eYTup93oYQNOALWr8lw5AXfKmpA25UytBaSHUI5Cm/0tYufSL5e57UWns9RDNfc9MMg4A== X-Received: by 2002:aca:5d82:: with SMTP id r124mr1229083oib.59.1618271621720; Mon, 12 Apr 2021 16:53:41 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id q10sm2451934ooo.34.2021.04.12.16.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 16:53:41 -0700 (PDT) Date: Mon, 12 Apr 2021 18:53:39 -0500 From: Bjorn Andersson To: Chunfeng Yun Cc: Vinod Koul , Andy Gross , Kishon Vijay Abraham I , Matthias Brugger , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] phy: qcom-qmp: remove redundant error of clock bulk Message-ID: <20210412235339.GF1538589@yoga> References: <1617937630-24832-1-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617937630-24832-1-git-send-email-chunfeng.yun@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_165342_874880_0049A7EC X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 08 Apr 22:07 CDT 2021, Chunfeng Yun wrote: > There is error log in clk_bulk_prepare/enable() > Reviewed-by: Bjorn Andersson > Signed-off-by: Chunfeng Yun > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 9cdebe7..f14b8be 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -3598,10 +3598,8 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) > } > > ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks); > - if (ret) { > - dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret); > + if (ret) > goto err_rst; > - } > > if (cfg->has_phy_dp_com_ctrl) { > qphy_setbits(dp_com, QPHY_V3_DP_COM_POWER_DOWN_CTRL, > @@ -4035,10 +4033,8 @@ static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev) > } > > ret = clk_bulk_prepare_enable(cfg->num_clks, qmp->clks); > - if (ret) { > - dev_err(qmp->dev, "failed to enable clks, err=%d\n", ret); > + if (ret) > return ret; > - } > > ret = clk_prepare_enable(qphy->pipe_clk); > if (ret) { > -- > 1.8.1.1.dirty > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel