From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD23BC433B4 for ; Tue, 13 Apr 2021 10:54:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CA6F61278 for ; Tue, 13 Apr 2021 10:54:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CA6F61278 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5MI3TWWI4faEg0uERcRFS9QdVjVdox2LhxKjsTacWjg=; b=ECxisAf4n1/FcgzvlirIYjvkF YEK4NAL2YFjYrSp91gkqwI+6lJ6c1AhTDCmaHbpLfyKD9Aho32g/SLAUMNiHlvX0k7sWHBveU7PKG 80AXIfzNaUZ1XP7Fv0ST7YzLjUMhluK7D0sACOi3jOy0J4QtmuEOHOHM0QIR6cM4zcEYG3xLN7qJm eQFvmY0feScQIWK2PP5P7jJPBWIHGAzgEGGTkhvn3bSdfRPkp+AWBvxF5ftDTgWlh/pcaNb9Jp8+/ qCK0qzqeAGwDfbn4L2V+GGDDq0XHFXHS3yS3Mkzjc9/H6yXwsn70ZnW5lL9oAL1I3cjJv3+hm6JZt /Oph1ic6g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWGeX-008v1E-99; Tue, 13 Apr 2021 10:52:17 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWGeF-008uxV-8o for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 10:52:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AyA21hCwDZr44tPRW26rnzyhYZ7wNBvoep8VeScz3VQ=; b=Wbw9oKlV2gEu+Ld3cfnAfnivrp 0hdfXw6scaT6Hm8njOlVZEBPXkCisuGeP7lBkfqhlcTinDhavrxQVBvffDRNwcmAuaDtkxXO5fLz1 EidyGKiniccQ+fy1zYLiNxTcYBnfeQZMdWOloJo1njGrYRFKAI2bj2HKSLD4Xnc4xZOicDC7MT8PF obJbeEmEKLcN81ZKtCnzz9F/slgUgt0WsxMY5yoM5WEP4q7IVI1jKygnIoJrY+bhhWgEQXhgtgCEc RFrWpJjdZBfEzs94rah2wiamNTdHzQ5hVH8d/sKE7M5aGkShFDSUUtYPuDFF/1vsGL3B1Es8v4y4e UJyZ06tg==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWGeC-006wIb-DT for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 10:51:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AyA21hCwDZr44tPRW26rnzyhYZ7wNBvoep8VeScz3VQ=; b=KW64bWZPv7mAcY0rtoikq5GWu ZwntBdejvJO8lY/s7jHil3J4Iy4whTvPkfqiHdkhaxvWQmu0wOkY7T8Dy+8HFVhqAqfq9lQWdSN40 aJqawPMaZ5lNIQWk0qOUkd0G7JtNvGrEMqpK0JXyNZahhQ1Z6/1i8amynpR5UvVxqP4Skk1g8YSNY y990OmrYXF4OsnCjiJKqAMYNfQTjOAF92Mar/e81f/PVqz7PKHqEpz0IXwqVrrITNDkxOk1WCCA61 GqYJiG4UnrsNAgNvdLXLaf5MdPkKoXUkS2tut7LAozWehylPoGFtKwKvw7vHbWCt5Hn1ebzCLWGS9 vGntaCmUA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52372) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lWGe2-0005Xz-Bj; Tue, 13 Apr 2021 11:51:46 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lWGe0-00088B-CB; Tue, 13 Apr 2021 11:51:44 +0100 Date: Tue, 13 Apr 2021 11:51:44 +0100 From: Russell King - ARM Linux admin To: Lucas Stach Cc: Oleksij Rempel , Shawn Guo , Sascha Hauer , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Philippe Schenker , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, David Jander , Fabio Estevam , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 0/7] remove different PHY fixups Message-ID: <20210413105144.GN1463@shell.armlinux.org.uk> References: <20210309112615.625-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_035156_478158_7C3EB956 X-CRM114-Status: GOOD ( 14.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 13, 2021 at 12:00:45PM +0200, Lucas Stach wrote: > I agree with the opinion that those PHY fixups introduce more harm than > good. Essentially they are pushing board specific configuration values > into the PHY, without any checks that the fixup is even running on the > specific board it was targeted at. Yes and no. The problem is, that's an easy statement to make when one doesn't understand what they're all doing. Some are "board specific" in that the normal setup for e.g. iMX6 would be to enable clock output from the AR8035 PHY and feed that into the iMX6 - as far as I'm aware, that's the only working configuration for that SoC and PHY. However, it's also true that this fixup should not be applied unconditionally. Then there's SmartEEE - it has been found that the PHY defaults for this lead to link drops independent of the board and SoC that it is connected to. It seems that the PHY is essentially broken - it powers up with SmartEEE enabled, and when connected to another SmartEEE supporting device, it seems guaranteed that it will result in link drops in its default configuration. Freescale's approach has apparently been to unconditionally disable SmartEEE for all their platforms because of this. With a bit of research however (as has been done by Jon and myself) we've found that increasing the Tw parameter for 1G connections results in a much more stable link. So, just saying that these are bad without actually understanding what they are doing is _also_ bad. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel