From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B35A0C433ED for ; Tue, 13 Apr 2021 16:31:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3836261369 for ; Tue, 13 Apr 2021 16:31:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3836261369 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gXXc6x0XnDrJajeSB3GhrI/LSnLFztdcYn7vphNa0T8=; b=eJqQJiF1/jUhfsEFHjEgv3ezd vMp9IOw2jcYT5Cu6FapWAglmRSCA1xMswAkbviW4KfgB/pTYS2wfBZ3yYVjXNbs3ZgjPHGTUdFoCs 9Kse7bDOCXMWNb+ecUFGUHrsFr50s2pZjRXaJM/3htZB2neVOmOJOW9OlLr1PMFQrpDuTjACui5k8 ITrUam8AN4CZiBvvmQsOCIZyFievcSbaE1JWnnPHf1cdWtQyxAJanVwkaN5P6bBev3pE0rddq6aak FSMktxKFgfY3L/qWkHex7zzTWL4B5O3coE3/WWJpjh67jY47Aht/lRsBeH71ADUk4ApA9M4dM2y/H zGYicipfA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWLse-009nHq-Mr; Tue, 13 Apr 2021 16:27:21 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWLoV-009mSj-W1 for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 16:22:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nIl7E1TX/AmjEPOYNmcXuzmbZMqP3dlvzU0KBMbKOp8=; b=uTkC+ZK4hoBaqjv3Hv7Ny3aNJI 7iwq8WS8yweNsGavEKqRPzQ6t6jcRhwWZstcPZKdt4/tYWp5gY9ZHfdPVu6IpCHrc9I0Pygq9sDP5 w4qVXaZfBhQgkdzmX55kZOaqFnM7EI3VoV1zRy2lsGMwE0YtAYKHtBHe0gxOStu6HFKhL/Bq2t3CR gd2DtRZfTXA7dXKp+Yj4Oq2G6rag2h0IT13PQztBJm/ipf6n0LAYcvBDmzTB4FZh9yoV5c/T/hQRF wAnccunSo5a9enDLBQqcMmK/HgaXGvXSSUrgVCMVHAKrq0cYm5lhDUyQPk8HEmcWUpCH1+rJ+jM0L HhcEvTdA==; Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWLoT-007Azt-70 for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 16:22:54 +0000 Received: by mail-pj1-x102b.google.com with SMTP id nm3-20020a17090b19c3b029014e1bbf6c60so5076422pjb.4 for ; Tue, 13 Apr 2021 09:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nIl7E1TX/AmjEPOYNmcXuzmbZMqP3dlvzU0KBMbKOp8=; b=nSzO0TfsAWG7iNgIdwtsAmUq/KQC/DsxJOS3lEsyXoGzuDRa+1Twzq2OGvh0ORC4Pf lThDb65mpeKuUxaBA4rV0iOYbKPc02HnnHV0wpbswaeTQ0pnXGo+uqvE8PnfjFCxVqK5 zLhT5B7Zf9WHyhiCFme93bh0kILdQQqsJb8x5itcawnECE89Kd7mviwZzJc22hLAkR1V i/AKIiAQDqUObtsRVLLVmYDdyG1F3M3wNmfkJzRfmzwsPwUUSYnDRwDbWn9fRYrTg45x toR2J7tbEiH8McjqjvAYoBVy+yeD8iF71ZVjjXxRklO/Us5B1FiceybdOYAAo6ql26yC Ma0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nIl7E1TX/AmjEPOYNmcXuzmbZMqP3dlvzU0KBMbKOp8=; b=eCnfjKfY80ytv0qhOI8YPcUuD/BlVP3vQKLKOu2A8k+95+IZQfa4vkWjW415czzcA+ 2HOnxCiO3SQoYTfJnWcHXU3uFR9SpO4bHXf9RvtPsLOWQMwQ26wDlH+VuuhF864HzdH6 0ZTscNLahslE9xzIXOl5joWSfw/FCAevTmOuQi5c61cXHPLleTWMFUTvatC187iWzlVA KrMRIR92QpWiKOUrnSQStj58mlwaw6QisUwapsoVlN4RICWlNobLgYkpi90WI0/ee8AO /ABHKWEQdkRkf5B/VGpsolMpgqCnbBqHvo2K67JK2cIusGpG6LFEq2O77otfvCzwKkcw rjOQ== X-Gm-Message-State: AOAM532cK0cVarViDDXSn3Hw1REE+l5hX7vyviri7yLThSwlHAZqLH+V Vm8wYl43XhOh6/CG55s6VFWmTg== X-Google-Smtp-Source: ABdhPJxlb6v8B6i2jVK3dUKFBjpwHKXt/PKepGp1gb73a7/jwKnFGhz6KNw7qGNer2xolloWLTPHJw== X-Received: by 2002:a17:90a:d3c6:: with SMTP id d6mr838920pjw.25.1618330972307; Tue, 13 Apr 2021 09:22:52 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id k1sm12329200pff.160.2021.04.13.09.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 09:22:51 -0700 (PDT) Date: Tue, 13 Apr 2021 10:22:49 -0600 From: Mathieu Poirier To: Wei Yongjun Cc: Anshuman Khandual , Suzuki K Poulose , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next v2] coresight: trbe: Fix return value check in arm_trbe_register_coresight_cpu() Message-ID: <20210413162249.GA690529@xps15> References: <20210409094901.1903622-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210409094901.1903622-1-weiyongjun1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_092253_276242_DADD513A X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 09, 2021 at 09:49:01AM +0000, Wei Yongjun wrote: > In case of error, the function devm_kasprintf() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > v1 -> v2: remove fixes tag. > --- > drivers/hwtracing/coresight/coresight-trbe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I have picked up both patches. Thanks, Mathieu > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index 5ce239875c98..176868496879 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -871,7 +871,7 @@ static void arm_trbe_register_coresight_cpu(struct trbe_drvdata *drvdata, int cp > > dev = &cpudata->drvdata->pdev->dev; > desc.name = devm_kasprintf(dev, GFP_KERNEL, "trbe%d", cpu); > - if (IS_ERR(desc.name)) > + if (!desc.name) > goto cpu_clear; > > desc.type = CORESIGHT_DEV_TYPE_SINK; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel