From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5379C433B4 for ; Tue, 13 Apr 2021 17:31:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3ED4E611CC for ; Tue, 13 Apr 2021 17:31:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3ED4E611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sXLsSoBWxnKvJ95rRzVzHX8VTNFCnx/i54PjRGrrVQk=; b=kLB46IAqoPwe1lDAqrJM500iq kexogxAMLTobTVnjWn0B7YDBd1SPzKa750oHuvcYoYkgzuxVvpi/sknUC8FOb/ScZPodApXvKfSOP xeMulmv3LpOOdZwWJpszD/8VmeadpkBoAyr9kDbW4YuZCtKQNqhaW9/TQ/SYRu0RsfNbvrOG34m42 ZcKv6wTlpo5bvhPsNIjET+sHKXjOKVsm2X58dJfo7jzyA0Oib02qIGsCX0abJ3rUJN70PNycXWVRS /UQDyFx1bbrUJRhKf2P3hoTq0GdM+czcURkA+iwJjuTrjs7XgD+C5znxxxARJj9PEb7Q4e+k5ILdx jy7lYnTbQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWMqA-009xou-48; Tue, 13 Apr 2021 17:28:42 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWMpr-009xlb-JP for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 17:28:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=v2QhzyojWbvybLlPtewmMNO5cATZp5zhGPpcdHGJXGg=; b=OjH/S9vD1a/y2y/Z33PJHDXRC0 KWbIIQ3cQETbmxUv/PZk++lKupEOYKTRxCujnqW+fWeoNQpej2/4eyFIMY7r24Oquf0C+Rx7zMHgi D1UFg+XBAO4uQQV9JyJJ9Bx1MbW/sGjVPz1ihHFuiIjnl2RMQlWyKMFBc5PHsZxqL16wj7TP7wMof g67zvmYDrdQw2BkEmBzQthvHgBzYhE1SiURwfuHbuvOy6fx0SHWVE97BALAUPzSsgC34lQavfC6+2 pGZP4uwvmre8nHTb7+suTGDz5Sn5MOmgTYCmpdt7OtFmLLE2YpPVdpFfqa7kkQtntPQHLg1D3h95R wSwF/McQ==; Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWMpp-007Dgi-09 for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 17:28:22 +0000 Received: by mail-pj1-x1035.google.com with SMTP id z22-20020a17090a0156b029014d4056663fso9383474pje.0 for ; Tue, 13 Apr 2021 10:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v2QhzyojWbvybLlPtewmMNO5cATZp5zhGPpcdHGJXGg=; b=BKlDaTeHzuJv+GEQuFg1n4srYnuQrdQZmp5Fdc4/vh9SPNKr6d0mCK8+K/n363EDR4 GfiqaR+iULjCzNK1G+mIwSzUbnujjFaVCnL3PWPY4UUGcBLL3+fKpxppIhqT1at8qII4 w86hiSsfwaiVoV/14NHwhE12RAmg0vGLJ8elj2dzlcR9gEv4hz7+j6fjHHVdxKU3rX98 Z6n7pCAC3gSgO7s66c1I/UoIwNzsSQrOAXXHn/YAnqn2k9ZrrMOkWObGYRTiA0CDDtbu FGoXs223kiZ7/iv1MQsr3DT+S0tUPYp2i3iOJ7+RUATTJsDh72ct0zYnPMKZGd9rcfuR QAKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v2QhzyojWbvybLlPtewmMNO5cATZp5zhGPpcdHGJXGg=; b=G7YTSwl/MEM5Ckf911b4K1y9lYfvi8qmKJQroTWO5fjrHzjEcF9sCn9uy6LGfSZ/tK uEuGkms+3n22axr3BJmJqAkSUbL260QYH/KDBr/kmWUvgovVD5KQFqMd1jvjbCY1O3KN //JfjE4Er5PWOsYaaqS9X3DZCoO9ZQXV8ogtpHkf8YuPMkIuLWs0JOf8HTtuV+gi3bcS 5lv/+ak40iefB0hT1/+2I3B4F/CymCT58sFZPGiCl0oZzMH/4p56EKKucT2uKoAy/MRa KkhENyDEKWwsia3sfZR/DNV08nTpdf5+dg+rHLmuT6Q7JXt1jHV6n5pEqcDFIvxYU5Zo fT6g== X-Gm-Message-State: AOAM533uNmt+JmKw9Svck8qu9QZIVYM98DZGwtMPTu/XydS5H0ljAve+ bBThyqSNhz2kQbJz4aqYWsWqAQ== X-Google-Smtp-Source: ABdhPJwTxPoyVSCF3F3SSBLBa01eeTFoMvtF4Ia5XzqeZQ/iVhPz30mD+ZynMqgzzxKnZC6z1Ry5wA== X-Received: by 2002:a17:90a:5217:: with SMTP id v23mr1092282pjh.161.1618334900010; Tue, 13 Apr 2021 10:28:20 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id w1sm15075490pgh.26.2021.04.13.10.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 10:28:19 -0700 (PDT) Date: Tue, 13 Apr 2021 11:28:17 -0600 From: Mathieu Poirier To: peng.fan@oss.nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V3 4/8] remoteproc: imx_rproc: make clk optional Message-ID: <20210413172817.GB750651@xps15> References: <1617846898-13662-1-git-send-email-peng.fan@oss.nxp.com> <1617846898-13662-5-git-send-email-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617846898-13662-5-git-send-email-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_102821_101067_0ADCE302 X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 08, 2021 at 09:54:54AM +0800, peng.fan@oss.nxp.com wrote: > From: Peng Fan > > To i.MX7ULP, M4 is the master to control everything, so it not need > clk from A7. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index d6338872c6db..ca17f520d904 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -635,7 +635,7 @@ static int imx_rproc_probe(struct platform_device *pdev) > if (ret) > goto err_put_mbox; > > - priv->clk = devm_clk_get(dev, NULL); > + priv->clk = devm_clk_get_optional(dev, NULL); Overnight the clock becomes optional for all remote processors? Why not call devm_clk_get() or devm_clk_get_optional() based on the remote processor type in a new function called imx_rproc_clk_get()? > if (IS_ERR(priv->clk)) { > dev_err(dev, "Failed to get clock\n"); > ret = PTR_ERR(priv->clk); > -- > 2.30.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel