From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A04C433ED for ; Wed, 14 Apr 2021 07:58:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E4DD601FE for ; Wed, 14 Apr 2021 07:58:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E4DD601FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QIGiI/PQYDmomK2zj1iOuAEGjMQ5nGSjvADz6hXNxQM=; b=UomFKTxamz+EArXGxUYossBr0 J/rKzNv4cGB60TEv4Iy+jdtxHeKPtimJnjHqG3GJbjp/9hs5YCcBSRDGQmrrTGhdir4cB02wtMDb2 f70LwIAHXYL3L0xkf8mdCz7VNk8hl8dBSqoWSS9/baSMbHT0RMj2/XYB53E1AJTNoIfjNyTplsj/t eqXxL+ny4Bbqs68YcoSOWJhGJY5xo4flMuhj7eHAw5l1sWvDaKiLADNLe9NJA6hpGAIbL/jOFHtdS czc6YfjZhlHpX3SMlizjGGGrVSW4uLBQLgcm5TvazR6yHkkF9vVPKfq3x6oBqqHr21zmzvlnyndne ZedcE3+RA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWaOU-00BuIR-L1; Wed, 14 Apr 2021 07:57:02 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWaON-00BuHz-9U for linux-arm-kernel@desiato.infradead.org; Wed, 14 Apr 2021 07:56:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZlI+ifK8nDRxlFjrAvKHl93m4FsTVNazVsbtuHBYRXo=; b=lTIT7FpJpqI1ck4BArpY0RQfok /hU5zNAPkUTMXZGinHa43rr4XQCv3bXbyo1l0OIMlbOuGV3OJy9ps8KLiBgiJvzHkMBA95OSrYTXQ cfn6RCzA8udgbSWZsmtGvXAIB9+EuhqboPd3F6hOZ2byssZh961fMghO+wj3MA3dp8t+FLkljM1p3 vXkNX/zAiXXlFFFKherSZk2WV0jd1oioTrebW1C92JtpeWKQirLo3kAazaoAXsbrXredsxQs2P/Y4 6M3rtB8DuXSbFxFmkGm68lk4vYAaHYB0xpTc04zl247OfLMrIxI2u4TYeDDcsPh+0Ae58VNLX3DPA kxoHZzWA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWaOK-007aWW-Oa for linux-arm-kernel@lists.infradead.org; Wed, 14 Apr 2021 07:56:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 84C7761168; Wed, 14 Apr 2021 07:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618387012; bh=ZlI+ifK8nDRxlFjrAvKHl93m4FsTVNazVsbtuHBYRXo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lz2DuH2A056JAvCSz/PJca6NQ2CL9S9KSqHp/xBPWKhuA7DeuCgzpQcGUYup48U8e j3dTzNKBwPsm+nzEBQZjLhDiYeIrFuKF2MTg9aQzSbZqmDjXVu2Fud3h53VWEur/G3 QvQn7L+7q0eM8qC+ptHCXbvvp0pN/VAhrLefcHynu/WEAQYd4TdMA5ILgUi7EjIlMx VSCQXhsiudBVMnN0ac7kbAVuXfpDJ9KorWjdhZHZpN4Nbp+sOEqNrzI1GEKBhVmx5J tleBlmj4w1USQOaxatsY90Zcv/9GJAdopiLqjJVzCcdh9ullnBQcmLBfR9xKxqFGEv le2WXaUT4XnFA== Date: Wed, 14 Apr 2021 09:56:49 +0200 From: Wolfram Sang To: Ye Weihua Cc: aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yangjihong1@huawei.com, zhangjinhao2@huawei.com Subject: Re: [PATCH -next] i2c: imx-lpi2c: fix PM reference leak in lpi2c_imx_master_enable() Message-ID: <20210414075649.GC2180@ninjato> References: <20210408111930.203574-1-yeweihua4@huawei.com> MIME-Version: 1.0 In-Reply-To: <20210408111930.203574-1-yeweihua4@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_005652_853888_D8389132 X-CRM114-Status: UNSURE ( 9.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4462634292533630595==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4462634292533630595== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2JFBq9zoW8cOFH7v" Content-Disposition: inline --2JFBq9zoW8cOFH7v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 08, 2021 at 07:19:30PM +0800, Ye Weihua wrote: > The PM reference count is not expected to be incremented on return in > ipi2c_imx_master_enable(). >=20 > However, pm_runtime_get_sync() will increment the PM reference count > even on failure. forgetting to put the reference again will result in > a leak. >=20 > Replace it with pm_runtime_resume_and_get() to keep the usage counter > balanced. >=20 > Reported-by: Hulk Robot > Signed-off-by: Ye Weihua Thanks, yet I applied this series now: http://patchwork.ozlabs.org/project/linux-i2c/list/?series=3D217733&state= =3D* --2JFBq9zoW8cOFH7v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmB2oEEACgkQFA3kzBSg KbaD2w//c6tPpaUb7wtiOq6bOZe+m2ZS8H8jOVPC/nEP7Ka9kHUg9fRAbiR1K1rg 21TdJ9N4v9wlCpNwz11IEEhkP2Q+jrY27CzcT8M2v19vaWJH1O1tySeZa7bncvjY fKrw3839HDPHIq6pAErbRDwiaj8UGw5/nsLQwF3NEI0OTkcuOixk2f5Ff9J77NHd NJh+T69QLGQNsXPZJNY7EKocqEGOYQTnCLwnNymAJk31+J8YUYmSgGZJaM5kK4cI ThTEGeI+7mroX9476D5qQMUgxUHUmhq0xb7GrzuWixXWjLJPhR5cQaYekvZm9K2/ g9lzkrktoFEg0sImkVsGGn3XSEB9EFfbSdLmB551Qbm962Ppix5uztp6B0Qk021s 0yqWcOA+t7zuoL0Gezorof+CNjghM1EMt35+He63oU2Glzpe13+yQ8wKj+mfql7J pXwOUFK+EgjosnyoKkE1RTxnxmd9ZRX0an55d1EMjSLYrA+u/2Thcqh939RH6UFa acoVQMR3fhawo6XFqQRyZE/fPczsrmMhhZ4stR/v+vm5jqY5BgI4xQ1amCiVl3qr UIdetwb+DpFr2KwlSlzS628s10WYfT6c0u2tVsA8oswvJr1XsjpLn56LdQT05kx0 vfHuQLFytVpGfUMEAxOuWzOEpgqOeZVlJKN1Naa3rwLYIi/Qd+k= =lutH -----END PGP SIGNATURE----- --2JFBq9zoW8cOFH7v-- --===============4462634292533630595== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4462634292533630595==--