From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB12C43460 for ; Wed, 14 Apr 2021 08:06:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DC5461222 for ; Wed, 14 Apr 2021 08:06:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DC5461222 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DohOJqn2J4PLEWE0u8xp+uwTVn2JSkqrIrZISkxMMOs=; b=eZl+skvle2pCnVWj1OcmZ4j6m y+WUYtiHda2Y8jEx+aaEbQWPdst9fKUlWpeJ4/qbaWduwPeb2XFH9eidUIl0FFep980jbloiUnIDS nR8yRUt7gE5aSCy7VQKb0HjBnNmCf+aJukVP6J6jFH7+1rJAZ1TTXsypa4UHjnEMB7ZWwLowNqQhz Mifc363NqHcMBgoi7oQ6VOjsj4v+jbHEC6ZWIT0jD5r8b9G7afTwSNVHG8NUed2/VgCjNrgE80YCL WNYceQZyCB3Lix0j+9ZoQFk4ZZ+it+xHP7wd5sMFRvKLdL7mWTIUTWP0F+OjCQ8Iqg8R14Lwl/8BV 0Iy/OfLOw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWaVd-00BvLE-QM; Wed, 14 Apr 2021 08:04:25 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWaVW-00BvJy-24 for linux-arm-kernel@desiato.infradead.org; Wed, 14 Apr 2021 08:04:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DDgBP6n64IMKsB2L7UnLvVq+twex8WXXP9cr0hhkwDM=; b=xKV2/EAXVM7qeeBPyeTECt0WwX 4/4yBIjvRHV7IHdBmI0TXAxo7R10rjrDghgftyr+kgBRlqQ4Wh4ku/CyP/h8UKp1iXZn6fKUXj9ZC nc0a8QTGLp9nkS6C40abiXY6iaRr14lTlEnJuyQlOMb2S9yZYHf/iv5IK4agM/so3QozwYEodU8xI /r8eGSgz7rX9cYbzLAeWWULHdTfNjIc28op/ObY9iLQGDwA4JxCfxhovfsFGrHKZRuQGgqTZjb3x3 EOD1faVwlaMslzTmiWWBmJZrAX011SnviUtpKVTsWySbQjqiSz3KGRf113maUT3Uu3liXEXkQ6SjG 24rj+6SQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWaVT-007anx-Fl for linux-arm-kernel@lists.infradead.org; Wed, 14 Apr 2021 08:04:16 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6BDEB61179; Wed, 14 Apr 2021 08:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618387455; bh=TG4nP5Bkld2PjnN/8JUb328aNVrDFABId/IvxQvT2g8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mb/UywYWL3DXr8vyJn1hemUOkNZ2cNavGmuapnJg4Vb8asObE5JKsmBEAGzbhmjKn aJ5nKuoGTkZ9Qly4rZ2ot3Kfji6ki6Juj7UJ+XJrPYD1ZxyA+8fEHsRvcSnx+f3/gl IZqWiue02pI0OMrzf3WkXg5E3BXpOWlVQotF653aLHbXGC9fPd5W+dyZ1rJbu26x7Y gAUjzZ0g/sXFqWWRjxv7SzAN6woXfQr0fOResW8p0AMLL/2MZh+kp1FswFEfLX0XIe 8SIf/KngGnO60ngMluBTv6PKaG9JIj+eEq2fA5ZNTZFoI86z6MsoswEl57FMjZfL/j eng/82NUELumA== Date: Wed, 14 Apr 2021 10:04:12 +0200 From: Wolfram Sang To: Ye Weihua Cc: linux@rempel-privat.de, kernel@pengutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yangjihong1@huawei.com, zhangjinhao2@huawei.com Subject: Re: [PATCH -next] i2c: imx: Fix PM reference leak in i2c_imx_reg_slave() Message-ID: <20210414080412.GI2180@ninjato> References: <20210408110638.200761-1-yeweihua4@huawei.com> MIME-Version: 1.0 In-Reply-To: <20210408110638.200761-1-yeweihua4@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_010415_596724_F9CC51DC X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1607656648920051671==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1607656648920051671== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="++alDQ2ROsODg1x+" Content-Disposition: inline --++alDQ2ROsODg1x+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 08, 2021 at 07:06:38PM +0800, Ye Weihua wrote: > The PM reference count is not expected to be incremented on return in > these functions. >=20 > However, pm_runtime_get_sync() will increment the PM reference count > even on failure. forgetting to put the reference again will result in > a leak. >=20 > Replace it with pm_runtime_resume_and_get() to keep the usage counter > balanced. >=20 > Reported-by: Hulk Robot > Signed-off-by: Ye Weihua After rebasing, only one hunk was left: > @@ -801,7 +801,7 @@ static int i2c_imx_reg_slave(struct i2c_client *clien= t) > i2c_imx->last_slave_event =3D I2C_SLAVE_STOP; > =20 > /* Resume */ > - ret =3D pm_runtime_get_sync(i2c_imx->adapter.dev.parent); > + ret =3D pm_runtime_resume_and_get(i2c_imx->adapter.dev.parent); > if (ret < 0) { > dev_err(&i2c_imx->adapter.dev, "failed to resume i2c controller"); > return ret; I applied this to for-next, thanks! --++alDQ2ROsODg1x+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmB2ofwACgkQFA3kzBSg Kba2ABAAqCYKxzJHnfOMkaWfNU6FGvFtUmEybjPv4Bnw3Vq7FXUQJCLmSCVXM57B jMgCqk8lQX9fRRSKz7ux8Gq1XJcl3f+66EY2RRB2TzWR18qqa0aUwCxxajoo8qPp u6rLf4KbErJtAYoma0+W54AYdgWoy6gxnw82yC0xMv39MK8XxlzEbRkVxIovbzxD /m/XSUtjsDybPN9l7aoESsPXzASXikhH0yNOmffsZCybZ6Xk6V47QBdJz2uHqg0O y/8V9X1+vE0lqn7mEM+9ShghkZCXUZFifmjIGGoO4SmsCa0mKk6Iq53qL0+OHlKi vrBQMb8R+t7a2nZnijSLsGHcNx2Kx9HMmn3HY57g4Schlnegin0LRlinMQd6qhuQ NPkqeeaXdogZxqTXep5udxPht8SjhSex9/L2sAJafrbaNI3FCusQGYu5aFgELJ2p sQa6BLXctvkSHib8Nfkec7TaX/4mk/vheKpQDpMpYoQ85SgHDd2QCC7ixw4h/ZK9 h2lBp/2vTSUmh6HlUSon+hwulSQdv/nVOK9NL51JaojQ6BP/EJbzMEqPr+ky2O2y n2C2iv78fMd6SxNCX+5UouqyR0zrk7DlhJr78MkLuvEYdQVwd8ySRlTJH0S+/N3p YYZhwD3JCurWpOBtR+mekZXfhpJkiQvcG5Qt7oaMe2SsN0wRrMc= =jEO4 -----END PGP SIGNATURE----- --++alDQ2ROsODg1x+-- --===============1607656648920051671== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1607656648920051671==--