From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19229C433ED for ; Wed, 14 Apr 2021 19:49:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5F8A61177 for ; Wed, 14 Apr 2021 19:49:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5F8A61177 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=nG2ikX/U5UKihGKoCvMQA76tOfhVOPi2mqP8b3RRVzU=; b=g3wcyELqZu0va4MribuzE1R+6 0L3WHc0EVaRlEYwbWo1P6851WYv6MWRm99lyeb0skxOaKhMn6gU1DxZ1iWdaSlaJ3b1KOWqs+RN01 XGzrPrXrQVOq/AptGNr56lmGkNRkNion50VU3aeGT+r0fRR3ZImBxvvrdmEUL2t/I/qUJm85xU4uV +60D6aoB36SAdf85RMrTCDK++gDeXYAeB96hRxP0R0IAm4lfA0RrAUGK747ak9wCm7oWM6WPXiX80 /n7iRGFGLBQVbVuK6HMnCnmSSqM7HyIhhfaCUofuGVfHgsSTvjym/P/FVZOfo8/ZZ/8aeQOs79wXx eczQuXh6g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWlTe-00DcRe-JF; Wed, 14 Apr 2021 19:47:07 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWlTW-00DcRH-Tj for linux-arm-kernel@desiato.infradead.org; Wed, 14 Apr 2021 19:47:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:References; bh=efTgPLFQhshiHP8uH97Por0VbEciWM9cAcegQV5vhNM=; b=etwiHhFSgC/7P18NcHGjFVcZka LdXMoPqw79MGTAuYasKMTmulnuRoft+N4gfgJs6BFcnz6diwYFjZYMjAxLHkxV0HsW5yKSRckSEff Gq1G6xBG22yE8QmtW/DMH/WqvBjPdcy4oDa2C9kPF8QXwZrZy/aBCDs6kozCceLT4J3t6iv9Dp0OU oEPbjkBmHDhLM+w86Rs1ynoOQgwGrLXcQCdE1WvxdcBTC7gIJIAMIlHZsjMl23vJtX+L6El3yJqYI qz9Q/JLwf7qjd3lL27UtLNQssZDy07GIXnIOA7F6wwYb1IO9G/D8C5yKMtaoLNj6a3ojdRzB8MaZZ nStIOl2Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWlTU-0084BM-Hs for linux-arm-kernel@lists.infradead.org; Wed, 14 Apr 2021 19:46:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BAE4C61166; Wed, 14 Apr 2021 19:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618429616; bh=KuVnof+r6hRvfkV5hg/I5cwh0JERg3t7/JNTMJrdSTU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=p2YWWgqeuaUlwXSjE+9RjYo6AkX/3oCNfYq3ioiwSV7R0sxpHPIt20Ga7XSFNMCSh XgegTcjDDAIzr5H7h/M1HtT+jjBFAwroDtoyKn4PGWjy8kV0tFVjRjPGgUYJp8tvM1 YCJJsT5diCCVcVk5CUsFN/4OWtj76Vfe/a3arc1qn4zv/V++A95RozAlLIwpCC6Wlm pKqrc5jVG6kJex/vpwUH+MhYKBflGCTm3rHWBznlJ9Gqn5tOGYNh8CdhG4zIYgD27J tlNSvXrqXAXZ/x7klLcCJ346XrpXZS6RYCT8/KMy0RG22jqIYtR58mL6z2wKyGCTB/ R/Pl+wkbw6v3w== Date: Wed, 14 Apr 2021 14:46:54 -0500 From: Bjorn Helgaas To: Kunihiko Hayashi Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jassi Brar , Masami Hiramatsu Subject: Re: [PATCH v10 3/3] PCI: uniphier: Add misc interrupt handler to invoke PME and AER Message-ID: <20210414194654.GA2526782@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1617985338-19648-4-git-send-email-hayashi.kunihiko@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210414_124656_639144_A3ECC2B1 X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 10, 2021 at 01:22:18AM +0900, Kunihiko Hayashi wrote: > This patch adds misc interrupt handler to detect and invoke PME/AER event. > > In UniPhier PCIe controller, PME/AER signals are assigned to the same > signal as MSI by the internal logic. These signals should be detected by > the internal register, however, DWC MSI handler can't handle these signals. > > DWC MSI handler calls .msi_host_isr() callback function, that detects > PME/AER signals using the internal register and invokes the interrupt > with PME/AER vIRQ numbers. > > These vIRQ numbers is obtained by uniphier_pcie_port_get_irq() function, > that finds the device that matches PME/AER from the devices associated > with Root Port, and returns its vIRQ number. Why do you use the term "vIRQ"? What exactly is a vIRQ? It seems no different than the simple "irq" as stored in pci_dev.irq or pcie_device.irq and passed to generic_handle_irq(). "virq" is also used in the patch, so if you change one, please change the other as well. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel