From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A26CEC433B4 for ; Thu, 15 Apr 2021 15:23:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31B1361152 for ; Thu, 15 Apr 2021 15:23:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31B1361152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TmK3pNDNWtRA9K3R1C+LU57pNPMUjsi213YHtRIO+GU=; b=WEFJH2gvv/ainxzMqs6reO1O2 Z4s8UQ0HKzG4h88QpeXsYf4+U7YWJZSkESl2bLJmyYGNnEEiJDRRz2CLZBH4+UhMSmloJ5H56F3v2 RJZ3QOYeSfVaw2C0gfXRAPsLx6IJLn574mjGTe09h6eyrR6ZaLsbKjGnnKKpO0qs6fukbQGsgvx3S rVS3gMPcSUUvq0YcoIDkVV6JoFiz4QJp992cKCErTtMSqCq2dxYP1Kmrvm7iFp4mLh/k+6OYIZkDe wcXhv0nwTsNG8AuxnVvakShx7tHOzKiv3DQOrhHW7Ash0GjjIoz0dK6ctUqZQnRQb7IC19Vj/tz9t kb5tIvIzg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX3oH-00GacO-9W; Thu, 15 Apr 2021 15:21:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX3o8-00GaZe-KX for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 15:21:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CbALUUk2SxXgau/iYTNOoDs9Qhfc0Z+i8E9uMnpeEUU=; b=E4ixg+/v/QOc4/oPj4HaxDs/2O PORpfomDGhh36QO6E0N3eOa17jcJIVwxX37qTupzvsVacFv01+rjIjh8nvCj1qeP6q0pO6kKpMRnH 5Qir+3A2EiWeaeGZ0MqwoT7nLvld8J4WILqrTtBRNm5ND69KJYM8VwT3akrG89XuNpnXR3PVjz+Mx wEabAl5xBk3nCQ8eVyN15qN+hlPRCVXfLsnwjSEcNuBS4ZUFsobbU1QyEQUX0lwCA8x+y9lOQcGQg TsGnErN25oASLMuZ3GSALktbTjDt1L8hs+6IZs4drtkYthOGpHf12/Fr0oLG9bQj8a3HAJSZjIz/c MNVW8RQg==; Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX3o5-008hd3-Pz for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 15:21:27 +0000 Received: by mail-pl1-x636.google.com with SMTP id d8so12239213plh.11 for ; Thu, 15 Apr 2021 08:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CbALUUk2SxXgau/iYTNOoDs9Qhfc0Z+i8E9uMnpeEUU=; b=sktvUIX+DjdfE0jemReuNriEYLHIsv3gV28Ii0dtgUrUjWxsOZoOec8MmMVjiKfmTZ OIWYrSHcAczXpx9yWGjBM5wqzBoIInKD4d0R1IS+KJkxYsI1D2nHtEcm6BxB46cWKnlR WbnSaRLQjZ6wVqrXYSZAp8JUuTxkMvoMVlT5XC6+7xDWuq9hzrzl0f+aT2UlNRqmQv8S SN5ODd4YO0S4r6LxTfLdsr43Rq5i/tc9IKD40X8kIijgn/MO1hBod8WgdMQtGusc/JlM zDoDFkMnCnWJpiJwsvOysvNrzGoK/uDLfDZPxtI7BmhQBDu5evxCJkgNUz1pmLyj/UQX 9H6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CbALUUk2SxXgau/iYTNOoDs9Qhfc0Z+i8E9uMnpeEUU=; b=LfdG76XYPyQzf0y9rrAVLmg8qpxs3LK2IQZOAbfwNaRmh1c/UiSZgRWjnKG6ftT0o2 Xqh3mxtHXVAILxoLWv+ulr5VqOGKVCZWzKZLrdgkthDiyKKRY4ncQFAwFaROlanQPWRG Y3MSAFRnLqyjoWhH6wDywrU7xIi/yUprHsDscwen5eivdgFPDDnK2sDjxru1XVTUCH1j mM5/5skZRTRyQV1+iKTFPK0FyzyIUrFJBD+Pr/pv4n2NMDnnRymtGUwMC057Refi/U05 9AblUbk91KjUnfdX4Cia7eXCdCr0uR6MbeAHgCPl1VWgkBRFJdpMxUeiHzzOmueYAWCa lp2Q== X-Gm-Message-State: AOAM531kKlW+fkPb/c9XanJkNBxOIiHUVVe4EZH9nsEST6qJHx7MFaKH UAXhCL3tdECcxIhNQxrGMBQ= X-Google-Smtp-Source: ABdhPJxSo2gXPLPT8jf7JLWOsxe4pFXobKGAGu1B2MIYZxSffE7+LoFjB/NLyOVLYFEMFOkjCGDkxw== X-Received: by 2002:a17:902:e74f:b029:ea:f2b5:1add with SMTP id p15-20020a170902e74fb02900eaf2b51addmr4422425plf.29.1618500084741; Thu, 15 Apr 2021 08:21:24 -0700 (PDT) Received: from syed ([2401:4900:2eec:4193:f802:b600:e94c:55c4]) by smtp.gmail.com with ESMTPSA id d3sm2976332pjw.35.2021.04.15.08.21.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Apr 2021 08:21:24 -0700 (PDT) Date: Thu, 15 Apr 2021 20:51:13 +0530 From: Syed Nayyar Waris To: William Breathitt Gray Cc: jic23@kernel.org, kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, david@lechnology.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de Subject: Re: [PATCH v10 20/33] counter: Rename counter_signal_value to counter_signal_level Message-ID: <20210415152113.GI8933@syed> References: <33a89af04c3dbba1c9d2f97927b7c2ffcd921af9.1616150619.git.vilhelm.gray@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <33a89af04c3dbba1c9d2f97927b7c2ffcd921af9.1616150619.git.vilhelm.gray@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_082125_870908_15F158FF X-CRM114-Status: GOOD ( 25.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 19, 2021 at 08:00:39PM +0900, William Breathitt Gray wrote: > Signal values will always be levels so let's be explicit it about it to > make the intent of the code clear. > > Cc: Syed Nayyar Waris > Cc: Oleksij Rempel > Cc: Kamel Bouhara > Reviewed-by: David Lechner > Signed-off-by: William Breathitt Gray > --- > drivers/counter/104-quad-8.c | 5 +++-- For the 104-quad-8 driver: Acked-by: Syed Nayyar Waris > drivers/counter/counter.c | 12 ++++++------ > drivers/counter/interrupt-cnt.c | 4 ++-- > drivers/counter/microchip-tcb-capture.c | 4 ++-- > include/linux/counter.h | 12 ++++++------ > 5 files changed, 19 insertions(+), 18 deletions(-) > > diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c > index 0409b1771fd9..fb0f021c0751 100644 > --- a/drivers/counter/104-quad-8.c > +++ b/drivers/counter/104-quad-8.c > @@ -97,7 +97,8 @@ struct quad8 { > #define QUAD8_CMR_QUADRATURE_X4 0x18 > > static int quad8_signal_read(struct counter_device *counter, > - struct counter_signal *signal, enum counter_signal_value *val) > + struct counter_signal *signal, > + enum counter_signal_level *level) > { > const struct quad8 *const priv = counter->priv; > unsigned int state; > @@ -109,7 +110,7 @@ static int quad8_signal_read(struct counter_device *counter, > state = inb(priv->base + QUAD8_REG_INDEX_INPUT_LEVELS) > & BIT(signal->id - 16); > > - *val = (state) ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; > + *level = (state) ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; > > return 0; > } > diff --git a/drivers/counter/counter.c b/drivers/counter/counter.c > index 6a683d086008..cb92673552b5 100644 > --- a/drivers/counter/counter.c > +++ b/drivers/counter/counter.c > @@ -289,9 +289,9 @@ struct counter_signal_unit { > struct counter_signal *signal; > }; > > -static const char *const counter_signal_value_str[] = { > - [COUNTER_SIGNAL_LOW] = "low", > - [COUNTER_SIGNAL_HIGH] = "high" > +static const char *const counter_signal_level_str[] = { > + [COUNTER_SIGNAL_LEVEL_LOW] = "low", > + [COUNTER_SIGNAL_LEVEL_HIGH] = "high" > }; > > static ssize_t counter_signal_show(struct device *dev, > @@ -302,13 +302,13 @@ static ssize_t counter_signal_show(struct device *dev, > const struct counter_signal_unit *const component = devattr->component; > struct counter_signal *const signal = component->signal; > int err; > - enum counter_signal_value val; > + enum counter_signal_level level; > > - err = counter->ops->signal_read(counter, signal, &val); > + err = counter->ops->signal_read(counter, signal, &level); > if (err) > return err; > > - return sprintf(buf, "%s\n", counter_signal_value_str[val]); > + return sprintf(buf, "%s\n", counter_signal_level_str[level]); > } > > struct counter_name_unit { > diff --git a/drivers/counter/interrupt-cnt.c b/drivers/counter/interrupt-cnt.c > index f27dea317965..cce579c1c6ae 100644 > --- a/drivers/counter/interrupt-cnt.c > +++ b/drivers/counter/interrupt-cnt.c > @@ -130,7 +130,7 @@ static int interrupt_cnt_function_get(struct counter_device *counter, > > static int interrupt_cnt_signal_read(struct counter_device *counter, > struct counter_signal *signal, > - enum counter_signal_value *val) > + enum counter_signal_level *level) > { > struct interrupt_cnt_priv *priv = counter->priv; > int ret; > @@ -142,7 +142,7 @@ static int interrupt_cnt_signal_read(struct counter_device *counter, > if (ret < 0) > return ret; > > - *val = ret ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; > + *level = ret ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; > > return 0; > } > diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c > index 0c9a61962911..6be3adf74114 100644 > --- a/drivers/counter/microchip-tcb-capture.c > +++ b/drivers/counter/microchip-tcb-capture.c > @@ -158,7 +158,7 @@ static int mchp_tc_count_function_set(struct counter_device *counter, > > static int mchp_tc_count_signal_read(struct counter_device *counter, > struct counter_signal *signal, > - enum counter_signal_value *val) > + enum counter_signal_level *lvl) > { > struct mchp_tc_data *const priv = counter->priv; > bool sigstatus; > @@ -171,7 +171,7 @@ static int mchp_tc_count_signal_read(struct counter_device *counter, > else > sigstatus = (sr & ATMEL_TC_MTIOA); > > - *val = sigstatus ? COUNTER_SIGNAL_HIGH : COUNTER_SIGNAL_LOW; > + *lvl = sigstatus ? COUNTER_SIGNAL_LEVEL_HIGH : COUNTER_SIGNAL_LEVEL_LOW; > > return 0; > } > diff --git a/include/linux/counter.h b/include/linux/counter.h > index 9dbd5df4cd34..79f5dcaf6ba0 100644 > --- a/include/linux/counter.h > +++ b/include/linux/counter.h > @@ -290,16 +290,16 @@ struct counter_device_state { > const struct attribute_group **groups; > }; > > -enum counter_signal_value { > - COUNTER_SIGNAL_LOW = 0, > - COUNTER_SIGNAL_HIGH > +enum counter_signal_level { > + COUNTER_SIGNAL_LEVEL_LOW, > + COUNTER_SIGNAL_LEVEL_HIGH, > }; > > /** > * struct counter_ops - Callbacks from driver > * @signal_read: optional read callback for Signal attribute. The read > - * value of the respective Signal should be passed back via > - * the val parameter. > + * level of the respective Signal should be passed back via > + * the level parameter. > * @count_read: optional read callback for Count attribute. The read > * value of the respective Count should be passed back via > * the val parameter. > @@ -324,7 +324,7 @@ enum counter_signal_value { > struct counter_ops { > int (*signal_read)(struct counter_device *counter, > struct counter_signal *signal, > - enum counter_signal_value *val); > + enum counter_signal_level *level); > int (*count_read)(struct counter_device *counter, > struct counter_count *count, unsigned long *val); > int (*count_write)(struct counter_device *counter, > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel