From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93AEEC433ED for ; Thu, 15 Apr 2021 21:19:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E87AD60E0C for ; Thu, 15 Apr 2021 21:19:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E87AD60E0C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AHxThzlvZWqXK5hApZcR6B22G6AYQTkM5JL7RjK5PWU=; b=VoW0fm835g2VhRlDAUHkKhXM7 sSQyH7DY+9huipLATLn2BsxXnb6IYBtGA1baj/qx6tqnluIigfiuK+btT6S1L+L85u9zBF55SA5b5 d8owhJZ2aBJDvfOelWHSwdGGEb7FQmkyUDb/RIbomNWHu0hf4sNPAYPBe8lFyM3BpwfPDLuZ8TZuP dFRajnQ2Y+NUM1vEn2Iz5+KewxUZsSxW9HPDgDt06wYbvGcKLlFfd2390ql/YK3JdtLr//DCajpjc vAqKbk1k8h8AKHrYkBmVx5laSOis4/2nNlqaSozVHVU9CX+eivRgUXDTWKkK9+GIOPvTa9ZKaRwnj r8fCVnuSg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX9Mo-00HNQP-Tz; Thu, 15 Apr 2021 21:17:40 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX9Mm-00HNPw-0Y for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 21:17:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fK2xO1LzXOeYiXzPsV7w3g3ABzLHTalsqqUFl8JwTMg=; b=Rq+IXbaPaM7yeMhQzyX7etH6fy /4X6MsKh5EMHMU/v61PGMULRbnCMDhYaPjx80C+C3y5rV6raky0xFS3vcJTPeJLFgBATWCKG9Bb7w +B/Pqu+y279nLByAwM2y23frSYq2jVHWX4jhAy6MuFQhcB0AdGCxknTV1wpcQwvha8lS6OXLU08pk NC0wVDA+6bb3KdIJAuo5I6QIb/1wvj9CIZTDldAs0IYr06LTewBYC0wIebtNvXqakG8phbWwpWLTd AOF0VSr4xxwWCJO6SnWozNEzWxWCGyxWCqooXnfHmoyN+SGHabNLnEJXt1Ebd3nJ8T/+nAosXFhT1 prvVZKrQ==; Received: from mail-oi1-f180.google.com ([209.85.167.180]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX9Mi-008tkn-VQ for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 21:17:34 +0000 Received: by mail-oi1-f180.google.com with SMTP id l131so20676861oih.0 for ; Thu, 15 Apr 2021 14:17:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fK2xO1LzXOeYiXzPsV7w3g3ABzLHTalsqqUFl8JwTMg=; b=Y60E3qa3ZhCOlZyIGYmzpPMkhN7B7QzMoTqYEyilw+ZgsYYDpS7lOzdQQktw19crj0 Dxdyvb/XLVO6sYPjZ8beiaUAndBnxtlDEWyTzjdyDT1J6TYotkiXnIStmr8wktWYLqxa FbJKZyYWZ34C04IhMvi2FTkE7L+36bm31kcC0i7C14ED2hs3r9BUY5L63OGeKg0cqswq kBdI/9s2jhsmE6hSO6bew7GrAjbO1kXsFbwFiNFRmi2kZttOg405zyUSUx6dwvgIYS7u GjKHSCtSLaJQYkBKqoQv5e/l5qMZp2pEACX7/rQ0uvlZYFoXuDopThpDY7CRxnF96BuX RAkg== X-Gm-Message-State: AOAM532euadgc76ztZT03chjm1bzpkDNqppArfo4z2m4ZX7VbWQVTN8v kZN9F8xRy2SMhateNUutZg== X-Google-Smtp-Source: ABdhPJwcvCwgfS/zWOl0KWJLgonXvdFuGCFAtbmngGV436lxMksPVRAXYNQIEzAqJjk1ZLE0+Ac9Lg== X-Received: by 2002:a05:6808:bd6:: with SMTP id o22mr3941544oik.129.1618521452315; Thu, 15 Apr 2021 14:17:32 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l204sm877587oia.11.2021.04.15.14.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Apr 2021 14:17:31 -0700 (PDT) Received: (nullmailer pid 1897885 invoked by uid 1000); Thu, 15 Apr 2021 21:17:31 -0000 Date: Thu, 15 Apr 2021 16:17:31 -0500 From: Rob Herring To: Nishanth Menon Cc: Jassi Brar , s-anna@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V2] dt-bindings: mailbox: ti, secure-proxy: Convert to yaml Message-ID: <20210415211731.GA1892348@robh.at.kernel.org> References: <20210413224535.30910-1-nm@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210413224535.30910-1-nm@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_141733_040089_1B132820 X-CRM114-Status: GOOD ( 31.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 13, 2021 at 05:45:35PM -0500, Nishanth Menon wrote: > Convert the ti,secure-proxy to yaml for better checks and documentation. > Differences being mostly in the examples: > - I've dropped the example usage of mailbox client, it is better done in > tisci node definition > - Switched reg usage for address-cells and size-cells 1 - aligned with > schema checks as well > - included header in example for buildable example > > While at this, lets make sure to support upto 100 rx threads even though > typically upto 1 threads is practically in use. > > NOTE: The following checkpatch warning is generated since we do include the header > in the example, but this is a false positive warning. > WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst > > Signed-off-by: Nishanth Menon > --- > Changes since V1: (Thanks Suman for some offline comments) > - Strengthened interrupt-names property to be on rails > - More documentation (we dont want an information loss between txt and > yaml) > - Added a max interrupts of 100, which is a rather conservative limit on > current devices, but who knows.. > - Commit message updates > - compatible is a simpler const. > - interrupt-names are required property - makes no sense in not knowing > which interrupts belong to which thread irqs. > > V1: https://lore.kernel.org/linux-arm-kernel/20210413171230.5872-1-nm@ti.com/ > > .../bindings/mailbox/ti,secure-proxy.txt | 50 ------------ > .../bindings/mailbox/ti,secure-proxy.yaml | 79 +++++++++++++++++++ > 2 files changed, 79 insertions(+), 50 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt > create mode 100644 Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt > deleted file mode 100644 > index 6c9c7daf0f5c..000000000000 > --- a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt > +++ /dev/null > @@ -1,50 +0,0 @@ > -Texas Instruments' Secure Proxy > -======================================== > - > -The Texas Instruments' secure proxy is a mailbox controller that has > -configurable queues selectable at SoC(System on Chip) integration. The > -Message manager is broken up into different address regions that are > -called "threads" or "proxies" - each instance is unidirectional and is > -instantiated at SoC integration level by system controller to indicate > -receive or transmit path. > - > -Message Manager Device Node: > -=========================== > -Required properties: > --------------------- > -- compatible: Shall be "ti,am654-secure-proxy" > -- reg-names target_data - Map the proxy data region > - rt - Map the realtime status region > - scfg - Map the configuration region > -- reg: Contains the register map per reg-names. > -- #mbox-cells Shall be 1 and shall refer to the transfer path > - called thread. > -- interrupt-names: Contains interrupt names matching the rx transfer path > - for a given SoC. Receive interrupts shall be of the > - format: "rx_". > -- interrupts: Contains the interrupt information corresponding to > - interrupt-names property. > - > -Example(AM654): > ------------- > - > - secure_proxy: mailbox@32c00000 { > - compatible = "ti,am654-secure-proxy"; > - #mbox-cells = <1>; > - reg-names = "target_data", "rt", "scfg"; > - reg = <0x0 0x32c00000 0x0 0x100000>, > - <0x0 0x32400000 0x0 0x100000>, > - <0x0 0x32800000 0x0 0x100000>; > - interrupt-names = "rx_011"; > - interrupts = ; > - }; > - > - dmsc: dmsc { > - [...] > - mbox-names = "rx", "tx"; > - # RX Thread ID is 11 > - # TX Thread ID is 13 > - mboxes= <&secure_proxy 11>, > - <&secure_proxy 13>; > - [...] > - }; > diff --git a/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml > new file mode 100644 > index 000000000000..08a4837fdfcc > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mailbox/ti,secure-proxy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments' Secure Proxy > + > +maintainers: > + - Nishanth Menon > + > +description: | > + The Texas Instruments' secure proxy is a mailbox controller that has > + configurable queues selectable at SoC(System on Chip) integration. The > + Message manager is broken up into different address regions that are > + called "threads" or "proxies" - each instance is unidirectional and is > + instantiated at SoC integration level by system controller to indicate > + receive or transmit path. > + > +properties: > + $nodename: > + pattern: "^mailbox@[0-9a-f]+$" > + > + compatible: > + const: ti,am654-secure-proxy > + > + "#mbox-cells": > + const: 1 > + description: > + Contains the secure proxy thread ID used for the specific transfer path. > + > + reg-names: > + items: > + - const: target_data > + - const: rt > + - const: scfg > + > + reg: > + minItems: 3 > + > + interrupt-names: > + minItems: 1 > + maxItems: 100 > + items: > + - pattern: "^rx_[0-9]{3}$" Need to drop the '-' to make this apply to all entries. Otherwise, it's just the first one. > + description: > + Contains the interrupt name information for the Rx interrupt path for > + secure proxy thread in the form 'rx_'. > + > + interrupts: > + minItems: 1 > + maxItems: 100 > + description: > + Contains the interrupt information for the Rx interrupt path for secure > + proxy. > + > +required: > + - compatible > + - reg-names > + - reg > + - interrupt-names > + - interrupts > + - "#mbox-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + secure_proxy: mailbox@32c00000 { > + compatible = "ti,am654-secure-proxy"; > + #mbox-cells = <1>; > + reg-names = "target_data", "rt", "scfg"; > + reg = <0x32c00000 0x100000>, > + <0x32400000 0x100000>, > + <0x32800000 0x100000>; > + interrupt-names = "rx_011"; > + interrupts = ; > + }; > -- > 2.31.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel