From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B06BC433B4 for ; Fri, 16 Apr 2021 12:58:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8556A61153 for ; Fri, 16 Apr 2021 12:58:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8556A61153 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BdQR5uEmn+BybosTjirrxKDfL/5Wo1RArtrdV4GhvZY=; b=PPGIiDMhCoppZX+PqZUkG2IIc Dc2JQhw3ceUkR+VP86YD6LcbUeeURWtrccZ1wI4vwlhgCURRsddm5Gm1sb45anY8DK88e8BaMYew1 ZV4cAtpHoD9JevnGZSUSe8bNAa3uci7PxsL11br0y8pWnTNHT6FTzajTk7ddk2AC7prwYQHk0YEDr rhtpD6QSQ2aeWDXbboRL5SoRZy2zZRx0O6BMu3lA/tofiR35R5UkcpfkRuDXgvIzzWYZw+fhGI082 bhMy923vKASkmYcKTM0BjY393+Yt1daL8OAWDu+tA+6Z80M8qeZWvojP+7VpmOJnAG8VeKPdZYa73 Qwze2/g/w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXO1N-0028dz-C8; Fri, 16 Apr 2021 12:56:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXO1J-0028cc-Ka for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 12:56:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+0l09R5YV4cTaewP9ZigCQNEAFv3eBJoA6/SMdMCybM=; b=BfgHxnQwXwf1JbpZmyUB0jl3At 3/p87gYJhDnoVPiLo99JXo5dBMJlkKYKhrLF66y9EM7v846QKruH18x55HzPYNJI8K21wl/H5Xo9g bMDGr4IkvnYNkq4CCS9HcjWIdU1+zg25Eagrha6pdi9DeXXUSOprqYKY+ckDJLRAnf2ginGapdHZa 5yHhEUOrGQHgYYnpKI7TEPxEilpwpMe8/f/8lyQf5w4JKJLKK6goddgGd/SlG8xU7KDLKG49sCent AhAaXOTRn7h0tBhinLzN/wXyfD7eIGRIDvcUoMgjjggGM31sFEGxuo/SObLoydsDNXpNjUrmQpewY HU6TzF0g==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXO1H-009NL0-7B for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 12:56:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9214D610F7; Fri, 16 Apr 2021 12:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618577782; bh=23ztddlsot1OiQSW+jzU3lc5crCjHpuBOHg6FE7NOCU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P972PMau0T07t60h85tJxSn33x3UtULfNyKnBNRM5nHmj4MfPU3BooB+x/C4p1Llg P7oPK0cLuVWbHfXf8vVzq7SmjjtAvZ4vvdSJmr81cir37VEMu7R0auoPZ5gJmTvI/p iphIlcwbC9RPlOXJ13yyN+knbnZSTf8Jm027993ChzA91chBKh4pExyaNzCblvEFY3 14qc0XeiEujNFSft896KpijgiRH4xds17tpODiP8UkE6OzO15TqdXWx9U95rRI4/Xm ZRPjsvr1B9Mpz/Z8JIzWa39xTBWoikb8Xt4PyfyfoPo8OwDQ9qZb1sVNbwmilwwCYL nI25mWeNnvUQw== Date: Fri, 16 Apr 2021 13:55:58 +0100 From: Mark Brown To: quanyang.wang@windriver.com Cc: Michal Simek , Amit Kumar Mahapatra , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] spi: spi-zynqmp-gqspi: fix clk_enable/disable imbalance issue Message-ID: <20210416125558.GA5560@sirena.org.uk> References: <20210416004652.2975446-1-quanyang.wang@windriver.com> <20210416004652.2975446-2-quanyang.wang@windriver.com> MIME-Version: 1.0 In-Reply-To: <20210416004652.2975446-2-quanyang.wang@windriver.com> X-Cookie: Snow Day -- stay home. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_055623_320801_83651356 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8502527593983535137==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8502527593983535137== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 16, 2021 at 08:46:48AM +0800, quanyang.wang@windriver.com wrote: > Since pm_runtime works now, clks can be enabled/disabled by calling > zynqmp_runtime_suspend/resume. So we don't need to enable these clks > explicitly in zynqmp_qspi_setup_op. Remove them to fix this issue. > Fixes: 1c26372e5aa9 ("spi: spi-zynqmp-gqspi: Update driver to use spi-mem framework") Are you *sure* this fixes is accurate? The patch (and several of the others that flag the same commit) doesn't apply against for-5.12, though at this point there's not really enough time to send another pull request so it doesn't super matter though someone will probably need to help out with stable backports. --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmB5iV0ACgkQJNaLcl1U h9BrBgf9E/nnQ0hiXYFB/JYFD0fau71PNa16pFQ7bKnHt3CfKxLrtbdnmB4Y3VTR tfgTrNfwJ2dTMzRiaI8O5uZKuWu++rlIGeqgtNWd+IfRF1q//9U8CYGCUFvsLsyX x39mt7kX3E2SrBV7kS4UUREl6NBZ7FFSXr/3L6VV3/4c720m9DkRh1wEB7T3+iKZ z4ivj0z8KC/IjH8PgWdL8ZQEJ7NgKiMjJSoMA7teMrVVYBxsDaDa+d0jotU/BORq mYv6B7C1ih5zmGbhMp16eTk64/qfKuIW58J0G+0KiNtscsFStpWClOz9CowdKqtk I/ZBrcJk+bZXCvezq3JVVvDpzHBPRQ== =jZVz -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6-- --===============8502527593983535137== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8502527593983535137==--