From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA258C433B4 for ; Fri, 16 Apr 2021 13:23:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4729661103 for ; Fri, 16 Apr 2021 13:23:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4729661103 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LPkwAelBzyCSq/HHDwiKpeUgJQzUPIFrcKwUeU8OyJw=; b=n0tqjhTAP3Z5VW7DA34meFUMM lXZuHtKQVopxJJsmwmerunXWDQVH7zJfGb2T3bg/o+XwX7lka2NNib4QhLRlho944c0DTwhnsMjMb 4JosGVARXSlJY/k+iyfYBhdCAd3q3dKmDtGnG+vXrM6UOTblnrzrxLJnZWxYBOVTaEqOvfyoFImsz n7sF6BCmn8ujZibhnN2stEknNKCtMdUKpWPLexQAXv1Ny9kSzSow8+xVnPynGLAwwlV1IaWTvY+Oy qZc8jsh6Olld1YmYztTJVf89ODlGTVn461I6ctA2iXJBbfsrQ8kHQwGzPxj7s6eIBllyZzU4luyfE 4HNRk9RIA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXOQ4-002DFn-4x; Fri, 16 Apr 2021 13:22:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXOPQ-002CyO-E8 for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 13:21:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jNEOUMLacDExesI1dUec+Ag9poKcQi7/Bd0G3kzBs+E=; b=sKdaRV+t8ggqN4+H/x0mKBpNJD kR6fKjGw3sbiJDyYr5FKYAUxWuiu9OoW1SPgJ88CsfomoIaTXNHgLuWINxFpFPkmW8vdYyn5MiTTl e0MOq+dA5+xJabEC19RdEjH08AR/W0TdgDe9s7Kgq8tBq/mOoBbW7j8uDUi3iWOJ2U2I9ucY/9moT E8rF1z+h+C6jxkqpgEp3WgENEdw49hN6DSG/7foUrmHO8n6kIJPMrlymm5APLRk506TM8ynH3KN31 ntkDnc1kC/yPgcr7Xc7AW4v4Z0teZvsmwAiFag52uqr/0+92jMrDhixF7jHKDkcjL3Gkv2pwb+mUc AKKoqDNw==; Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXOPL-009OOH-Cr for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 13:21:19 +0000 Received: by mail-pj1-x1032.google.com with SMTP id e8-20020a17090a7288b029014e51f5a6baso9354084pjg.2 for ; Fri, 16 Apr 2021 06:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jNEOUMLacDExesI1dUec+Ag9poKcQi7/Bd0G3kzBs+E=; b=D9/9AyaxROOMxeGsn1K8bCTaAQz95ClMBt4f11oG2tHr3a0M33smsXCK4q9FqRHGBh rJr717NgoXD6Xjlj0KIusADW3eOuGNlu6va6ZfniMI+gCRFsH04lKBZ3t+IYqN3AAggx JuLfL0nFO//BkVvzHzeY7uYBlFzBGZRnUuCpYIDi5d6NS77FI6UbzUYAGQyFqSQiBz+7 wHOICFkSF0jU+ggXpXJf7pgFZKIOBfsIH/TyRMLY2mQjgN89BBvsPRBaAn4Cx16OTMNP Ru+6MiBawOLCueVpyWyWqsDR5GhtvGaYZ+iKz+/uNAhWQhb1oemX8vjWp4E6VVkauGqd h3Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jNEOUMLacDExesI1dUec+Ag9poKcQi7/Bd0G3kzBs+E=; b=Ilj3ULBVjjQKwYUt3WTS1SD+GS/WtZg+4lXE3H6v63gggl7pQxNe1duEVYj/SqDMJ9 RCNxGXrXBy8pTB3tZlSfqpVUUyhl/uQyW2flQ/ZvHnb/nzkTgScLkbWlzCJmi3mezoHz 92HxXGTV/kKcGZeL4Wa83xJtes2INTaBjZ3Oi78d0q5vPMnmwe/YGm2UYcnfw61OBY8i obEP3JMapENOlClW6JKTTwTaH+iN4c+iOz2A3F8xOgok45uPBskCi9oTU2zA4vDmM/w4 tvnQCkKwcOSQbQ28TGjoeoaqvW2k8VNFsciq6R98BinAOkrzZlsT4G5OEFXsHhPvq9lR 0B4g== X-Gm-Message-State: AOAM533o92SuOCQSLSL/e3yDIxzcDT5zbJPIsSGWK/2rVYwJCXpfYgG7 m77NNlvlPjU4YnTuikOx28uDzA== X-Google-Smtp-Source: ABdhPJyveue9gtWWLnn5Yel0ovmrx50udM1NmcCIuMHesFmn1b5+ri0JefXJZCkA45mBIEbj4zuSzg== X-Received: by 2002:a17:90a:150e:: with SMTP id l14mr6643850pja.208.1618579273482; Fri, 16 Apr 2021 06:21:13 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([204.124.180.30]) by smtp.gmail.com with ESMTPSA id x13sm6617982pja.3.2021.04.16.06.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 06:21:12 -0700 (PDT) Date: Fri, 16 Apr 2021 21:21:04 +0800 From: Leo Yan To: James Clark Cc: Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/6] perf arm-spe: Assign kernel time to synthesized event Message-ID: <20210416132104.GG1011890@leoy-ThinkPad-X240s> References: <20210412091006.468557-1-leo.yan@linaro.org> <20210412091006.468557-5-leo.yan@linaro.org> <9036368a-e824-3d63-da5b-54cf32a86aed@arm.com> <20210415152348.GF1011890@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_062115_480273_7DCAFF5F X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 16, 2021 at 03:51:25PM +0300, James Clark wrote: [...] > >> I noticed that in arm_spe_recording_options() the TIME sample bit is set regardless of any options. > >> I don't know of a way to remove this, and if there isn't, does that mean that all the code in this > >> file that looks at spe->timeless_decoding is untested and has never been hit? > >> > >> Unless there is a way to get a perf file with only the AUXTRACE event and no others? I think that one > >> might have no timestamp set. Otherwise other events will always have timestamps so spe->timeless_decoding > >> is always false. > > > > Good point. To be honest, I never noticed this issue until you > > mentioned this. > > > > We should fix for the "timeless" flow; and it's questionable for the > > function arm_spe_recording_options(), except for setting > > PERF_SAMPLE_TIME, it also hard codes for setting > > PERF_SAMPLE_CPU and PERF_SAMPLE_TID. Might need to carefully go > > through this function. > > > > Yeah, it's not strictly related to your change, which is definitely an improvement. > But maybe we should have a look at the SPE implementation relating to timestamps as a whole. Totally agree, at least this patch series should not introduce any barrier for timeless case. I will go back to verify it; if you'd like to fix timeless issue, please feel free to go ahead. Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel