From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D57C433ED for ; Fri, 16 Apr 2021 17:48:18 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E282E6137D for ; Fri, 16 Apr 2021 17:48:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E282E6137D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5XVAYMQut3qp5UeVFldjYAixj8LehDIV8DM+O3/ztCc=; b=EBZc3+88P13gMYCjnJDYePfvO cYH477MKNqGVxwcWp2O1110xlqOQe9xos7ROjV79RqVJJTqbSqRw4QfqGG8NG9kVSzCWwpwDJZRuM J4FvWJ+iIV1PDxO8+rychS42ROe6aK+btYR2rz24XnPzIlPGOj9bmdfkL70mjt2/A2Uosv8V8teQw ip7jBGoiNEAv7bTdUpwQIb5lDjuTVGQ6JaPIzQXyX59S+aUj/RjP/ZQR6DfjS7qk9ntnVKEp7kDvx DEobdwbFCEhi4OFtQZal/mNtSF0oHlytuzddIjtwe0LMJxDqG/4Or/0N1u/kKdShmi65sgaq67G6Y mnUwH+cYA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXSY3-002z0L-OP; Fri, 16 Apr 2021 17:46:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXSY0-002z0A-8A for linux-arm-kernel@desiato.infradead.org; Fri, 16 Apr 2021 17:46:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7wXuYb2sAQupo2LG+aIJB2xPslEGiIuMvjBT329yg3U=; b=gISHXlAijuGaAjstI75j8Bm7Vu Me9D5TMlN7dV9EKA1kMSs0nrqACDdcgz1TUKhh9mfs5DqqfaIrH0Q2v2FU/H8c04/jgup7P3YhJri uDpSOZECA7oXiQ1/L0KfU5P/LTpQUGEebqVBVdDKmHQgPkzra7O4IM0O9CyESTaxC7RVALD1ydFx3 utrXf6nkwxZ2yMU1wdb7FDcbp+Dr4QfLYYN6p1nVA2mqYzhDKy78gAGfFSR+y8U5YOvxZcRm5TBib Qdkls0EzyM1SGWMt7IAC/NcJT9PFaM/dYtFLCTDFZhl26tXNMFRsSiST8Obr4TL+9BOxMvJGr0NdK LOnToApw==; Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXSXx-009bVm-FZ for linux-arm-kernel@lists.infradead.org; Fri, 16 Apr 2021 17:46:27 +0000 Received: by mail-pl1-x631.google.com with SMTP id p16so10419348plf.12 for ; Fri, 16 Apr 2021 10:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7wXuYb2sAQupo2LG+aIJB2xPslEGiIuMvjBT329yg3U=; b=J5PjHQGscCeSuO/gbZXuoewf8jGW9qKmFdTqS24XZn2uTUgChpjgJRSE0zIyVx56Wh K6ruEk05Qdf/5KJuHfJh2gsM6DgcJMLk5XKJdzJRHkL5lactllzN9rrVHBS3m4GBuPHW eErmAOFfOjDA/Gt40EEImNaXyzYe9+WbtA+ropKWwpYzYE1tOk8HmAhaJuhfg8l14tS1 CfAvjkhATJRg+pCAjnA8NuY+7lDvuXhPFECRnCp9ZI6N07vSV0SN/rLQq6OvPXv2/Jtt nNvYqgvphMkTuvocMNUxcBqqrnKDOd6jNIrLIhFiOp9Oxgy7/iZfIezi6KBvTcO48Upy qVRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7wXuYb2sAQupo2LG+aIJB2xPslEGiIuMvjBT329yg3U=; b=HYZWCo6+a+QazFUba0kpUmlYnEx+QxHZrBFu1COWKr40/x4kKwWsS9+qaqHJZEF/7X sLz6rZzRRMGc5kFCgjuAugTvpEmCulMs70StJbUmsri64PiUm77CFW7YfLqoR+Mx1CY9 u9KiAJRqxOEd3/jYFL7ErQqAbz9911zB9pfr3cy1vr4vCsWM10ufXAEPQeGsxyj75WM4 DxKjSiCVb3xs8+rqN49IKpcgm8Euol42+znwWgbKH3LL1eTfQ0RFFfbgOclQSUFi52tA j9dI1f10x37W/6BeuCEBc4QVfS1yDSHuK5Fw1ih8IuWDOSu6OMrIIVTTpvpi8rvS1IQQ 14MQ== X-Gm-Message-State: AOAM533NvbDfqws9piNHYCl9SioSbJMHk4rdeT2WXy5rkyO0QQTU8Znm ky5jA/2bBHUleaTO0mkBwylewQ== X-Google-Smtp-Source: ABdhPJzfFYb59axooQ1Dcvl2ibVjHLLezR7oN3SWOQimhjaIEN5XT1qNMQndTGWqeZYEeUsA9MoKxA== X-Received: by 2002:a17:902:f1d3:b029:ec:7b6e:5826 with SMTP id e19-20020a170902f1d3b02900ec7b6e5826mr4473776plc.22.1618595184388; Fri, 16 Apr 2021 10:46:24 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id w123sm1891141pfb.109.2021.04.16.10.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 10:46:24 -0700 (PDT) Date: Fri, 16 Apr 2021 11:46:22 -0600 From: Mathieu Poirier To: peng.fan@oss.nxp.com Cc: ohad@wizery.com, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V4 6/8] remoteproc: imx_rproc: make clk optional Message-ID: <20210416174622.GC1050209@xps15> References: <1618493261-32606-1-git-send-email-peng.fan@oss.nxp.com> <1618493261-32606-7-git-send-email-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1618493261-32606-7-git-send-email-peng.fan@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210416_104625_552466_7E355840 X-CRM114-Status: GOOD ( 23.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 15, 2021 at 09:27:39PM +0800, peng.fan@oss.nxp.com wrote: > From: Peng Fan > > To i.MX7ULP, M4 is the master to control everything, no need to provide > clk from Linux side. So make clk optional when method is IMX_RPROC_NONE. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 46 ++++++++++++++++++++++++++++-------------- > 1 file changed, 31 insertions(+), 15 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index 2b633fd..56dfcc1 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -606,6 +606,35 @@ static int imx_rproc_detect_mode(struct imx_rproc *priv) > return 0; > } > > +static int imx_rproc_clk_enable(struct imx_rproc *priv) > +{ > + const struct imx_rproc_dcfg *dcfg = priv->dcfg; > + struct device *dev = priv->dev; > + int ret; > + > + /* Remote core is not under control of Linux */ > + if (dcfg->method == IMX_RPROC_NONE) > + return 0; > + > + priv->clk = devm_clk_get(dev, NULL); > + if (IS_ERR(priv->clk)) { > + dev_err(dev, "Failed to get clock\n"); > + return PTR_ERR(priv->clk); > + } > + > + /* > + * clk for M4 block including memory. Should be > + * enabled before .start for FW transfer. > + */ > + ret = clk_prepare_enable(priv->clk); > + if (ret) { > + dev_err(dev, "Failed to enable clock\n"); > + return ret; > + } > + > + return 0; > +} > + > static int imx_rproc_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > @@ -654,22 +683,9 @@ static int imx_rproc_probe(struct platform_device *pdev) > if (ret) > goto err_put_mbox; > > - priv->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(priv->clk)) { > - dev_err(dev, "Failed to get clock\n"); > - ret = PTR_ERR(priv->clk); > - goto err_put_mbox; > - } > - > - /* > - * clk for M4 block including memory. Should be > - * enabled before .start for FW transfer. > - */ > - ret = clk_prepare_enable(priv->clk); > - if (ret) { > - dev_err(&rproc->dev, "Failed to enable clock\n"); > + ret = imx_rproc_clk_enable(priv); > + if (ret) Much better Reviewed-by: Mathieu Poirier > goto err_put_mbox; > - } > > INIT_WORK(&priv->rproc_work, imx_rproc_vq_work); > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel