From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42F8C433B4 for ; Sat, 17 Apr 2021 18:04:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5A6C613B0 for ; Sat, 17 Apr 2021 18:04:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5A6C613B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mailo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uNF+tmQkx9uTKhYC21xguDJ4pRvPu/pJQDeZtba2iQk=; b=mliV63Gb8Xmn332BFYoqoby3z Z6huyFS8jSNmH9CiJVUWjFZETYp09ijeoi5IdovQxVHvUKDi45JlQ2Eq8SfbcTP+jfHdPTV++4qGY ojCCnMYBr0rchNmh54Hcbi8yaIt4yqUllM9yZOBQe8XsRxtDgDKHYMU8k2m7il3bWiUPTY6ANLOuI uMgA9QO0MEGplrJ3UlaRO/59UnftP0mALuzGn+FpGdL5U27yLv6KaM48DjKzE3uHb9CkCJ18AEykj 2xQ0Jc7SY456wZSq/nzvy7F5CJh38G9V5L90PAjFPTqjDVdg7jn7cFPMRRuA3kiWr6yucLu9k3xtp s/9woHyfg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXpHQ-005uDT-5J; Sat, 17 Apr 2021 18:02:53 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXpHM-005uCy-Sd for linux-arm-kernel@desiato.infradead.org; Sat, 17 Apr 2021 18:02:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YU+cBBOiZdtsh9eyy3nlM1SqE8LiMPLqXT1Mj5hwkeY=; b=xHpD9lEyqNA8GODXsH6yjr9x9p Re4VnEBqgEaBvLS4/Nn3Zvs6UUUlc8lSX/KEh1r5bKCzRIa6tdUBF9DuEOZUU2uck6taAaboqzPVJ MXyvNSPWdOfj48yrFxKFa+NF5F+ZUGM2JpY5L+D6E7WbRqhXpPuzGnYDgBOdhH/SCArPLlMvzpEhP O1xW2ujJnmNAU1J9NC+HIu0YXaMMGQLp2j9UEZvNr2Yr/mqRojfaxrAzWEZnM8Tbt2c3fzH7MtDJk TcQ3i98u3H4PB4dZ6OTjtBahC+yvQ87tw6i3+fF3I6CaHmOmibz1kxHyttk6Wk18K4JQ0B5sGTZap VttW8m1w==; Received: from msg-1.mailo.com ([213.182.54.11]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXpHH-00A8Yt-Bx for linux-arm-kernel@lists.infradead.org; Sat, 17 Apr 2021 18:02:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1618682549; bh=4eq0XB2PDXbqcR+ae3DKP4xFXNTYnqgh2PvlghKLwFY=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=V6Y9jZ/DTLcalqmW525qU29ePMjGNf1p/vF59r2xtVdlxhhBEP06+kvw1/n5gB3WP woER+FkPcNM43Q1GnCojoNgz1yJA9WTgONYARqIodAKS8qRd4iYWet8dcQXNfqR5+3 VsczuQ5RNTzlmoCV+SvgNhrf4zQEg2kRpkXGSSxo= Received: by 192.168.90.16 [192.168.90.16] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 17 Apr 2021 20:02:29 +0200 (CEST) X-EA-Auth: BGF3KMrn3vZeZ9Aq4VOlG2I3jc15d0iq3NyEkQNPoffhJN7IU74aAH3G3p7wPgRbAXVPQ9aD5LYJ5gcuBPLXPoNIvYnX6sO2 Date: Sat, 17 Apr 2021 23:32:22 +0530 From: Deepak R Varma To: Srinivas Neeli Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, michal.simek@xilinx.com, shubhrajyoti.datta@xilinx.com, sgoud@xilinx.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com Subject: Re: [PATCH 3/3] gpio: zynq: Check return value of irq_get_irq_data Message-ID: <20210417180222.GA112239@localhost> References: <20210409140806.31824-1-srinivas.neeli@xilinx.com> <20210409140806.31824-4-srinivas.neeli@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210409140806.31824-4-srinivas.neeli@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210417_110243_723325_D57E86C5 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 09, 2021 at 07:38:06PM +0530, Srinivas Neeli wrote: > In two different instances the return value of "irq_get_irq_data" > API was neither captured nor checked. > Fixed it by capturing the return value and then checking for any error. > > Addresses-Coverity: "returned_null" > Signed-off-by: Srinivas Neeli > --- > drivers/gpio/gpio-zynq.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c > index c91302a16c77..f0cb8ccd03ed 100644 > --- a/drivers/gpio/gpio-zynq.c > +++ b/drivers/gpio/gpio-zynq.c > @@ -736,6 +736,11 @@ static int __maybe_unused zynq_gpio_suspend(struct device *dev) > struct zynq_gpio *gpio = dev_get_drvdata(dev); > struct irq_data *data = irq_get_irq_data(gpio->irq); > > + if (!data) { > + dev_err(dev, "irq_get_irq_data() failed\n"); It will be useful to include a tag such as "suspend: " in the error message to uniquely identify where it failed from. > + return -EINVAL; > + } > + > if (!device_may_wakeup(dev)) > disable_irq(gpio->irq); > > @@ -753,6 +758,11 @@ static int __maybe_unused zynq_gpio_resume(struct device *dev) > struct irq_data *data = irq_get_irq_data(gpio->irq); > int ret; > > + if (!data) { > + dev_err(dev, "irq_get_irq_data() failed\n"); Ditto. Suggest using "resume: " tag here. > + return -EINVAL; > + } > + > if (!device_may_wakeup(dev)) > enable_irq(gpio->irq); > > -- > 2.9.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel