From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A2BC433B4 for ; Sat, 17 Apr 2021 21:31:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C8F861207 for ; Sat, 17 Apr 2021 21:31:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C8F861207 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RBO4Fh7/P+ylcgBQicGSzanDoRht87fucniAgx7JCak=; b=gl2bwRewW8In0tegpZzhO2dH+ IJWbSTrJnjVyBvyyd90IP0Fq/LCDAXwuE30QV8Prv7jlIymyGRlWWcVSl8x3YEDiL8npwm9yAYrH/ vId+JPE6SpiieRXibH1EbCDNjaCd9xINirKat1kB/8Hx1BTwhENgvdn1/AVBPKOBJV0JD+iaBwHIs Is7+HqXnJsgHN794dMnbjlkQcvBCAtkaF8ftGCh9VMw4TWAkfbZHqNjg88bf01YljgtVRJCzIMkWc 2AIvVJMPvQgs/i3VRKOEUH9ecgrTwzELorfm+YpZEV6JlS4ceXLPGqBaUusI+1fIpD70pxwkgeJ2b hghGaXqfw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lXsVK-006Jtj-8e; Sat, 17 Apr 2021 21:29:26 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lXsUl-006JoH-4O; Sat, 17 Apr 2021 21:29:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tdMd9G9wD3dHdDB049z0mEp3bwlE87mJ0J7o89xl/iU=; b=kjCBnWRnNfJ4jh1gNX/lQqFZaV PIt6sDdbkDGzgmh71GE65C7gRjevycey4DoCtbejN9tL9oy21OFCEaAalEL1tJX2o90jMIunwvzlT aw6WnoUC4xKa/S6Fo+ZMatucihabyUEWmzgS2fQA3KuKU2AamMDSAvwzszyCc5I4TnWdPWLrwWCKi rVT5becyLy4eWu5C3CPFKJcjpScabeN83QGn+BwxjvQCu6su18nAbnPuTOLaKIYZFme9zSXfjcKXe HVFpVtf65QAh/PF06VB9QUA3eZMEV6/SGt6UIGiIg++xfTnOleyRsiTg4gP470cAho43TKpegokfh QjMDTCHQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lXsUd-00BiOm-RD; Sat, 17 Apr 2021 21:28:45 +0000 Date: Sat, 17 Apr 2021 22:28:43 +0100 From: Matthew Wilcox To: David Laight Cc: "brouer@redhat.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "ilias.apalodimas@linaro.org" , "mcroce@linux.microsoft.com" , "grygorii.strashko@ti.com" , "arnd@kernel.org" , "hch@lst.de" , "linux-snps-arc@lists.infradead.org" , "mhocko@kernel.org" , "mgorman@suse.de" Subject: Re: [PATCH 2/2] mm: Indicate pfmemalloc pages in compound_head Message-ID: <20210417212843.GT2531743@casper.infradead.org> References: <20210416230724.2519198-1-willy@infradead.org> <20210416230724.2519198-3-willy@infradead.org> <2a531a42f23e4046833e0feb8faef0b5@AcuMS.aculab.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2a531a42f23e4046833e0feb8faef0b5@AcuMS.aculab.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Apr 17, 2021 at 09:13:45PM +0000, David Laight wrote: > > struct { /* page_pool used by netstack */ > > - /** > > - * @dma_addr: might require a 64-bit value on > > - * 32-bit architectures. > > - */ > > + unsigned long pp_magic; > > + unsigned long xmi; > > + unsigned long _pp_mapping_pad; > > unsigned long dma_addr[2]; > > }; > > You've deleted the comment. Yes. It no longer added any value. You can see dma_addr now occupies two words. > I also think there should be a comment that dma_addr[0] > must be aliased to ->index. That's not a requirement. Moving the pfmemalloc indicator is a requirement so that we _can_ use index, but there's no requirement about how index is used. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel