From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F418CC433ED for ; Mon, 19 Apr 2021 13:37:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57BD261245 for ; Mon, 19 Apr 2021 13:37:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57BD261245 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eXEGT7iLzMA9vHfNHyYOsb84dZW1X9m2M4RlFFclhAg=; b=ETGQIsDf7wgqPMmKjghL9jfeZ gaEK59Qb8KBNUwhjekpWOnXszvy+CtSzanTeCE2a8EC0rkYoEfNetebVt7QimOuiRON65ZEpQ14cR /KEO42sPpZb9GEkvC7DdUsmedIcATuKOIXhMN+NXUNHf6qPpAQVzzDRQFQRDC/hOzBA3AKfkHJjtU l+sUc1CgxfSLW9pJrH1gQ5dRkg8gzrYgGt+PVohLvlVkQtvrrDkqqNhgkGVCrwGstj/miCtLMfCZx xlgUeyTEHpvlNN/sJT6yjORF24/yDSueOx4bXPyPYjsZLauQw4E9+crV61R+jrKI467GUNXZEONNc 8Qn5G8T+Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYU4E-009zzl-3o; Mon, 19 Apr 2021 13:35:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYU4A-009zzP-Fe for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 13:35:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qeZcN+h8qnPRTBufAOnY5cwD/Q0Lqcs0+bre14HwovE=; b=kKlYbpNkG/Nqd1NH8U8oXlr+xh kcqTtGiYCCd0K4FfImt5AwqaSMbVMLw1a1gpHqYWJuX+n9Mw/Y7VShP17G76a9EX0sEbiq5F7FhZ0 /5dSHULnmVzSJZtbGqzVunQHdpxpAcox+RhUB5DPflYo87ir2JDzbRjA8ZmSliO0Icsq14/bo8cct l7kzUEKMiab2wBSXButszI8ifhdhjkTcSQxsMF2bQuO1RQY2/NqrQrN/TJxOU2wj6L5MEI5X03nO7 9yFYdMH7GJRurnxuaU/45MbKvD4xVQHbz10o7aEeIT5yYinZy84f9OO+PvloLEvz62Re3dPOSDKHQ aDlHb6pg==; Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYU45-00BPN2-Jb for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 13:35:53 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13JDZhIo110437; Mon, 19 Apr 2021 08:35:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1618839343; bh=qeZcN+h8qnPRTBufAOnY5cwD/Q0Lqcs0+bre14HwovE=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=ENexWrbeYpj1oR7s5ZNzjDgFGxdy9V5O5I+UoZJrHh+oyikFGpjm2EC1r5PkdOExF YxrIJjWVnpq4YdeaqGu0T2i5G6p+Nq15aoOR/DwnUgNzQKYCMLGI7g9EYJYsSAe7W+ NeyvnQbpUEuUUsh9Xei/vmLpjIyd1hvq3MPj04GQ= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13JDZhtI129553 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 19 Apr 2021 08:35:43 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 19 Apr 2021 08:35:42 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 19 Apr 2021 08:35:42 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13JDZgj9049023; Mon, 19 Apr 2021 08:35:42 -0500 Date: Mon, 19 Apr 2021 08:35:42 -0500 From: Nishanth Menon To: Stephen Boyd CC: Michael Turquette , Philipp Zabel , Rob Herring , Santosh Shilimkar , Tero Kristo , , , , Subject: Re: [PATCH 2/4] dt-bindings: clock: Convert ti, sci-clk to json schema Message-ID: <20210419133542.ndgkmf7eq4oqse34@ladies> References: <20210416063721.20538-1-nm@ti.com> <20210416063721.20538-3-nm@ti.com> <161861731160.46595.786611690053722257@swboyd.mtv.corp.google.com> <20210417125127.vigq23mdoodje6b5@velcro> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210417125127.vigq23mdoodje6b5@velcro> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_063549_751222_F80E90CC X-CRM114-Status: GOOD ( 27.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Stephen, On 07:51-20210417, Nishanth Menon wrote: > On 16:55-20210416, Stephen Boyd wrote: > > Quoting Nishanth Menon (2021-04-15 23:37:19) > > > diff --git a/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml b/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml > > > new file mode 100644 > > > index 000000000000..72633651f0c7 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml > > > @@ -0,0 +1,52 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/clock/ti,sci-clk.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: TI-SCI clock controller node bindings > > > + > > > +maintainers: > > > + - Nishanth Menon > > > + > > > +allOf: > > > + - $ref: /schemas/clock/clock.yaml# > > > > Is this needed? > > https://github.com/devicetree-org/dt-schema/blob/master/schemas/clock/clock.yaml > This standardizes provider properties like '#clock-cells' etc, allowing > you to add more stricter checks or controls in the future if necessary. > > while: > > https://github.com/devicetree-org/dt-schema/blob/master/meta-schemas/clocks.yaml > is more a consumer node description. > > Should I have picked a different yaml as base for a standard clock-controller > base? > Thinking again, I think your comment was to drop the clock.yaml inclusion, and, as a result this schema can become more stringent.. Could you clarify? > > > > > + > > > +description: | > > > + Some TI SoCs contain a system controller (like the Power Management Micro > > > + Controller (PMMC) on Keystone 66AK2G SoC) that are responsible for controlling > > > + the state of the various hardware modules present on the SoC. Communication > > > + between the host processor running an OS and the system controller happens > > > + through a protocol called TI System Control Interface (TI-SCI protocol). > > > + > > > + This clock controller node uses the TI SCI protocol to perform various clock > > > + management of various hardware modules (devices) present on the SoC. This > > > + node must be a child node of the associated TI-SCI system controller node. > > > + > > > +properties: > > > + $nodename: > > > + pattern: "^clock-controller$" > > > > Is this nodename pattern check required? > > I'd like the definition on rails and not subject to interpretation, and > restrict the kind of subnodes under TISCI controller node. > > > > > > + > > > + compatible: > > > + const: ti,k2g-sci-clk > > > > I thought most things keyed off the compatible string. > > Yes, they are. I am not sure I understand your question here. Did you > mean to indicate that having $nodename and compatible both are > redundant? > > Redundancy was'nt the intent of this schema definition, rather, I'd like > to make sure that it is not upto interpretation or debate as to what the > node name should be: I believe clock-controller is the correct nodename > (without @0x... since this does'nt use reg property) instead of using > clocks, tisci-clock as the node names. > > > Do you suggest something different? > > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel