From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7854CC433ED for ; Tue, 20 Apr 2021 14:19:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBF43613B4 for ; Tue, 20 Apr 2021 14:19:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBF43613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wJzWj9ZwXKsexRjVnKEK31i6f1+Uhdm5/BxA5PizTko=; b=puVACgIU4znXV8iYvzxQVEB7O CqA9wenlINujSCMDV90GWJzBMyCvDS3SXhxGoqvo6VVCUxWWHm+yoSJFJhzokGB6CV1yaItxhH6B9 neSfuIZ2RW5UjJSCtNWlEygXvkBorgwKfYAb2irjiux8JU1qLzi8IWK8SFt0l72JqDpxMPQv8fs0B 5dxY/kaM2rPz9iPFlqa8tETGmKpaZh83HokzV59POf6zKXLFwb9ersTW6fTutJ1ISxmivCt8ek+wv 279NU40Ssaw2+BhwhfqhqQHPeL1hmnW/z20iojCLmmtGajpQkFmUGMjmOSLfSHhG9rqnXhrHA5Zuy /pFiiljeQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYrBf-00CJje-DF; Tue, 20 Apr 2021 14:17:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYrBc-00CJjC-Na for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 14:17:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UIwFEv9Tdve32KSnkSNK+uSX3oxpeexxuh6b/UYPgCA=; b=xfX028cQXvwFk+2eWEb5bjaYSy aD8M7/Z7qbc/TbM8C56Ql+MIGY15ILW3YTZtP3SfTpZlGgNODwqqRMM0NMm0iTyf1fNdfCnUc3yLw lHXtuJnnf39FWzkTJEN6xO54Byisuqc+QaEQDcr9BpSPdfD7xPHIjsIJliiK12LG608IezesvSi++ 0I4ydr5mVZLSZfNBXGINfqzn8Ygm4jhVR/PcU2/VDNJr5DA64MUuIdmpTDjg9+rmzUH3/YxY+tk32 WRJgnbjpJIGoNIid1To/vWZsKvNHZqyLtgQYcrS3sQ02UOyoOqqMFwIAQk4Z3KSknmyk3FSbPxOJY QwaJeqpQ==; Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYrBW-00CBY0-TB for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 14:17:07 +0000 Received: by mail-pj1-x1036.google.com with SMTP id nm3-20020a17090b19c3b029014e1bbf6c60so16327020pjb.4 for ; Tue, 20 Apr 2021 07:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UIwFEv9Tdve32KSnkSNK+uSX3oxpeexxuh6b/UYPgCA=; b=SVEcqqjQDN+pAb0FIxomH9lnECcqwn9ioGJB9rPdblKTm7CUPl8CyfcBY6DPk9m5bl 8I34DXZGVDDuQvmeUuVsJLfTC6NR6HJO3DP6i6u1PMF5KRVmmHZi5IIu6MYiEyq1STPy uxlO6pWQvh5+7g/JvtLx/U0VXoHLS7RM1+I9RP2XCEVKjt4YzTcfo27djQt3bxpzpil3 HVRhjc1lpZ6fYLoCPVfCFZO7FMHgx81Ck4m/B9TnARILbI0ag1YBgn3og098g37TVJfB hX4950RCUvVA7ygIIGjmypEbXdaOXaJPRyHH5FJrrBIiE9BnmbYS4fFS5jslSoRtEU7Z 8Cmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UIwFEv9Tdve32KSnkSNK+uSX3oxpeexxuh6b/UYPgCA=; b=c3Vt16s3THtwAV14Tb3ZBT17Umbt88EJpuyF2dHV1vxwN3d+pzyLx9A0epVv5MCdFM G88iBpvRIPw5uRDGQBWHzKY4Z7iaEJWhvtOVBO1sR4fLDXzqphImTbutCI8wkd8oywQk WW2nLuVs2J6Q57gmLfCRf4Pr5nuwJOxJMMTf844JHeLpr+P0J2SNWMaqTaDmzqiDwhaf Onu5lH6j/NSdDHjLbWBf09BiwwjN+LDQfZyIN/448Ncl/Ot1pHY6yv+2AXBgLz2BxWRZ 5u9qYWqmIL9y1p3GGhJOt8AxkHPaComE8dzOV6C/GkRjEn3V7xeGNaU43R/MteF79j+s tV+g== X-Gm-Message-State: AOAM532fxHqC3w/OeLYyOI8Jli3111ns/02bfm+NpC5mBCthkEsrZhnl NVweFL8gM58C6x86hhM+olo= X-Google-Smtp-Source: ABdhPJzXtzkAoARVl/ZAB0IWlrCrIq1zqmNiZzSkH0EZZ+WVcYo5/766QHPAgnecFpGimAIs4eLLdg== X-Received: by 2002:a17:90a:684b:: with SMTP id e11mr5387090pjm.87.1618928221826; Tue, 20 Apr 2021 07:17:01 -0700 (PDT) Received: from skbuf (5-12-16-165.residential.rdsnet.ro. [5.12.16.165]) by smtp.gmail.com with ESMTPSA id a27sm3380347pfl.64.2021.04.20.07.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Apr 2021 07:17:01 -0700 (PDT) Date: Tue, 20 Apr 2021 17:16:50 +0300 From: Vladimir Oltean To: Michael Walle Cc: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org, Po Liu , Claudiu Manoil , Alex Marginean , Rob Herring , Shawn Guo , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Russell King - ARM Linux admin , Andrew Lunn , Vladimir Oltean Subject: Re: [PATCH net-next 0/5] Flow control for NXP ENETC Message-ID: <20210420141650.hiu6feeaj7zrdmco@skbuf> References: <20210416234225.3715819-1-olteanv@gmail.com> <20210420140433.hajuvfiz4humhhkt@skbuf> <0bf4aa61dea7be0723fda2d8597644ad@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0bf4aa61dea7be0723fda2d8597644ad@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_071702_979661_831E56A8 X-CRM114-Status: GOOD ( 33.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 20, 2021 at 04:10:34PM +0200, Michael Walle wrote: > Hi Vladimir, > > Am 2021-04-20 16:04, schrieb Vladimir Oltean: > > On Tue, Apr 20, 2021 at 03:27:24PM +0200, Michael Walle wrote: > > > Hi Vladimir, > > > > > > Am 2021-04-17 01:42, schrieb Vladimir Oltean: > > > > From: Vladimir Oltean > > > > > > > > This patch series contains logic for enabling the lossless mode on the > > > > RX rings of the ENETC, and the PAUSE thresholds on the internal FIFO > > > > memory. > > > > > > > > During testing it was found that, with the default FIFO configuration, > > > > a sender which isn't persuaded by our PAUSE frames and keeps sending > > > > will cause some MAC RX frame errors. To mitigate this, we need to ensure > > > > that the FIFO never runs completely full, so we need to fix up a setting > > > > that was supposed to be configured well out of reset. Unfortunately this > > > > requires the addition of a new mini-driver. > > > > > > What happens if the mini driver is not enabled? Then the fixes aren't > > > applied and bad things happen (now with the addition of flow control), > > > right? > > > > > > I'm asking because, if you have the arm64 defconfig its not enabled. > > > > > > shouldn't it be something like: > > > > > > diff --git a/drivers/net/ethernet/freescale/enetc/Kconfig > > > b/drivers/net/ethernet/freescale/enetc/Kconfig > > > index d88f60c2bb82..cdc0ff89388a 100644 > > > --- a/drivers/net/ethernet/freescale/enetc/Kconfig > > > +++ b/drivers/net/ethernet/freescale/enetc/Kconfig > > > @@ -2,7 +2,7 @@ > > > config FSL_ENETC > > > tristate "ENETC PF driver" > > > depends on PCI && PCI_MSI > > > - depends on FSL_ENETC_IERB || FSL_ENETC_IERB=n > > > + select FSL_ENETC_IERB > > > select FSL_ENETC_MDIO > > > select PHYLINK > > > select PCS_LYNX > > > > Yes, ideally the IERB driver and the ENETC PF driver should be built in > > the same way, or the IERB driver can be built-in and the PF driver can > > be module. I don't know how to express this using Kconfig, sorry. > > With the small patch above it is: > FSL_ENETC=m -> FSL_ENETC_IERB = m or y > FSL_ENETC=y -> FSL_ENETC_IERB = y > FSL_ENETC=n -> FSL_ENETC_IERB = m,y or n > > Will you fix it? Should I prepare a patch? Could you please send the patch? Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel