From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B679DC433B4 for ; Wed, 21 Apr 2021 17:12:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7648161164 for ; Wed, 21 Apr 2021 17:12:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7648161164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LamkQA0B+enbLU4DdFTrn/foxT1gJ017Db9yq5ao1bE=; b=aDbfkIZLW9Q3GrPkfdYrxyAcn 1nEUcPTT/mBUwWCDPzJdC348ISRSgMjI7Ny5feSTVvM5fbokNGCSG0z7e312wtYbQiUtdyVH56xJa Ntca69JKIMlosEH/OSf1IxN0JfCMSDB/V0SuQSm810ATnq7ygG9Rj6rDZhFIiFSRw84sY2+S01f1o CX0wIy7Lr+XzVCcyQsyAwYd3PCQFiofB12jtveJkFw+EQ0bwCqXnl/h9BoN0OoVCecpcIHybghVz0 M7ABLcTxZg/W1c8Vi8ggbvVtqCBPHxQig8+2Mzev3kb8cH6uXm5IvBzBMlaMGEioB2P1UgLeMb0ZX 5zeFXLgoA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZGMv-00EpFw-Pb; Wed, 21 Apr 2021 17:10:29 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZGMr-00EpFW-QK for linux-arm-kernel@desiato.infradead.org; Wed, 21 Apr 2021 17:10:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oZ26Qn3geL2r0Hef3GeZBPIzKw/I3KeVowmSufr0R2g=; b=qzd38OE38bKFqkvNbNtXQky32v h/BwsHEe2j/WZ0kO7zjBzBOUxybsMxSVeq2+n1EBxqI5XZBAETkjfm5152Z0Cz/7HU0UGgajyBpms KxtouIOxAk8HxpneX4XhhnTDKW3IFeqFd8SPEhvD4qzH7ZTc+8oBLP9wLCcL4RrbW5IEqt2UMHXUz RugjBNXDjDjXFObpy+U2Zib3NQDx10Bh9cX7XCchWbPbdrFNBPqtR2WqDN2yJNTjX3uTFts95yEaX A1BaBqntVK1tkLY/g9lG7Nkcjl61CTM8zi3L5V5lb2V+r3bqPGdB9H8+GjYyg88kwFA6/epXC5hqw LmJf/YUQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZGMn-00D3J0-SR for linux-arm-kernel@lists.infradead.org; Wed, 21 Apr 2021 17:10:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0047E11FB; Wed, 21 Apr 2021 10:10:16 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.3.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7BC1C3F694; Wed, 21 Apr 2021 10:10:14 -0700 (PDT) Date: Wed, 21 Apr 2021 18:10:05 +0100 From: Mark Rutland To: Will Deacon Cc: Catalin Marinas , He Zhe , oleg@redhat.com, linux-arm-kernel@lists.infradead.org, paul@paul-moore.com, eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat Message-ID: <20210421171005.GA46949@C02TD0UTHF1T.local> References: <20210416075533.7720-1-zhe.he@windriver.com> <20210416123322.GA23184@arm.com> <20210416133431.GA2303@C02TD0UTHF1T.local> <20210419121932.GA30004@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210419121932.GA30004@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210421_101021_998058_0AF3E196 X-CRM114-Status: GOOD ( 25.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 19, 2021 at 01:19:33PM +0100, Will Deacon wrote: > On Fri, Apr 16, 2021 at 02:34:41PM +0100, Mark Rutland wrote: > > I think this is a problem we created for ourselves back in commit: > > > > 15956689a0e60aa0 ("arm64: compat: Ensure upper 32 bits of x0 are zero on syscall return) > > > > AFAICT, the perf regs samples are the only place this matters, since for > > ptrace the compat regs are implicitly truncated to compat_ulong_t, and > > audit expects the non-truncated return value. Other architectures don't > > truncate here, so I think we're setting ourselves up for a game of > > whack-a-mole to truncate and extend wherever we need to. > > > > Given that, I suspect it'd be better to do something like the below. > > > > Will, thoughts? > > I think perf is one example, but this is also visible to userspace via the > native ptrace interface and I distinctly remember needing this for some > versions of arm64 strace to work correctly when tracing compat tasks. FWIW, you've convinced me on your approach (more on that below), but when I went digging here this didn't seem to be exposed via ptrace -- for any task tracing a compat task, the GPRs are exposed via compat_gpr_{get,set}(), which always truncate to compat_ulong_t, giving the lower 32 bits. See task_user_regset_view() for where we get the regset. Am I missing something, or are you thinking of another issue you fixed at the same time? > So I do think that clearing the upper bits on the return path is the right > approach, but it sounds like we need some more work to handle syscall(-1) > and audit (what exactly is the problem here after these patches have been > applied?) >From digging a bit more, I think I agree, and I think these patches are sufficient for audit. I have some comments I'll leave separately. The remaining issues are wherever we assign a signed value to a compat GPR without explicit truncation. That'll leak via perf sampling the user regs, but I haven't managed to convince myself whether that causes any functional change in behaviour for audit, seccomp, or syscall tracing. Since we mostly use compat_ulong_t for intermediate values in compat code, it does look like this is only an issue for x0 where we assign an error value, e.g. the -ENOSYS case in el0_svc_common. I'll go see if I can find any more. With those fixed up we can remove the x0 truncation from entry.S, which'd be nice too. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel