From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FDDFC43460 for ; Thu, 22 Apr 2021 14:12:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8698E611CC for ; Thu, 22 Apr 2021 14:12:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8698E611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6pRcb+UwIdexdNrBtMVKaNdCKNHil5bibfk2Vm9c3fQ=; b=O9F2nU36SKX3me/85fvKatePI yVCRVjoGSqOSou+/fv/YnGAQ/yLSbq/ju3y8YvjHSxvCHRdNLcq6e5J/BV39AoSQl19Nr7sBZdORj lPjUC1S3zTQUk7C5+DkoavkPMoW9BDxqJZkFjlwzYRSgnykaNTju6y+RvElDCzEXO63T8IPrPQwvG gjzDSaARHIWmMMBhf+x/6u9gHjKWsfjuFOa9gR9YWtz/PbXgu1ZtZdtEW5pzw/pNgadyPyl8kYpHn 44fnLl9rspuKjwqjD5gRjNDCXm/S54rV+udKZdO8qifebaTMLljt/JKvc5hLucBUIFwLknsMCBEKo tdMe7lJfQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZa1e-00GqvW-Ee; Thu, 22 Apr 2021 14:09:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZa1a-00GqvI-HC for linux-arm-kernel@desiato.infradead.org; Thu, 22 Apr 2021 14:09:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6vtsHCiE+UhV1jEh9jWHoCYucvxbpDiXX+TJ66u1Jlw=; b=D2oo0vjmyP82V2rVbeWbkOh2gz 1y7Y6gSxqxgcV2GK5dUMjkbfbrumOJFycQxquHfpwfarVbafZ0oEWk6FUdCBcb+ia24G98nEAbjhJ TNAOH51W07FQ5GtCgtYO1D3sEPC/NWeGVjjucSykNTR3IbNOh/yhCBmUbzarfU9B8s1MDHt3YcRKv s9DjpJChjZ86/aUyeY/7oRAB+Uzhes7sGdoduJAZexgjP1A1Wm5orrGCxRBj24qKDCLArdrd94fNB ThSn9QihVxKmq2F8ZkB5wbhmkqS97wxSGKR0P70dMNHTjTCMOQ6MTPsJYYGOhpxT1e+jF88sjAxZE DFKzN6Bg==; Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZa1X-00DkFy-8i for linux-arm-kernel@lists.infradead.org; Thu, 22 Apr 2021 14:09:44 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13ME9adJ069314; Thu, 22 Apr 2021 09:09:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1619100576; bh=6vtsHCiE+UhV1jEh9jWHoCYucvxbpDiXX+TJ66u1Jlw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=pyNONRIlt5oHfMqBuBKAkQ29DULpNbQCNhTh5l6Bbktxc5jyvHnYznc76EqUnUt1T goQ/IclTyHw7XZWoFargojo9GgxnTkm4GMVQmmGdZnOxf/Bt39GWBCuBeGUhYPmVy8 Jh+0k6ijf7TmWSxqOxjtcBdK2gfeDJ6Urliw2WBo= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13ME9ZXA053552 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Apr 2021 09:09:36 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 22 Apr 2021 09:09:35 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Thu, 22 Apr 2021 09:09:35 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13ME9ZwN033089; Thu, 22 Apr 2021 09:09:35 -0500 Date: Thu, 22 Apr 2021 09:09:35 -0500 From: Nishanth Menon To: Rob Herring CC: Stephen Boyd , Michael Turquette , Philipp Zabel , Santosh Shilimkar , Tero Kristo , , , , Subject: Re: [PATCH 2/4] dt-bindings: clock: Convert ti, sci-clk to json schema Message-ID: <20210422140935.lzsp6s2ugyvi2icu@iodize> References: <20210416063721.20538-1-nm@ti.com> <20210416063721.20538-3-nm@ti.com> <161861731160.46595.786611690053722257@swboyd.mtv.corp.google.com> <20210417125127.vigq23mdoodje6b5@velcro> <20210421223145.GB1705110@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210421223145.GB1705110@robh.at.kernel.org> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210422_070943_455593_73912AA3 X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17:31-20210421, Rob Herring wrote: [...] > > > > +allOf: > > > > + - $ref: /schemas/clock/clock.yaml# > > > > > > Is this needed? > > No. It is already applied to every node. > > > https://github.com/devicetree-org/dt-schema/blob/master/schemas/clock/clock.yaml > > This standardizes provider properties like '#clock-cells' etc, allowing > > you to add more stricter checks or controls in the future if necessary. > > > > while: > > > > https://github.com/devicetree-org/dt-schema/blob/master/meta-schemas/clocks.yaml > > is more a consumer node description. > > No, the meta-schema is what checks the schemas just as the schemas check > dts files. I will drop and respin. thanks for explaining. > > > Should I have picked a different yaml as base for a standard clock-controller > > base? > > > > > > > > > + > > > > +description: | > > > > + Some TI SoCs contain a system controller (like the Power Management Micro > > > > + Controller (PMMC) on Keystone 66AK2G SoC) that are responsible for controlling > > > > + the state of the various hardware modules present on the SoC. Communication > > > > + between the host processor running an OS and the system controller happens > > > > + through a protocol called TI System Control Interface (TI-SCI protocol). > > > > + > > > > + This clock controller node uses the TI SCI protocol to perform various clock > > > > + management of various hardware modules (devices) present on the SoC. This > > > > + node must be a child node of the associated TI-SCI system controller node. > > > > + > > > > +properties: > > > > + $nodename: > > > > + pattern: "^clock-controller$" > > > > > > Is this nodename pattern check required? > > > > I'd like the definition on rails and not subject to interpretation, and > > restrict the kind of subnodes under TISCI controller node. > > If this schema was standalone and not defined as part of another, then > yes it would be required. In your case, you can enforce the node name > from the parent schema. For consistency though, it would be better to > just always require $nodename. > > Actually, this schema will be applied twice. On it's own matching the > compatible string and by the parent schema. You can prevent that with > 'select: false'. I don't mind the double validation as if the parent > node had a compatible typo you'd get zero validation. Sure. I will keep nodename. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel