From: kernel test robot <lkp@intel.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org,
linuxarm@huawei.com, mauro.chehab@huawei.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Maxime Ripard <mripard@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 76/78] media: sun4i_v4l2: use pm_runtime_resume_and_get()
Date: Sat, 24 Apr 2021 18:21:23 +0800 [thread overview]
Message-ID: <202104241847.RVMtbDKs-lkp@intel.com> (raw)
In-Reply-To: <19ff6114784154d1ce289b01bd22230a37b77a98.1619191723.git.mchehab+huawei@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 4732 bytes --]
Hi Mauro,
I love your patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20210423]
[cannot apply to rockchip/for-next tegra/for-next v5.12-rc8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-use-pm_runtime_resume_and_get-instead-of-pm_runtime_get_sync/20210424-145029
base: git://linuxtv.org/media_tree.git master
config: nios2-randconfig-s031-20210424 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/ddf22a45db8814ab855d3535a125e17f5e58f94b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mauro-Carvalho-Chehab/media-use-pm_runtime_resume_and_get-instead-of-pm_runtime_get_sync/20210424-145029
git checkout ddf22a45db8814ab855d3535a125e17f5e58f94b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c: In function 'sun4i_csi_open':
>> drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:215:3: error: label 'err_pm_put' used but not defined
215 | goto err_pm_put;
| ^~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SERIAL_CORE_CONSOLE
Depends on TTY && HAS_IOMEM
Selected by
- EARLY_PRINTK
vim +/err_pm_put +215 drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c
577bbf23b758848 Maxime Ripard 2019-08-22 199
577bbf23b758848 Maxime Ripard 2019-08-22 200 static int sun4i_csi_open(struct file *file)
577bbf23b758848 Maxime Ripard 2019-08-22 201 {
577bbf23b758848 Maxime Ripard 2019-08-22 202 struct sun4i_csi *csi = video_drvdata(file);
577bbf23b758848 Maxime Ripard 2019-08-22 203 int ret;
577bbf23b758848 Maxime Ripard 2019-08-22 204
577bbf23b758848 Maxime Ripard 2019-08-22 205 ret = mutex_lock_interruptible(&csi->lock);
577bbf23b758848 Maxime Ripard 2019-08-22 206 if (ret)
577bbf23b758848 Maxime Ripard 2019-08-22 207 return ret;
577bbf23b758848 Maxime Ripard 2019-08-22 208
ddf22a45db8814a Mauro Carvalho Chehab 2021-04-24 209 ret = pm_runtime_resume_and_get(csi->dev);
577bbf23b758848 Maxime Ripard 2019-08-22 210 if (ret < 0)
ddf22a45db8814a Mauro Carvalho Chehab 2021-04-24 211 goto err_unlock;
577bbf23b758848 Maxime Ripard 2019-08-22 212
8fd390b89cc8ca7 Ezequiel Garcia 2020-01-24 213 ret = v4l2_pipeline_pm_get(&csi->vdev.entity);
577bbf23b758848 Maxime Ripard 2019-08-22 214 if (ret)
577bbf23b758848 Maxime Ripard 2019-08-22 @215 goto err_pm_put;
577bbf23b758848 Maxime Ripard 2019-08-22 216
577bbf23b758848 Maxime Ripard 2019-08-22 217 ret = v4l2_fh_open(file);
577bbf23b758848 Maxime Ripard 2019-08-22 218 if (ret)
577bbf23b758848 Maxime Ripard 2019-08-22 219 goto err_pipeline_pm_put;
577bbf23b758848 Maxime Ripard 2019-08-22 220
577bbf23b758848 Maxime Ripard 2019-08-22 221 mutex_unlock(&csi->lock);
577bbf23b758848 Maxime Ripard 2019-08-22 222
577bbf23b758848 Maxime Ripard 2019-08-22 223 return 0;
577bbf23b758848 Maxime Ripard 2019-08-22 224
577bbf23b758848 Maxime Ripard 2019-08-22 225 err_pipeline_pm_put:
8fd390b89cc8ca7 Ezequiel Garcia 2020-01-24 226 v4l2_pipeline_pm_put(&csi->vdev.entity);
577bbf23b758848 Maxime Ripard 2019-08-22 227
ddf22a45db8814a Mauro Carvalho Chehab 2021-04-24 228 err_unlock:
577bbf23b758848 Maxime Ripard 2019-08-22 229 mutex_unlock(&csi->lock);
577bbf23b758848 Maxime Ripard 2019-08-22 230
577bbf23b758848 Maxime Ripard 2019-08-22 231 return ret;
577bbf23b758848 Maxime Ripard 2019-08-22 232 }
577bbf23b758848 Maxime Ripard 2019-08-22 233
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34795 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-04-24 10:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1619191723.git.mchehab+huawei@kernel.org>
2021-04-24 6:44 ` [PATCH 01/78] media: atmel: properly get pm_runtime Mauro Carvalho Chehab
2021-04-24 9:36 ` kernel test robot
2021-04-24 6:44 ` [PATCH 03/78] media: mdk-mdp: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-04-24 6:44 ` [PATCH 05/78] " Mauro Carvalho Chehab
2021-04-24 18:23 ` Ezequiel Garcia
2021-04-24 6:44 ` [PATCH 14/78] staging: media: imx7-mipi-csis: use pm_runtime_resume_and_get() Mauro Carvalho Chehab
2021-04-26 10:11 ` Rui Miguel Silva
2021-04-24 6:44 ` [PATCH 16/78] staging: media: cedrus_video: " Mauro Carvalho Chehab
2021-04-24 6:44 ` [PATCH 20/78] media: mtk-vcodec: fix pm_runtime_get_sync() usage count Mauro Carvalho Chehab
2021-04-24 6:44 ` [PATCH 21/78] media: s5p-jpeg: " Mauro Carvalho Chehab
2021-04-27 9:14 ` Sylwester Nawrocki
2021-04-24 6:44 ` [PATCH 23/78] media: sun8i_rotate: " Mauro Carvalho Chehab
2021-04-24 6:45 ` [PATCH 57/78] media: exynos4-is: use pm_runtime_resume_and_get() Mauro Carvalho Chehab
2021-04-25 20:57 ` Sylwester Nawrocki
2021-04-26 13:12 ` Mauro Carvalho Chehab
2021-04-27 8:06 ` Sylwester Nawrocki
2021-04-24 6:45 ` [PATCH 58/78] media: exynos-gsc: " Mauro Carvalho Chehab
2021-04-27 8:18 ` Sylwester Nawrocki
2021-04-27 9:30 ` Mauro Carvalho Chehab
2021-04-27 9:42 ` Mauro Carvalho Chehab
2021-04-27 11:50 ` Sylwester Nawrocki
2021-04-28 7:13 ` Mauro Carvalho Chehab
2021-04-28 7:17 ` Mauro Carvalho Chehab
2021-04-28 8:27 ` Sylwester Nawrocki
2021-04-24 6:45 ` [PATCH 59/78] media: mtk-jpeg: " Mauro Carvalho Chehab
2021-04-24 6:45 ` [PATCH 70/78] media: rga-buf: " Mauro Carvalho Chehab
2021-04-28 17:09 ` Ezequiel Garcia
2021-04-24 6:45 ` [PATCH 71/78] media: rkisp1-capture: " Mauro Carvalho Chehab
2021-04-24 6:45 ` [PATCH 73/78] media: s5p-mfc: " Mauro Carvalho Chehab
2021-04-27 9:36 ` Sylwester Nawrocki
2021-04-24 6:45 ` [PATCH 75/78] media: stm32: " Mauro Carvalho Chehab
2021-04-24 6:45 ` [PATCH 76/78] media: sun4i_v4l2: " Mauro Carvalho Chehab
2021-04-24 10:21 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104241847.RVMtbDKs-lkp@intel.com \
--to=lkp@intel.com \
--cc=jernej.skrabec@siol.net \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).