From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331F5C433ED for ; Sun, 25 Apr 2021 20:23:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAFEF61078 for ; Sun, 25 Apr 2021 20:23:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAFEF61078 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qAHt8dYWlPFsGFqExgBo8zsUytHmumkJPUtlBQHqD7c=; b=ieIdOEK/FLJJf5+UQfd9UGc8T dz6ohKKMGub9W4zAC4z8E2Kx7F53M0AEPjn5p03l0yssRRISI4yTtVVjCBtSy1cQ4O3mXUYj3QIeW 0+afzFRJr5TIzJwke8pp0/Ns4/Dmg+ja8Q4BcSVO6oCEnZd7HS/0Gd1cOgFxaKv0EVnbyazlXvv0U aoCkeTAIMiNKPwv0NxWGQTqDO+R0En+7QhoQ62XfjCyVkbsejt3nARyVv9YUZaZHF1bUMZSNaX6MM 38wAMUti+2UqPjViqrM4dnNpFZK4dE5ujoo3Efsy8CO+4jARcuefcIUSGg1fybhorCP3ZlD8NhCIe gL5csjRPQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lalFe-006DkG-I8; Sun, 25 Apr 2021 20:21:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lalED-006DgP-GA for linux-arm-kernel@desiato.infradead.org; Sun, 25 Apr 2021 20:19:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KAr07bi0O60q1iMUjn3V9pv6meBilgySRRx71qE3mFM=; b=k8e8W9bNzTaiiOw7zSXqIy1wpT rZLbyzyfvvB9rVgs4+8SaRFurC/EAUpt+uWb6mR+qiJDGYvZuME24VwKe68cFT7a1J9gijHJHt+N5 naCAGyHzmjn3InLXRYCLtrzW6C9t3febZSd2VCYI87vAe5T4dhdrVpNquqxgP9BT0BSfAIV6LHD31 qfRygPU0NjM5DgZUgJljJyNjdxxSgp39qlIaPFc3+t4KCbf59bRKRQtHFoyZdR3bjn97gySZ7XhG/ kGlxr3xYSuwHdzT08kXwao0UwirpbiMXbtxrOlN1EXr0HDHMPA9MY/D7y+3WN0kj0paV8JJkNRM7p N+3gikxA==; Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lalEA-00FaC8-EM for linux-arm-kernel@lists.infradead.org; Sun, 25 Apr 2021 20:19:40 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id CD4311C0B76; Sun, 25 Apr 2021 22:19:29 +0200 (CEST) Date: Sun, 25 Apr 2021 22:19:28 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado , Dan Murphy , Bjorn Andersson , Andy Gross , Rob Herring , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Brian Masney , Luca Weiss , Russell King , Georgi Djakov , linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, lkcamp@lists.libreplanetbr.org, andrealmeid@collabora.com Subject: Re: [PATCH v2 2/4] leds: Add driver for QCOM SPMI Flash LEDs Message-ID: <20210425201928.GA10996@amd> References: <20210126140240.1517044-1-nfraprado@protonmail.com> <20210126140240.1517044-3-nfraprado@protonmail.com> <20210219110227.GG19207@duo.ucw.cz> <7bb757c7-55af-66a4-aa12-fe646a19fcf6@gmail.com> MIME-Version: 1.0 In-Reply-To: <7bb757c7-55af-66a4-aa12-fe646a19fcf6@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210425_131938_659672_83C8CE8A X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6506713870028627700==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6506713870028627700== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2fHTh5uZTiUOsy+g" Content-Disposition: inline --2fHTh5uZTiUOsy+g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >>>+#include > >> > >>Please sort includes alphabetically. > > > >No need to do that. >=20 > Keeping the includes sorted eliminates the risk of introducing duplicates > and allows for faster lookup. >=20 > What gain is in having them unsorted? It is not there is gain in them unsorted; it is that keeping sorted order is not worth the effort. > >>>+#define FLASH_SAFETY_TIMER 0x40 > >> > >>Namespacing prefix is needed for macros, e.g. QCOM_FLASH*. > > > >No need for that in .c files. >=20 > In general it eliminates the risk of name clash with other subsystems > headers. >=20 > And actually the prefix here should be QCOM_LED_FLASH to avoid ambiguity > with flash memory. If you dropped the vendor prefix then you'd get > possible name clash with led-class-flash.h namespace prefix. I believe the cost (longer macro names) outweights the benefits here. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --2fHTh5uZTiUOsy+g Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmCFztAACgkQMOfwapXb+vKsAQCgwoITptPZoLauNTG8eGPnXx4k axkAnAlN7nrSYyNTLk7gonKmd2sqzFrb =QgY3 -----END PGP SIGNATURE----- --2fHTh5uZTiUOsy+g-- --===============6506713870028627700== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6506713870028627700==--