From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71362C433ED for ; Mon, 26 Apr 2021 22:37:14 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E50EC600D1 for ; Mon, 26 Apr 2021 22:37:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E50EC600D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6r5zRQRKF5A75SM/VvszNZXP6PyQ7j8LgB2Z8gHc2oM=; b=kMovAzXFU9Cs+2P6mBQK5RflE RrxAnQt4zLuMAPRkkajAR184bQXmPJxOmmccMJQLc1P3E22xd6sodabbs8oOLMnSxvM4jLw9Vm6jq rSEPvJsW9zjc/NKJ2GBOE2jEdetBJTjsK9NR+vmpM5LEOmXfZuyXPtAnJS1dPXebfChG9JhCG/vjN cBDqWpngjOYyN90tpm2n/oxCPk7feHy1C3YgiBFD8r6juCpdcBAExzg6dbTIiMyfDl+88TrLn4Fdg rhnhEHS70uOufJMQM6EDu/Wya+AJ9APOl04wa4RXZ1Bj/NVqAJJTCIshOAOoltB8bfnS+vJ3n3lvp G+qgpMPUg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lb9ox-0007Vo-FZ; Mon, 26 Apr 2021 22:35:15 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb9or-0007Vb-PP for linux-arm-kernel@desiato.infradead.org; Mon, 26 Apr 2021 22:35:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+iJyBBSPfCcKyhQ6UKupYto0YDSU9yW3Bmhan41SDPU=; b=y7wmt/bYY3kZq/fcXYF8BM64GJ 1pakUCjtp3+pGQAtRVjrB1fSErfYMw+QFnJNYYlPf5mKlZ9qadumeqSpB7rSSpoHKD+OV+wZKsqff ZvZtTZZ24kng0ylxQ8svjI4SGjU0ZH2qKUtARkb1J4rB6i1XjRIoxdrD7D36HI57cXp7RYiLHw9vS NGFu3qmX8qQX0nsft6EVrEGPzlgkJ8F52ba8EGtoF1Lx7d56v0fs109M3R8i9EzYKFwAXTh51p/1o Rz3QUf5ZnYQWCIkqAt/TIa4fc564rngcNcM6ewzpM2aKmB/bI2soSCXc35/28k/mQbxcdEnNLa75T BJN0zl0A==; Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lb9om-00GH04-SJ for linux-arm-kernel@lists.infradead.org; Mon, 26 Apr 2021 22:35:06 +0000 IronPort-SDR: M4tCHnBn0h7eLpaOihrqFhRa02e3Az5oDjFF687GZ3KNkWof8iStFAT/o6dHSd/ITFTCOdERPt e5UtxPtiGsDg== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="196525712" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="196525712" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 15:35:00 -0700 IronPort-SDR: glz5M3bhXJfAfhYfOLxT+2LJtg7bRd8Vznq38dITWWUlvVHfw0xPX9Vbt17Lk4Z2SHtlPJiHGV BFQFKWUxVa1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="615500898" Received: from lkp-server01.sh.intel.com (HELO a48ff7ddd223) ([10.239.97.150]) by fmsmga006.fm.intel.com with ESMTP; 26 Apr 2021 15:34:56 -0700 Received: from kbuild by a48ff7ddd223 with local (Exim 4.92) (envelope-from ) id 1lb9od-00068S-Jk; Mon, 26 Apr 2021 22:34:55 +0000 Date: Tue, 27 Apr 2021 06:33:57 +0800 From: kernel test robot To: Sean Christopherson Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org, Robert Hu , Farrah Chen , Danmei Wei , Paolo Bonzini , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Subject: [PATCH] KVM: arm64: fix boolreturn.cocci warnings Message-ID: <20210426223357.GA45871@cd4295a34ed8> References: <202104270655.gBGhIPdZ-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202104270655.gBGhIPdZ-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_153504_988073_D2D70656 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: kernel test robot arch/arm64/kvm/mmu.c:1114:9-10: WARNING: return of 0/1 in function 'kvm_age_gfn' with return type bool arch/arm64/kvm/mmu.c:1084:9-10: WARNING: return of 0/1 in function 'kvm_set_spte_gfn' with return type bool arch/arm64/kvm/mmu.c:1127:9-10: WARNING: return of 0/1 in function 'kvm_test_age_gfn' with return type bool arch/arm64/kvm/mmu.c:1070:9-10: WARNING: return of 0/1 in function 'kvm_unmap_gfn_range' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: cd4c71835228 ("KVM: arm64: Convert to the gfn-based MMU notifier callbacks") CC: Sean Christopherson Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue head: 9f242010c3b46e63bc62f08fff42cef992d3801b commit: cd4c7183522817087278b3e000b8a888f9f91b5c [134/252] KVM: arm64: Convert to the gfn-based MMU notifier callbacks mmu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/arch/arm64/kvm/mmu.c +++ b/arch/arm64/kvm/mmu.c @@ -1067,13 +1067,13 @@ out_unlock: bool kvm_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range) { if (!kvm->arch.mmu.pgt) - return 0; + return false; __unmap_stage2_range(&kvm->arch.mmu, range->start << PAGE_SHIFT, (range->end - range->start) << PAGE_SHIFT, range->may_block); - return 0; + return false; } bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) @@ -1081,7 +1081,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, s kvm_pfn_t pfn = pte_pfn(range->pte); if (!kvm->arch.mmu.pgt) - return 0; + return false; WARN_ON(range->end - range->start != 1); @@ -1101,7 +1101,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, s PAGE_SIZE, __pfn_to_phys(pfn), KVM_PGTABLE_PROT_R, NULL); - return 0; + return false; } bool kvm_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range) @@ -1111,7 +1111,7 @@ bool kvm_age_gfn(struct kvm *kvm, struct pte_t pte; if (!kvm->arch.mmu.pgt) - return 0; + return false; WARN_ON(size != PAGE_SIZE && size != PMD_SIZE && size != PUD_SIZE); @@ -1124,7 +1124,7 @@ bool kvm_age_gfn(struct kvm *kvm, struct bool kvm_test_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range) { if (!kvm->arch.mmu.pgt) - return 0; + return false; return kvm_pgtable_stage2_is_young(kvm->arch.mmu.pgt, range->start << PAGE_SHIFT); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel