From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4E1C433ED for ; Tue, 27 Apr 2021 06:38:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AE776109E for ; Tue, 27 Apr 2021 06:38:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AE776109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nNhfEDx67ccCrvMFRojZPNezEfcNHpzwvdnV14EjN9Q=; b=KZX1JEchFScs9Uab6ljMoGdpz 8mQspGb1XxqmI58KZggzALJNGBYemcE5Tte5oOso/mW+sSjgGRaPtRg+Y2p7K2gb8hPZsAF076XM/ 5VU+ponmfXyOby/8iMWz70FOORN3MchGh8jWTwJ1JZ9JVmqKY2ZHOpIrTbQIJNiC+I2pJuIw2bL61 CO8Uo9MEBjVuZ+uvA9T5liQz+TDsd5H/yBbDNw1KPk/yHp6HNABPuQ2IUe3UlFP0dkUMF7AqvfySR deRAhFu/LKt1hXicfcmHMBOK/LpXvdsFnnlXAmZ020Pw207ROLGUdW3YGBMGG2a5httFhFwI9dbTE w9Dd+xYbg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbHKU-000sDr-NZ; Tue, 27 Apr 2021 06:36:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbHKS-000sDh-Nh for linux-arm-kernel@desiato.infradead.org; Tue, 27 Apr 2021 06:36:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SXUbd5xh5KKrYXmMS+xUTYTz65FzCDBvgSUvYsX7LuY=; b=ti6firmkV/vc1SSlC3U1/DPujZ TSZZwVzbLiSSv/sxedwGjYmPXafK8pC4tbNaeSjfdIeLnR/ml7D30veR9y7B4YRFVGWR3x5td2E+x exn9f5lDoUQxyR6VsteTTdiHHXdOIMPfOEsBOwiXdZU+VNRjXG2foxeTgafX5QD8cQoVGYM0IPPgV lHlik8wBVUHO1b9afFU6pbVITlsB8wvUC6t5iP2BAYu/21TNIJ+dhNmw+BdpqPVnjjQS9Tqwqko7B lAguqWuhu+0oYaggvluCkDmEsemCHogbwn6TnVH+p9RxHRnIM1tG9eHajuHc7HEmEVJi9lSRSRx2y i2ylo+5g==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbHKP-00GTfd-KD for linux-arm-kernel@lists.infradead.org; Tue, 27 Apr 2021 06:36:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C640431B; Mon, 26 Apr 2021 23:36:07 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E738F3F70D; Mon, 26 Apr 2021 23:36:06 -0700 (PDT) Date: Tue, 27 Apr 2021 07:36:04 +0100 From: Cristian Marussi To: Wan Jiabing Cc: Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] firmware: arm_scmi: Remove repeated struct declaration Message-ID: <20210427063604.GH43717@e120937-lin> References: <20210427033031.4580-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210427033031.4580-1-wanjiabing@vivo.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210426_233613_736487_E81D5C21 X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Apr 27, 2021 at 11:30:31AM +0800, Wan Jiabing wrote: > struct scmi_protocol_handle is declared at 34th line. > The declaration here is duplicate. Remove it. > You're right. Reviewed-by: Cristian Marussi Thanks, Cristian > Signed-off-by: Wan Jiabing > --- > drivers/firmware/arm_scmi/notify.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/notify.h b/drivers/firmware/arm_scmi/notify.h > index ce0324be6c71..4e9b627edfef 100644 > --- a/drivers/firmware/arm_scmi/notify.h > +++ b/drivers/firmware/arm_scmi/notify.h > @@ -79,8 +79,6 @@ struct scmi_protocol_events { > > int scmi_notification_init(struct scmi_handle *handle); > void scmi_notification_exit(struct scmi_handle *handle); > - > -struct scmi_protocol_handle; > int scmi_register_protocol_events(const struct scmi_handle *handle, u8 proto_id, > const struct scmi_protocol_handle *ph, > const struct scmi_protocol_events *ee); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel