From: Leo Yan <leo.yan@linaro.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Miroslav Benes <mbenes@suse.cz>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH] arm64: stacktrace: Stop unwinding when the PC is zero
Date: Thu, 29 Apr 2021 09:43:21 +0800 [thread overview]
Message-ID: <20210429014321.196606-1-leo.yan@linaro.org> (raw)
When use ftrace for stack trace, it reports the spurious frame with the
PC value is zero. This can be reproduced with commands:
# cd /sys/kernel/debug/tracing/
# echo "prev_pid == 0" > events/sched/sched_switch/filter
# echo stacktrace > events/sched/sched_switch/trigger
# echo 1 > events/sched/sched_switch/enable
# cat trace
<idle>-0 [005] d..2 259.621390: sched_switch: ...
<idle>-0 [005] d..3 259.621394: <stack trace>
=> __schedule
=> schedule_idle
=> do_idle
=> cpu_startup_entry
=> secondary_start_kernel
=> 0
The kernel initializes FP/PC values as zero for swapper threads in
head.S, when walk the stack frame, this patch stops unwinding if detect
the PC value is zero, therefore can avoid the spurious frame.
Below is the stacktrace after applying the change:
# cat trace
<idle>-0 [005] d..2 259.621390: sched_switch: ...
<idle>-0 [005] d..3 259.621394: <stack trace>
=> __schedule
=> schedule_idle
=> do_idle
=> cpu_startup_entry
=> secondary_start_kernel
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
arch/arm64/kernel/stacktrace.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
index 84b676bcf867..02b1e85b2026 100644
--- a/arch/arm64/kernel/stacktrace.c
+++ b/arch/arm64/kernel/stacktrace.c
@@ -145,7 +145,11 @@ void notrace walk_stackframe(struct task_struct *tsk, struct stackframe *frame,
if (!fn(data, frame->pc))
break;
ret = unwind_frame(tsk, frame);
- if (ret < 0)
+ /*
+ * When the frame->pc is zero, it has reached to the initial pc
+ * and fp values; stop unwinding for this case.
+ */
+ if (ret < 0 || !frame->pc)
break;
}
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2021-04-29 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 1:43 Leo Yan [this message]
2021-04-29 10:48 ` [PATCH] arm64: stacktrace: Stop unwinding when the PC is zero Mark Rutland
2021-04-29 12:26 ` Leo Yan
2021-04-30 17:32 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429014321.196606-1-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbenes@suse.cz \
--cc=mhiramat@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).