From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7713AC433ED for ; Thu, 29 Apr 2021 12:34:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20261613F2 for ; Thu, 29 Apr 2021 12:34:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20261613F2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MpJMd3WYgBaVzIQLBbZVsr8bioCS98kBzr2WV3TJ2jA=; b=Ky6lnTdTd8kvFALZo1qa00kk+ PWhaKyEsqAw67fvk95u58hPkhgT7DOQZhaVbDOAyPSOEzh9Yhu+l5Z+pid67kxeiaaw29CWbjwHzI bjMo/xhrD+PYGWgA7XxokYav68dAIlx3C3wlN4ObZA2j9bTO12vmTHvdEsRdze9Ya1gfBu5UUyFfi 8xktYkdPW9cILjisbGTcOa6kKqOSvZ8RZQmxgzvzRaU5jLvzcOGGkcvseCeiLfJWLzY0p0ohUNSbX QFqvniDhVmZvGbkZTSQGmThx2vdwL2rUrZA7i0giettkC1tDxfiJtjL+bZ0kqAqN23Twp+UBg4Brc L3z16qtDw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc5qi-005dR0-AS; Thu, 29 Apr 2021 12:32:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc5qd-005dQg-TG for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 12:32:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SL2GxxV9T1styuAAfm7R1vru70r9oDnEomIFYylFzE4=; b=u/bSoGPKfDXAoegnxCktEGDm5n u2WK2UBNeaV6Hj22ihuXQCpY4N2B5EG9oShFU0Bc7rIO6pMrRp3vTHCCD9KFCWmmlGFhojDCTBW3f tkWt549t+LxgP32rmvj3qfAtqMK/WO1W9NqbqEo8AfRN3YpSs31/3NFzq3X+zyYJiJu+MnvbHo/K3 lUWlHLOn/4eYLsCQ4VevwxzzfJU0SFrqFZ8rqf+M+nMS9kN/VaIKjcVl/kokG+eHsVBQLjXO/9cVy 4YNyTkqiWBjlWh3HZCnZToD/6Qb1XHSW7GP4AKuAX36lSmr6I1qlXldKZ6uivTh5evmRIEl+yWxDC ArABDy9Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc5qb-000crm-54 for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 12:32:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 50F8A613F2; Thu, 29 Apr 2021 12:32:46 +0000 (UTC) Date: Thu, 29 Apr 2021 13:32:43 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: Generate cpucaps.h Message-ID: <20210429123243.GA15092@arm.com> References: <20210428121231.11219-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210428121231.11219-1-broonie@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_053249_250348_0F8F22DA X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 28, 2021 at 01:12:31PM +0100, Mark Brown wrote: > The arm64 code allocates an internal constant to every CPU feature it can > detect, distinct from the public hwcap numbers we use to expose some > features to userspace. Currently this is maintained manually which is an > irritating source of conflicts when working on new features, to avoid this > replace the header with a simple text file listing the names we've assigned > and sort it to minimise conflicts. > > As part of doing this we also do the Kbuild hookup required to hook up > an arch tools directory and to generate header files in there. > > This will result in a renumbering and reordering of the existing constants, > since they are all internal only the values should not be important. The > reordering will impact the order in which some steps in enumeration handle > features but the algorithm is not intended to depend on this and I haven't > seen any issues when testing. Due to the UAO cpucap having been removed in > the past we end up with ARM64_NCAPS being 1 smaller than it was before. > > Signed-off-by: Mark Brown > --- > arch/arm64/Makefile | 3 ++ > arch/arm64/include/asm/Kbuild | 2 + > arch/arm64/include/asm/cpucaps.h | 74 -------------------------------- > arch/arm64/tools/Makefile | 22 ++++++++++ > arch/arm64/tools/cpucaps | 65 ++++++++++++++++++++++++++++ > arch/arm64/tools/gen-cpucaps.awk | 40 +++++++++++++++++ > 6 files changed, 132 insertions(+), 74 deletions(-) > delete mode 100644 arch/arm64/include/asm/cpucaps.h > create mode 100644 arch/arm64/tools/Makefile > create mode 100644 arch/arm64/tools/cpucaps > create mode 100755 arch/arm64/tools/gen-cpucaps.awk It's a good cleanup, it saves us from always sorting out conflicts around ARM64_NCAPS. I'll either take it during the merging window with the for-next/fixes folded in or push it at -rc1 as there's a change in cpucaps.h not currently in for-next/core. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel