From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B1FCC433ED for ; Fri, 30 Apr 2021 19:43:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C721761151 for ; Fri, 30 Apr 2021 19:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C721761151 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qM5WBwdF7KsB7kDh6PF/8dOIQ30gX+JNiobGuRICDWU=; b=CHLp5h7uOoND07JehKL2a8WHc gnQcFH4ZhzIUYFwrrwf0ytXgagqRIXQ50+WaZS3RDAI8wtehHxugC8wTJCBgb9MlcUxT0mz42G29D t3RGhPniugoogRrilUMg2Ez4jFu/pRwio1VfTPDAMZe27MUhqUQhUBzT8MuSZfncB07l00JwC6hS/ 2YulN4yfuS5IaAOajLS4ARpPSjJyiIB6teZTTrfQuzEucuYJCrcJhv01AufwgALXIRGFYeZ4vBJCK y7yok4yx+sDeAecCsCFthQTcdxzktGQtKyZR/B+lBjNEGcFt2GQPMn/OipFQfZs17ArDw5lojJHGH xTdEUpF1w==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lcYzl-008RJ0-4a; Fri, 30 Apr 2021 19:40:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcYzf-008RIU-BI for linux-arm-kernel@desiato.infradead.org; Fri, 30 Apr 2021 19:40:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oRTCLLrLVLX1YzXLCpau0W/3eis7qio3LTfXUrFMGeA=; b=FbtC+3kkC3njMmAXMHqkqgY0Kz ew1Bh2Jp4kkfDXBV0RtZ0pLDSl+kgdrthEgUnRsTYYl+ZVoqgASYQpYv+TWdgOCQGZVC/zpvRwPQw FcyqkmFIz5riuvwhcnmN/Yce/PfaVBdyTForKhuaBhDdaEuQDCk3IktYEfecUVpsyUNUYRqWMqch1 6nJf8Z5L9mLWPXURNObCCjoyptGfKEOvkVBeY2IY8ZVWrUZhJKFy20m+5gMpmKgqRg2rErvVebcVT apIPtVADiF1d1duTZeDS9lnjewHzxinv0CSwQizw9c9pwPP3IOpEqrHZ4UNxtfMiCZla5LhHfo3OK JogyHy8g==; Received: from mail-oi1-f173.google.com ([209.85.167.173]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcYzc-001cJg-C6 for linux-arm-kernel@lists.infradead.org; Fri, 30 Apr 2021 19:40:06 +0000 Received: by mail-oi1-f173.google.com with SMTP id l17so39757005oil.11 for ; Fri, 30 Apr 2021 12:40:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oRTCLLrLVLX1YzXLCpau0W/3eis7qio3LTfXUrFMGeA=; b=uE9Q8d5fjuf5LoAV7npdIxa49F4UAmsLUomx2PcYuvJctvz0x3k+8m5HLCy1yS8l8F uMvM4GTkge+4P6EGE0KjwdK1RRjlGe8r3EmvvfW6XGtABFHJMfAjjZ4zMMEKG26Soq45 7HH1YsAK1dQP9+HX9i75wzVtPAY9QLRz06stfQ4Lscli5cFgYD4Tu6OubbJVDFYppdDb CJEA6KdlhKFy6Z714QWj/EiK5Lyzln9IczMDA8O39TbxBikdstZ2EjaE4TaNc5lXQPxi U9cov/KI3/3XWRY9N9Us5qY3DFo30bsRet824Mdplb7xbw+kL3u3YfTNOLdXdnm6PN1X Mi9Q== X-Gm-Message-State: AOAM530yplRoe+N4HgABI2qnxolVEq0fQp4bl0PhjFSCjEBDpAxgBuK3 d249JxyNd8/ppGlg9JrQXw== X-Google-Smtp-Source: ABdhPJx6E2XvFlAmdZxj8E8iaeTBP64l5MeiyFxM/eFPrfNxlgKWgdl2oMxZphJvRjvi30v4ahnJig== X-Received: by 2002:aca:4056:: with SMTP id n83mr12485002oia.47.1619811603100; Fri, 30 Apr 2021 12:40:03 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t84sm983409oih.35.2021.04.30.12.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 12:40:02 -0700 (PDT) Received: (nullmailer pid 3752697 invoked by uid 1000); Fri, 30 Apr 2021 19:40:00 -0000 Date: Fri, 30 Apr 2021 14:40:00 -0500 From: Rob Herring To: Nava kishore Manne Cc: michal.simek@xilinx.com, mdf@kernel.org, trix@redhat.com, gregkh@linuxfoundation.org, arnd@arndb.de, rajan.vaja@xilinx.com, amit.sunil.dhamne@xilinx.com, manish.narani@xilinx.com, zou_wei@huawei.com, lakshmi.sai.krishna.potthuri@xilinx.com, iwamatsu@nigauri.org, wendy.liang@xilinx.com, linus.walleij@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, chinnikishore369@gmail.com, git@xilinx.com Subject: Re: [PATCH v4 1/4] dt-bindings: firmware: Add bindings for xilinx firmware Message-ID: <20210430194000.GA3742101@robh.at.kernel.org> References: <20210429140408.23194-1-nava.manne@xilinx.com> <20210429140408.23194-2-nava.manne@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210429140408.23194-2-nava.manne@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210430_124004_437679_679D54FA X-CRM114-Status: GOOD ( 23.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 29, 2021 at 07:34:05PM +0530, Nava kishore Manne wrote: > Add documentation to describe Xilinx firmware driver bindings. > Firmware driver provides an interface to firmware APIs. > Interface APIs can be used by any driver to communicate > to Platform Management Unit. > > Signed-off-by: Nava kishore Manne > --- > Changes for v4: > -Added new yaml file for xilinx firmware > as suggested by Rob. > > .../firmware/xilinx/xlnx,zynqmp-firmware.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml What about the old doc?: Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt > > diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml > new file mode 100644 > index 000000000000..4b97f005bed7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/xilinx/xlnx,zynqmp-firmware.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx firmware driver > + > +maintainers: > + - Nava kishore Manne > + > +description: > + The zynqmp-firmware node describes the interface to platform firmware. > + ZynqMP has an interface to communicate with secure firmware. Firmware > + driver provides an interface to firmware APIs. Interface APIs can be > + used by any driver to communicate to PMUFW(Platform Management Unit). > + These requests include clock management, pin control, device control, > + power management service, FPGA service and other platform management > + services. > + > +properties: > + compatible: > + oneOf: > + - description: > + For implementations complying for Zynq Ultrascale+ MPSoC. > + const: xlnx,zynqmp-firmware > + > + - description: > + For implementations complying for Versal. > + const: xlnx,versal-firmware > + > + method: > + description: The method of calling the PM-API firmware layer. > + # Permitted values are: > + # - "smc" : SMC #0, following the SMCCC > + # - "hvc" : HVC #0, following the SMCCC Drop the '#'. If you want to maintain the formatting, then use '|' after 'description:' for a literal block. > + $ref: /schemas/types.yaml#/definitions/string-array > + enum: > + - smc > + - hvc > + > +patternProperties: > + "fpga": So 'foofpgabar' is valid? > + description: Compatible of the FPGA device. > + type: object > + > + required: > + - compatible This belongs in the fpga schema which should have a $ref here. (Which means this patch needs to come 2nd.) > + > +required: > + - compatible > + > +examples: > + - | > + versal-firmware { > + compatible = "xlnx,versal-firmware"; > + method = "smc"; > + fpga { > + compatible = "xlnx,versal-fpga"; > + }; > + }; > + > +additionalProperties: false > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel