From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15289C433B4 for ; Mon, 3 May 2021 11:15:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66237611CB for ; Mon, 3 May 2021 11:15:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66237611CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HBtfjltXgiUf20ZAB2hUQuoh0+HEfUyaMChgX2IUjz0=; b=PxsJc50UTSVN0zksFiwyUGAAJ ciOaip0HNLh87pF3QMRGGuYSRcy/fUTEwn6NHvFrEUFs3yu8RG+xIj6ynQcvHmvK1nOYJE8wwOC6d jkSxV8WLM40TMwJ+zGnUyOdZ70VHXsvObP/ZmEDOn04kb91zXHWHUce2Y2M3zP1O1IAvImpf+T9aL UBHyYJ3MHn0Q042cLAu3TMmEWV5clAnlm/DRrpX4hzEwdL0Vk2f2VxnCh+W/Nh0djnshR5XzJ8KuT OruW6A6ZrHHhV6Qc4/GdJkhaZgjxFIdA2sfPKW3xSTCgR+Y5FyeNAr13dd+N5M8BEfZ8NXcquMJDd /Fnb7iNPg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldWTR-00DjG4-El; Mon, 03 May 2021 11:10:49 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldWSl-00DjDF-LP for linux-arm-kernel@desiato.infradead.org; Mon, 03 May 2021 11:10:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yoO4KUiA/XxZl65fPmyWtuPoD5hZoBaFfN5wIsNTJIc=; b=tXMCaWbmQqBAWu0vGasCVyaJQn +HxNUdq7K9uJ46D4ViI9zKBatk1q+hDuDlscVn36wLvAMe41okRynrp+mnpqfKpAXSm9SMv+q5hCl d1MccQYvw5JstoQcP/9WvCZpwYORBkj8ovgu4Ya4slH8j5nVxrk25RHT0ToBAxehyHZ91/c47G8sj gMSNUoCVy4ZwgYdrQwJwBICLNlW0zOyL7hq9JOX01qGpVY5flgNpz2YsQLdDjHK7fNP+XuZrDj2rE OKj6XUBRfLrEhMYfbbbgLGvVZ6Rjt7nbUlzcwjSQHz++7hF25sWhjHxLKNnm+0tMfTZK8rqngWo1o F9Y4e5zw==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldWSU-00EzBL-2G for linux-arm-kernel@lists.infradead.org; Mon, 03 May 2021 11:09:59 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 143AvKGk037658; Mon, 3 May 2021 18:57:20 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 3 May 2021 19:08:58 +0800 Date: Mon, 3 May 2021 19:08:50 +0800 From: Steven Lee To: Andrew Jeffery CC: Ulf Hansson , Rob Herring , Joel Stanley , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , Hongwei Zhang , Ryan Chen , Chin-Ting Kuo Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: sdhci-of-aspeed: Add description for AST2600 EVB. Message-ID: <20210503110850.GA2111@aspeedtech.com> References: <20210503014336.20256-1-steven_lee@aspeedtech.com> <20210503014336.20256-2-steven_lee@aspeedtech.com> <75226402-503c-4e9b-96dc-e4bd74cf20ac@www.fastmail.com> <20210503094054.GA12520@aspeedtech.com> <6678be60-d078-4eaa-8fef-37a60473f1cc@www.fastmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6678be60-d078-4eaa-8fef-37a60473f1cc@www.fastmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 143AvKGk037658 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210503_120957_205772_5154EFDC X-CRM114-Status: GOOD ( 36.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 05/03/2021 18:32, Andrew Jeffery wrote: > On Mon, 3 May 2021, at 19:10, Steven Lee wrote: > > The 05/03/2021 12:19, Andrew Jeffery wrote: > > > Hi Steven, > > > > > > On Mon, 3 May 2021, at 11:13, Steven Lee wrote: > > > > Add the description for describing the AST 2600 EVB reference design of > > > > GPIO regulators and provide the example in the document. > > > > > > > > AST2600-A2 EVB has the reference design for enabling SD bus > > > > power and toggling SD bus signal voltage by GPIO pins. > > > > > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to > > > > power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is > > > > connected to a 1.8v and a 3.3v power load switch that providing > > > > signal voltage to > > > > SD1 bus. > > > > > > > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > > > disabled. > > > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 > > > > signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > > > enabled, SD1 signal voltage becomes 1.8v. > > > > > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > > > GPIOV3 as power-switch-gpio. > > > > > > > > Signed-off-by: Steven Lee > > > > --- > > > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 99 +++++++++++++++++++ > > > > 1 file changed, 99 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > index 987b287f3bff..dd894aba0bb7 100644 > > > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > @@ -20,6 +20,19 @@ description: |+ > > > > the slots are dependent on the common configuration area, they are > > > > described > > > > as child nodes. > > > > > > > > + The signal voltage of SDHCIs on AST2600-A2 EVB is able to be toggled > > > > by GPIO > > > > + pins. In the reference design, GPIOV0 of AST2600-A2 EVB is connected > > > > to the > > > > + power load switch that providing 3.3v to SD1 bus vdd, GPIOV1 is > > > > connected to > > > > + a 1.8v and a 3.3v power load switch that providing signal voltage to > > > > + SD1 bus. > > > > + If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > > > + disabled. If GPIOV1 is active high, 3.3v power load switch is > > > > enabled, SD1 > > > > + signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > > > enabled, SD1 > > > > + signal voltage becomes 1.8v. > > > > + AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > > > + The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > > > GPIOV3 > > > > + as power-switch-gpio. > > > > > > I don't think we should be describing design-specific details in the > > > binding document. However, I think this would be a great comment in the > > > AST2600 EVB devicetree. Can you please move it there? > > > > > > > Ok, I will move it to the device tree. > > > > I was wondering if the following place is a good place to put the > > comment > > > > at line 534 of aspeed-g6.dtsi > > What you're describing is specific to the AST2600 EVB, so I suggest you > put it in the EVB dts, e.g. at: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/aspeed-ast2600-evb.dts#n103 > Got it! Thanks for the prompt reply. > > sdc: sdc@1e740000 { > > // Comment here... > > > > compatible = "aspeed,ast2600-sd-controller"; > > reg = <0x1e740000 0x100>; > > > > sdhci0: sdhci@1e740100 { > > compatible = "aspeed,ast2600-sdhci", "sdhci"; > > reg = <0x100 0x100>; > > interrupts = ; > > ... > > } > > > > > > + > > > > properties: > > > > compatible: > > > > enum: > > > > @@ -78,6 +91,7 @@ required: > > > > - clocks > > > > > > > > examples: > > > > + //Example 1 > > > > - | > > > > #include > > > > sdc@1e740000 { > > > > @@ -104,3 +118,88 @@ examples: > > > > clocks = <&syscon ASPEED_CLK_SDIO>; > > > > }; > > > > }; > > > > + > > > > + //Example 2 (AST2600EVB with GPIO regulator) > > > > > > I feel you didn't test this with `make dt_binding_check` as `//` isn't > > > a valid YAML comment token. You need to use `#` for comments ( > > > https://yaml.org/spec/1.2/spec.html#id2780069 ). > > > > > > > Sorry, I don't know that there is a binding check command for valiating > > YAML document. > > No worries! There's also `make dtbs_check` to validate the devicetree files > against the bindings. It's useful to run both, as usually when you're adding to > the binding you're modifying a devicetree as well. > Thanks, I will to these checks. > Unfortunately we need to do a bit of a cleanup of the Aspeed dts files, they > generate a number of warnings right now. > > > Regardless, thanks for the reference link. > > I will test with dt_binding_check. > > > > > > + - | > > > > + #include > > > > + #include > > > > + vcc_sdhci0: regulator-vcc-sdhci0 { > > > > + compatible = "regulator-fixed"; > > > > + > > > > + regulator-name = "SDHCI0 Vcc"; > > > > + regulator-min-microvolt = <3300000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + gpios = <&gpio0 ASPEED_GPIO(V, 0) > > > > + GPIO_ACTIVE_HIGH>; > > > > + enable-active-high; > > > > + }; > > > > + > > > > + vccq_sdhci0: regulator-vccq-sdhci0 { > > > > + compatible = "regulator-gpio"; > > > > + > > > > + regulator-name = "SDHCI0 VccQ"; > > > > + regulator-min-microvolt = <1800000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + gpios = <&gpio0 ASPEED_GPIO(V, 1) > > > > + GPIO_ACTIVE_HIGH>; > > > > + gpios-states = <1>; > > > > + states = <3300000 1 > > > > + 1800000 0>; > > > > + }; > > > > + > > > > + vcc_sdhci1: regulator-vcc-sdhci1 { > > > > + compatible = "regulator-fixed"; > > > > + > > > > + regulator-name = "SDHCI1 Vcc"; > > > > + regulator-min-microvolt = <3300000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + gpios = <&gpio0 ASPEED_GPIO(V, 2) > > > > + GPIO_ACTIVE_HIGH>; > > > > + enable-active-high; > > > > + }; > > > > + > > > > + vccq_sdhci1: regulator-vccq-sdhci1 { > > > > + compatible = "regulator-gpio"; > > > > + > > > > + regulator-name = "SDHCI1 VccQ"; > > > > + regulator-min-microvolt = <1800000>; > > > > + regulator-max-microvolt = <3300000>; > > > > + gpios = <&gpio0 ASPEED_GPIO(V, 3) > > > > + GPIO_ACTIVE_HIGH>; > > > > + gpios-states = <1>; > > > > + states = <3300000 1 > > > > + 1800000 0>; > > > > + }; > > > > + > > > > + sdc@1e740000 { > > > > + compatible = "aspeed,ast2600-sd-controller"; > > > > + reg = <0x1e740000 0x100>; > > > > + #address-cells = <1>; > > > > + #size-cells = <1>; > > > > + ranges = <0 0x1e740000 0x20000>; > > > > + clocks = <&syscon ASPEED_CLK_GATE_SDCLK>; > > > > + > > > > + sdhci0: sdhci@100 { > > > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > > > + reg = <0x100 0x100>; > > > > + interrupts = ; > > > > + sdhci,auto-cmd12; > > > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > > > + vmmc-supply = <&vcc_sdhci0>; > > > > + vqmmc-supply = <&vccq_sdhci0>; > > > > + sd-uhs-sdr104; > > > > + clk-phase-uhs-sdr104 = <180>, <180>; > > > > + }; > > > > + > > > > + sdhci1: sdhci@200 { > > > > + compatible = "aspeed,ast2600-sdhci", "sdhci"; > > > > + reg = <0x200 0x100>; > > > > + interrupts = ; > > > > + sdhci,auto-cmd12; > > > > + clocks = <&syscon ASPEED_CLK_SDIO>; > > > > + vmmc-supply = <&vcc_sdhci1>; > > > > + vqmmc-supply = <&vccq_sdhci1>; > > > > + sd-uhs-sdr104; > > > > + clk-phase-uhs-sdr104 = <0>, <0>; > > > > + }; > > > > + }; > > > > > > This is a good example, so can we keep this and just drop the comment > > > from the binding document? > > > > Ok, I will remove the comment. > > Thanks. > > Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel