From: Mark Rutland <mark.rutland@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: Correct the stated event stream frequency
Date: Wed, 5 May 2021 14:40:52 +0100 [thread overview]
Message-ID: <20210505134052.GA5605@C02TD0UTHF1T.local> (raw)
In-Reply-To: <20210505132845.23698-1-catalin.marinas@arm.com>
On Wed, May 05, 2021 at 02:28:45PM +0100, Catalin Marinas wrote:
> It should be 10KHz, matching the ARCH_TIMER_EVT_STREAM_PERIOD_US of
> 100us.
>
> Fixes: 611a7bc74ed2 ("arm64: docs: describe ELF hwcaps")
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
It might be worth being more explicit in the commit message, to make it
clear that this is just a documentation bug. e.g.
| In 2013 we introduced a (roughly) 10KHz event stream in commit:
|
| 037f637767a82907 ("drivers: clocksource: add support for ARM architected timer event stream")
|
| ... but in 2017 when we documented this in commit:
|
| 611a7bc74ed2dcba ("arm64: docs: describe ELF hwcaps")
|
| ... we erroneously stated that the frequency was roughly 100KHz.
|
| This patch corrects the documentation.
Either way:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> Documentation/arm64/elf_hwcaps.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/arm64/elf_hwcaps.rst b/Documentation/arm64/elf_hwcaps.rst
> index 87821662eeb2..ec1a5a63c1d0 100644
> --- a/Documentation/arm64/elf_hwcaps.rst
> +++ b/Documentation/arm64/elf_hwcaps.rst
> @@ -74,7 +74,7 @@ HWCAP_ASIMD
>
> HWCAP_EVTSTRM
> The generic timer is configured to generate events at a frequency of
> - approximately 100KHz.
> + approximately 10KHz.
>
> HWCAP_AES
> Functionality implied by ID_AA64ISAR0_EL1.AES == 0b0001.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-05 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 13:28 [PATCH] arm64: Correct the stated event stream frequency Catalin Marinas
2021-05-05 13:40 ` Mark Rutland [this message]
2021-05-05 17:42 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505134052.GA5605@C02TD0UTHF1T.local \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox