From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D150C433ED for ; Wed, 5 May 2021 16:51:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40A266141B for ; Wed, 5 May 2021 16:51:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40A266141B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m2WlDPxal2NjfjLwQ7NzdnYB0MARJPpCPpRF5iOA8Xc=; b=Eobgs2WULVtHNdkwn3aL6pA8B mSsqZc0AYGedBg7S3aNW/9PJYV2F7kkJRgotgs0nZqOxPKSbRPGbAk4zNSZ+QpSUesHUfUI0qDnpw Is+lc8D6CHhhXMpUREGBw+6DdRkPfZG4Wl8G/6jCbjkWGNwIqDniIY4UnE/nLkpukKCwAJIuSak4F 96tuTwMEEfZtAVczE3rhTVgNfRHjt6qqCqX/xJVED9kV0OZEQQVPqe6cBAZNtI8DX5M/3GdPZ3ehd w4OBPpBTTvi9NIwGyn2+/6xX946cMKKUxvqqIYGmduIliMHb0/Igt+X5EfrdYFNfNcxrvDSmfHxBU BbfN3Jgvg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leKiP-001lDQ-30; Wed, 05 May 2021 16:49:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leKWH-001gLO-Ba for linux-arm-kernel@desiato.infradead.org; Wed, 05 May 2021 16:37:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=BkVLaVN9TrFNTXqbioK21JNARIub4ejWNzCCtaQ8SWs=; b=fu6VGC3g/4LpAeR9G/s8UXjVmy 6Gu/xs/ZNeL+QEs49GiFi+AhuFkG0qrkficXoTaDXCf3tQSQGIP2DzJNA7g7Azg2yEFUh6ProntIN HEPRa7gqeJkSvczlqPkLJhuDg8NyTqOYkyu3DLr1hXQgwBLf+NEYDNyq5NfkF8NJejBxPPCqhqcXD 7mzZ+CJ253fVmaGKgSyCBuX0TaYyMVia6Q0Qvsbsyz2Ggu57ouh/U5GqcS28qSys/0qavZelVRFiK BUkBPyUoGtyV9SBInUfnIFt5hdoM3kgljKw6F0oCGqSaGqI5XgwXLNc66+3qreYjbSSEFF9XVzilH zLA47j+A==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leKWE-004xPg-St for linux-arm-kernel@lists.infradead.org; Wed, 05 May 2021 16:37:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7796961951; Wed, 5 May 2021 16:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620232622; bh=kEnxKvRvXtsSjAMGQKobqwfi53MrIc8FrAhY6aWVDy8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hNTf6Yucars99Tk/uKFOJXxofKIJlXjAuXWgFmWLlyC11LMd+/GMQ30krnQ24UUcH nbJgnRDBjWHLBpNsyne9H3im/+qVKFgXahNlD3aXWHYNBGuqdtw9p5qI3chAVpuOZL VYssesrUsyGA49tPfA92igVFwQUD09FxbkT5EQq8PtkOtz2sD894dqzb6jq3Mp3h9H 8TmxR3DATYYAWstUJ3WrNWsdLde9TaCnCWBQxeUtNvKcxvHCwB0oUaG7MlhM3J2yXg fo6D1BrL2tK7WEkIsv27EcnR+MZtQY5fS9Z7zsgF6Lc6tVDMNhfUb8efHOXtKuWzFU bsGVVnGAj9onQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jonathan McDowell , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.10 09/85] net: stmmac: Set FIFO sizes for ipq806x Date: Wed, 5 May 2021 12:35:32 -0400 Message-Id: <20210505163648.3462507-9-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210505163648.3462507-1-sashal@kernel.org> References: <20210505163648.3462507-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_093702_979394_5E94EC08 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Jonathan McDowell [ Upstream commit e127906b68b49ddb3ecba39ffa36a329c48197d3 ] Commit eaf4fac47807 ("net: stmmac: Do not accept invalid MTU values") started using the TX FIFO size to verify what counts as a valid MTU request for the stmmac driver. This is unset for the ipq806x variant. Looking at older patches for this it seems the RX + TXs buffers can be up to 8k, so set appropriately. (I sent this as an RFC patch in June last year, but received no replies. I've been running with this on my hardware (a MikroTik RB3011) since then with larger MTUs to support both the internal qca8k switch and VLANs with no problems. Without the patch it's impossible to set the larger MTU required to support this.) Signed-off-by: Jonathan McDowell Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c index bf3250e0e59c..749585fe6fc9 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c @@ -352,6 +352,8 @@ static int ipq806x_gmac_probe(struct platform_device *pdev) plat_dat->bsp_priv = gmac; plat_dat->fix_mac_speed = ipq806x_gmac_fix_mac_speed; plat_dat->multicast_filter_bins = 0; + plat_dat->tx_fifo_size = 8192; + plat_dat->rx_fifo_size = 8192; err = stmmac_dvr_probe(&pdev->dev, plat_dat, &stmmac_res); if (err) -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel