From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AF8C433B4 for ; Fri, 7 May 2021 05:08:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 990FE610A2 for ; Fri, 7 May 2021 05:07:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 990FE610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vcHx7aEc/MR9YDFBI8h5bQcPz/RXpaYCaUXUlMwfuLg=; b=exGDwPnq69lxuUC7lnUzp687t mxo4c/vXgKVlwxKdpY7nCwoIkyBujwozIGDKtIcnPiTJOMHJpG6S93IYx2cvPli8/VYAdjBTAf3/t K/4ir6ZeI09DrPw4XJB4UuwA6a5xW8G38037fgcCX5KR4TEbyt9vfahnj56HKxCCeEhXHtllGFriX 37KObf8RC+rV7r1Sf2SzP1q1dMkdvCE/D6wftaLZ3feVcDCzb1c8ANq97Yt+0TDlqXULpNrIglX/h oE3i3Hjox1XnDdcsDgWkvCiLut/+yQnyM8YVtusNt7F4NxeURZSoPH9dsOLdKUeutKJQgIUg0gZvy /lMmH3FzA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lesg6-0068Gg-CB; Fri, 07 May 2021 05:05:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lesg2-0068GZ-CC for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 05:05:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mvsQtcY5nHSPsrSLz/oIKaZb0lVlpaOU88csrWc5rRk=; b=xfpzs99Wbc4nbEw9OvoW0ShCkO rIp3ypbbrfOy/ztWYOPc1FEFfOOso4eGsWDDdOFtEsrLGIXuC3cfR/6eBNnXUkbgOhzWBWfbw9OwL YrpUfyPnavQ8dU804ye2KxzHqZzMJJMYFZD4FeLAZLHfxUZsNzEwic/3ep++oK+M+GPX3Zw3fJEGE eWolhwj5UKRQnehWTJygUwHy0WsYJZsyCeN24kwh+D6Y0pik3w1YAgJTy8HIhC6zXZ2+t6DMmK7tp CjKptDd1KWffGmutS3Kzo5tV3nsUBUwzhQCefnEJDuDoWTsR4OndEJVPqQePiCeLdWA33+2+lK2mh nTMVAIoQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lesfz-006a0t-JK for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 05:05:25 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lesfi-0003g4-Cs; Fri, 07 May 2021 07:05:06 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lesff-0007eK-8B; Fri, 07 May 2021 07:05:03 +0200 Date: Fri, 7 May 2021 07:05:03 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Christophe JAILLET Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com, linux-imx@nxp.com, j.beisert@pengutronix.de, krzysztof.h1@poczta.fm, linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] video: fbdev: imxfb: Fix an error message Message-ID: <20210507050503.iwrcis2xzhjjthmp@pengutronix.de> References: MIME-Version: 1.0 In-Reply-To: X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_220523_664304_6EF531E9 X-CRM114-Status: GOOD ( 21.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1025861412189635118==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1025861412189635118== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fchy7hv2sjxcax73" Content-Disposition: inline --fchy7hv2sjxcax73 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Christophe, On Thu, May 06, 2021 at 08:57:05PM +0200, Christophe JAILLET wrote: > 'ret' is known to be 0 here. > No error code is available, so just remove it from the error message. >=20 > Fixes: 72330b0eeefc ("i.MX Framebuffer: Use readl/writel instead of direc= t pointer deref") > Signed-off-by: Christophe JAILLET > --- > drivers/video/fbdev/imxfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c > index 7f8debd2da06..ad598257ab38 100644 > --- a/drivers/video/fbdev/imxfb.c > +++ b/drivers/video/fbdev/imxfb.c > @@ -992,7 +992,7 @@ static int imxfb_probe(struct platform_device *pdev) > info->screen_buffer =3D dma_alloc_wc(&pdev->dev, fbi->map_size, > &fbi->map_dma, GFP_KERNEL); > if (!info->screen_buffer) { > - dev_err(&pdev->dev, "Failed to allocate video RAM: %d\n", ret); > + dev_err(&pdev->dev, "Failed to allocate video RAM\n"); > ret =3D -ENOMEM; > goto failed_map; > } Reviewed-by: Uwe Kleine-K=F6nig Are you using this driver, or did you find that problem using some static checker? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --fchy7hv2sjxcax73 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCUynsACgkQwfwUeK3K 7Akw+QgAibPO6IbkA1icCBx3pbmkEnH1NGD7B1YrSwgKWeQlnCqqfv67hRrjvs1u s2PTr3bd7cE3G7YnWnWWLEC9/7xew8nNKv89KFGSQa1pzRFBc/FGpaeTMDvkO8PK miGiZbBAl240AtvS87ODzAIDqB2vQkJ6UzinynVbHTN4j+1FKjwnmag05qugFDvx nYGaNPop0x4BzwcBVVKGTwCnHjmoWdz+HGw+udY9AnO/N5A+Ms6WGsx2yf6d1Z4f 9i9UwA7LoOM/i8+bEwtgZRnn7CXBhYWPFhNMtU+nKAqeGryeAr4UsO/8Y/O9kN/5 F+yqk+jOjwAAnNq5cNzXm6wxrxN88Q== =KRUx -----END PGP SIGNATURE----- --fchy7hv2sjxcax73-- --===============1025861412189635118== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1025861412189635118==--