From: Michael Tretter <m.tretter@pengutronix.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
michal.simek@xilinx.com, quanyang.wang@windriver.com,
rajan.vaja@xilinx.com, jolly.shah@xilinx.com, tejasp@xilinx.com,
shubhrajyoti.datta@xilinx.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] clk: zynqmp: pll: Remove some dead code
Date: Fri, 7 May 2021 11:27:13 +0200 [thread overview]
Message-ID: <20210507092713.GM29775@pengutronix.de> (raw)
In-Reply-To: <71a9fed5f762a71248b8ac73c0a15af82f3ce1e2.1619867987.git.christophe.jaillet@wanadoo.fr>
On Sat, 01 May 2021 13:24:32 +0200, Christophe JAILLET wrote:
> 'clk_hw_set_rate_range()' does not return any error code and 'ret' is
> known to be 0 at this point, so this message can never be displayed.
>
> Remove it.
>
> Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> HOWEVER, the message is about 'clk_set_rate_range()', not
> 'clk_hw_set_rate_range()'. So the message is maybe correct and the
> 'xxx_rate_range()' function incorrect.
Thanks. The function is correct, as this is a clock provider and should use
the clk_hw. Removing the message is correct.
Michael
> ---
> drivers/clk/zynqmp/pll.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c
> index abe6afbf3407..af11e9400058 100644
> --- a/drivers/clk/zynqmp/pll.c
> +++ b/drivers/clk/zynqmp/pll.c
> @@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name, u32 clk_id,
> }
>
> clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX);
> - if (ret < 0)
> - pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret);
>
> return hw;
> }
> --
> 2.30.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-07 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 11:24 [PATCH] clk: zynqmp: pll: Remove some dead code Christophe JAILLET
2021-05-03 4:56 ` Rajan Vaja
2021-05-03 5:50 ` Christophe JAILLET
2021-05-05 10:10 ` Rajan Vaja
2021-05-07 9:27 ` Michael Tretter [this message]
2021-06-25 23:09 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507092713.GM29775@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=jolly.shah@xilinx.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=mturquette@baylibre.com \
--cc=quanyang.wang@windriver.com \
--cc=rajan.vaja@xilinx.com \
--cc=sboyd@kernel.org \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=tejasp@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).