From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91F5C433B4 for ; Fri, 7 May 2021 09:29:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B7796145A for ; Fri, 7 May 2021 09:29:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B7796145A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Yz6IhhuQdR0bEVFBRLSmqhcymLIQ1HqiwFhYiwZvQo=; b=LVV/qgEqtpLy3Y8rWJzCqZBix oMu+UFbhQO7E8naOs9zwpixnkCP5KEG4DL47uWmP3oqtjuLe2VnNt0Ti/REtkluHjXNsTLJorgrbe GqeBIoTimn1khZ4PHVcCtT5301Nmo5siPSBB5YoJZXMeA3YMBu+RkCYs0pxSGz/HjrzUPeXLMcJ+p WZX06GHIzIinHTckTWQF+6PlaV8Tcs4kFjHh/axcMZ24J9v+v7aAm8jvK7Uj1o4WGrKjnTs1Ok4pr bf0jilDdJI4Ezj9LH6JCDz0MvvQlBmZZ0BShorsxJfiByk5UvLZcUKQHCQlew3KE34rs+P/bMUXtS uANspw9sw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lewlg-006eSq-7c; Fri, 07 May 2021 09:27:32 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lewle-006eSb-Gv for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 09:27:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MSknyeWG/k5PA8WLh5OB7e6pse7IRLMD10miKLhase0=; b=cGddzOwe79JKoSdlvCGJZHD3YP EhMEe4MMRgPvB7uj2lOawlM0RpsVr4Jtr/Y+EL5sItp2TmVhIB6iA4hxfnDJvmBTZG6zjO3QfDJxN xZlH53FLhGPgL3BELnhfC7qp2uQJx+jJlETgZbvPSNOj5oMFaGe8dA5QXzwE4VFw4rZdFt9OlUrug RdcK/hX+DPxklVBywHeftiFcxH8WaFUQ6p5umuTmA/xCe5SblCyrvHaqbz5ZYUR9ma8Y2QCbZL0pP j04QdP1zHR7TZGfI2I3q/omK3rbXQeKEm8sCqhVgVyG6zh7zMWNsptvkjEJjGxIzC6tjrXxqQT7Qc m+HlYNzQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lewlb-006jYo-Mo for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 09:27:29 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lewlP-00023a-JO; Fri, 07 May 2021 11:27:15 +0200 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lewlN-0007ID-SU; Fri, 07 May 2021 11:27:13 +0200 Date: Fri, 7 May 2021 11:27:13 +0200 From: Michael Tretter To: Christophe JAILLET Cc: mturquette@baylibre.com, sboyd@kernel.org, michal.simek@xilinx.com, quanyang.wang@windriver.com, rajan.vaja@xilinx.com, jolly.shah@xilinx.com, tejasp@xilinx.com, shubhrajyoti.datta@xilinx.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] clk: zynqmp: pll: Remove some dead code Message-ID: <20210507092713.GM29775@pengutronix.de> References: <71a9fed5f762a71248b8ac73c0a15af82f3ce1e2.1619867987.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <71a9fed5f762a71248b8ac73c0a15af82f3ce1e2.1619867987.git.christophe.jaillet@wanadoo.fr> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:22:09 up 78 days, 12:46, 97 users, load average: 0.07, 0.08, 0.09 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_022727_764558_6F1E6712 X-CRM114-Status: GOOD ( 22.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 01 May 2021 13:24:32 +0200, Christophe JAILLET wrote: > 'clk_hw_set_rate_range()' does not return any error code and 'ret' is > known to be 0 at this point, so this message can never be displayed. > > Remove it. > > Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") > Signed-off-by: Christophe JAILLET Reviewed-by: Michael Tretter > --- > HOWEVER, the message is about 'clk_set_rate_range()', not > 'clk_hw_set_rate_range()'. So the message is maybe correct and the > 'xxx_rate_range()' function incorrect. Thanks. The function is correct, as this is a clock provider and should use the clk_hw. Removing the message is correct. Michael > --- > drivers/clk/zynqmp/pll.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c > index abe6afbf3407..af11e9400058 100644 > --- a/drivers/clk/zynqmp/pll.c > +++ b/drivers/clk/zynqmp/pll.c > @@ -331,8 +331,6 @@ struct clk_hw *zynqmp_clk_register_pll(const char *name, u32 clk_id, > } > > clk_hw_set_rate_range(hw, PS_PLL_VCO_MIN, PS_PLL_VCO_MAX); > - if (ret < 0) > - pr_err("%s:ERROR clk_set_rate_range failed %d\n", name, ret); > > return hw; > } > -- > 2.30.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel