From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0318AC433B4 for ; Fri, 7 May 2021 21:45:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69F6F61003 for ; Fri, 7 May 2021 21:45:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69F6F61003 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SeEPjw22n1PGiUxLSwghPHboHEF6cP3zlWAyZjDJaPI=; b=FjgL62EafPu5sZ3+Mx144jIMb 4vQJzG08bfwSePvFlQirBkbt+9AbfIsWuNW/LafPr8LNo1wZ4N5EkXOSUu5x/+BJFdBXkcdN2AgFZ 94eILEC599UNm6DejaFmItpVJ1RWI+WZYzQnWnjiiO8c51IrowRTdy8chN1aoP4oqu/5P4KlrXmXw VXOME9UkVjztxi1yvXIUEhrdxawGwlsahdYThWfI5FwiecC/e/W/OXDVNS6N7jzepqq1K2rOuQ6qL MBtkj74lVP7uUlMY5jAXiR9uglBNTGlToPobVubq64Ak7ByH9V4GM+bM7hFVJrgIXfcY3q9veksgQ gUIeP6eiw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lf8Fw-0086ri-FW; Fri, 07 May 2021 21:43:33 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf8Ft-0086rY-4R for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 21:43:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1jPYaiJ3mpOsE5i/q/eUuwCFtgMQJcQzg5PuBr/sjHs=; b=19OL6T3r2KU5xT0dd1jLur6Sl7 vyU0xEIYkjkT/PqRBaE9Tv+LU94xoKFsx/jXcEIgfqMz92sGuvoyVxpwm0LAhAy6enluv6wQyK1dL W4X5yAfFSbYn/nLdgNWhomgITAfV5BDycgVtkUtWThTkQ+zIGCaJCCo7BKiX2cO8zfisqjHsQOms8 1yjiwnqlUcC7XO1xO2uDvWyCgjQaG8aX9XMI5/+/WsKuubTKyZKOAvl5BwEDJiv8Ix+zWGsyGVKwQ ERmYxQvwoQYuNK+0jWK8wdsJ77v9ZL45nZZdMaa9nChm8llj8Cr3IMNT965fXsHIYMLmgmztAEtZX EpbA3v6w==; Received: from mail-ot1-f50.google.com ([209.85.210.50]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lf8Fq-007CfA-FW for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 21:43:27 +0000 Received: by mail-ot1-f50.google.com with SMTP id b5-20020a9d5d050000b02902a5883b0f4bso9166337oti.2 for ; Fri, 07 May 2021 14:43:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1jPYaiJ3mpOsE5i/q/eUuwCFtgMQJcQzg5PuBr/sjHs=; b=nhv7S+ZjogNU1zBXVo1Cpk8zoKhc7GO0XwtEHrULZ8cD71MLIwLzkghvI6bUMXEYFO 35A1NolRtqPtNvy+lqHEhSg3Uvgt1kyVCP3qLyzG7KxOKh/R2AY8MYH8NlZyhxmP8h+S HgjFBLR9lyULyCdsdT68cu/ExiBNv1+Qu5Hanyy3xqKKeRgi0A6o/7lzdBtEBVnOl45I s18Pa1AqpcXjgEs0Br0QLdVkHlCzbQ/UmZ64E6nhyGhWVj2YPSv3ouIO2WQpVulVjEeQ oTIjEqqIHqMSYRA76NLC8ZxhKhMHKl/edJJxdZdFY94NUCA8UpmYdajomixJmV1J4MB5 gyPQ== X-Gm-Message-State: AOAM531QOM3F6IRDlHIBxU2mMm0puq3zJkteGqEmTdWlshq5LAzlHcnV Mr3kXtthp7qidokFUq3OsQ== X-Google-Smtp-Source: ABdhPJyTQdRZg+46DJaHovSc+DGA9RXAMHaPE7FDnBU2Ww/Sph47kxo0hyCvh1ofVKV3FbagEmTENQ== X-Received: by 2002:a05:6830:1450:: with SMTP id w16mr9903118otp.305.1620423805659; Fri, 07 May 2021 14:43:25 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id c65sm1202316oia.47.2021.05.07.14.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 14:43:24 -0700 (PDT) Received: (nullmailer pid 2942658 invoked by uid 1000); Fri, 07 May 2021 21:43:23 -0000 Date: Fri, 7 May 2021 16:43:23 -0500 From: Rob Herring To: Grygorii Strashko Cc: Andreas Kemnade , Vignesh Raghavendra , linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux ARM Mailing List , Tony Lindgren , Nishanth Menon Subject: Re: [PATCH v2] dt-bindings: i2c: Move i2c-omap.txt to YAML format Message-ID: <20210507214323.GB2902038@robh.at.kernel.org> References: <20210506140026.31254-1-vigneshr@ti.com> <429a740a-c2b9-1cf8-ed2b-0fb7b1bea422@ti.com> <20210507163602.219894f4@aktux> <1ef076ac-e0de-a0df-a918-aeb8ed6c5956@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1ef076ac-e0de-a0df-a918-aeb8ed6c5956@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_144326_562712_3B3E500D X-CRM114-Status: GOOD ( 28.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 07, 2021 at 08:24:59PM +0300, Grygorii Strashko wrote: > > > On 07/05/2021 17:36, Andreas Kemnade wrote: > > On Fri, 7 May 2021 19:45:45 +0530 > > Vignesh Raghavendra wrote: > > > > > On 5/7/21 12:24 PM, Grygorii Strashko wrote: > > > > > > > > > > > > On 06/05/2021 17:00, Vignesh Raghavendra wrote: > > > > > Convert i2c-omap.txt to YAML schema for better checks and documentation. > > > > > > > > > > Following properties were used in DT but were not documented in txt > > > > > bindings and has been included in YAML schema: > > > > > 1. Include ti,am4372-i2c compatible > > > > > 2. Include dmas property used in few OMAP dts files > > > > > > > > The DMA is not supported by i2c-omap driver, so wouldn't be better to > > > > just drop dmas from DTBs to avoid confusions? > > > > It can be added later. > > > > > > Will do.. I will also send patches dropping dmas from dts that currently > > > have them populated. > > > > > hmm, we have > > - DO attempt to make bindings complete even if a driver doesn't support some > > features. For example, if a device has an interrupt, then include the > > 'interrupts' property even if the driver is only polled mode. > > > > in Documentation/devicetree/bindings/writing-bindings.rst > > Shouln't the dma stay there if the hardware supports it? Devicetree > > should describe the hardware not the driver if I understood things > > right. > > True. But my above statement is also valid - it introduces confusion from user point of view. In my OS, 'robOS', the driver supports DMA. > More over, 'dmas' is not part of original binding and were randomly added to some SoCs. > And it's much more easy to extend binding (in the future) then remove something after. In this case, probably given that how it would be extended is already known, but it depends how you extend a binding. My above statement was born out of incomplete MFD and system controller bindings for the most part. > I leave it to Vignesh, Tony to decide. Fine with me. Actually, for DMA with I2C I'd like to see someone show a usecase and data where it's actually beneficial. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel