From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B2FC433ED for ; Mon, 10 May 2021 02:36:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 104BA610A5 for ; Mon, 10 May 2021 02:36:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 104BA610A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QEyHjIYhxt4JnIAlQ12+fC/IBVxIT/wI/IhwaoYzEBE=; b=eErrToafuqG2hhXr3JEsdaJ4N D5uiOITNTngqyJvqa6dI22zCOlWxbQ4DYfb5c3gZ8un1ws0cZ5ukeMucWvq5qx/w8hLRrmtxf8TyI Gg4u17f9S/qGV5xzOjskXbSPiyVcbJH92ROLuqUAMHaHArewidNeaIzuOSkwCuCW9xpp8ySiQBpOa d3VWkua0/+EJ9vihNRa2Dw3zdqgk3yFhTjicNDek7JIjGj9O6E7US0Oy4sNPrOIWcbWL1zRYkVZB2 i5HEgf+dnSS2qpYcGvYCmpU48aCoI0v0B3XKEdj0gEo+PkQWTFe97L3iz6KxzSrrpllIP6K3vMHIk Z2fRxbJNg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfvk0-00CsF6-02; Mon, 10 May 2021 02:33:52 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfvju-00CsEY-8K for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 02:33:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:CC:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AnIDWNgUMKE22XiIcHVxpI953hsacG5HQgDeGKbv7bM=; b=lRMiIF7f6uqU4FlPbhaN2xGTWC IwVzMpTqDAqjp57UoIxzj/zHe1PNOxixEmuijln0UnjpWH+/PnRf7cVQQCQ4tF+Ykri+CSyVci93z OuFntK8iV/79Q6wE4F9MTty8kXQhyjudFH5XiM5gpjAGViSfdobLtbvWxz4uQDUYglvfLuco2qY9D IdxgyFqwByuJ+2On7nzUfKdqQVe5Epon/h+Rwv8WqNTfkxQh18gZlmtpix8LQGy8102arMy69PDDs cfZii+hqfD5AN1VV6s3OqLOJdWF/SVGfHafbzAAhUjVpdcVdMjB7AsVzuLpaCNQn6RIpWdAU9ZKX0 olu7GA0w==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfvjk-005cbw-UB for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 02:33:41 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 14A2KSJh015471; Mon, 10 May 2021 10:20:28 +0800 (GMT-8) (envelope-from steven_lee@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 May 2021 10:32:31 +0800 Date: Mon, 10 May 2021 10:32:28 +0800 From: Steven Lee To: Rob Herring CC: Andrew Jeffery , Ulf Hansson , Joel Stanley , Adrian Hunter , Philipp Zabel , Ryan Chen , "moderated list:ASPEED SD/MMC DRIVER" , "moderated list:ASPEED SD/MMC DRIVER" , "open list:ASPEED SD/MMC DRIVER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "Hongweiz@ami.com" , "Ryan Chen" , Chin-Ting Kuo Subject: Re: [PATCH v3 1/5] dt-bindings: mmc: sdhci-of-aspeed: Add an example for AST2600-A2 EVB Message-ID: <20210510023228.GA6883@aspeedtech.com> References: <20210506100312.1638-1-steven_lee@aspeedtech.com> <20210506100312.1638-2-steven_lee@aspeedtech.com> <20210507011324.GA1119409@robh.at.kernel.org> <20210507031348.GA23749@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 14A2KSJh015471 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_033338_830268_CFCB199C X-CRM114-Status: GOOD ( 23.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 05/08/2021 01:21, Rob Herring wrote: > On Thu, May 6, 2021 at 10:14 PM Steven Lee wrote: > > > > The 05/07/2021 09:13, Rob Herring wrote: > > > On Thu, May 06, 2021 at 06:03:08PM +0800, Steven Lee wrote: > > > > AST2600-A2 EVB has the reference design for enabling SD bus > > > > power and toggling SD bus signal voltage by GPIO pins. > > > > > > > > In the reference design, GPIOV0 of AST2600-A2 EVB is connected to > > > > power load switch that providing 3.3v to SD1 bus vdd. GPIOV1 is > > > > connected to a 1.8v and a 3.3v power load switch that providing > > > > signal voltage to > > > > SD1 bus. > > > > > > > > If GPIOV0 is active high, SD1 bus is enabled. Otherwise, SD1 bus is > > > > disabled. > > > > If GPIOV1 is active high, 3.3v power load switch is enabled, SD1 > > > > signal voltage is 3.3v. Otherwise, 1.8v power load switch will be > > > > enabled, SD1 signal voltage becomes 1.8v. > > > > > > > > AST2600-A2 EVB also support toggling signal voltage for SD2 bus. > > > > The design is the same as SD1 bus. It uses GPIOV2 as power-gpio and > > > > GPIOV3 as power-switch-gpio. > > > > > > > > Signed-off-by: Steven Lee > > > > --- > > > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 101 +++++++++++++++++- > > > > 1 file changed, 97 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > index 987b287f3bff..de7e61b3d37a 100644 > > > > --- a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > @@ -45,10 +45,16 @@ patternProperties: > > > > > > > > properties: > > > > compatible: > > > > - enum: > > > > - - aspeed,ast2400-sdhci > > > > - - aspeed,ast2500-sdhci > > > > - - aspeed,ast2600-sdhci > > > > + oneOf: > > > > + - items: > > > > + - enum: > > > > + - aspeed,ast2400-sdhci > > > > + - aspeed,ast2500-sdhci > > > > + - aspeed,ast2600-sdhci > > > > + - items: > > > > + - enum: > > > > + - aspeed,ast2600-sdhci > > > > + - const: sdhci > > > > > > Why are you adding 'sdhci'. That's not useful as a compatible given how > > > many quirks different implementations have. > > > > > > > > > > It is for passing the dtbs_check of the second example. > > Without this definition, many device trees have the following > > error: > > > > ['aspeed,ast2600-sdhci', 'sdhci'] is too long > > Additional items are not allowed ('sdhci' was unexpected) > > I would probably fix the dts files then. Does anything depend on 'sdhci'? > The build error is caused by my second example. My example is refer to the aspeed-g6.dtsi to append "sdhci" after "aspeed,ast2600-sdhci" https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/aspeed-g6.dtsi?h=v5.12#n561 As long as the second example is removed, the following error won't show in the dtbs_check result. ``` SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC arch/arm/boot/dts/aspeed-ast2500-evb.dt.yaml CHECK arch/arm/boot/dts/aspeed-ast2500-evb.dt.yaml DTC arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml CHECK arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml /home/slee/aspeed/patch_up/linux/arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml: sdc@1e740000: sdhci@1e740100:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long From schema: /home/slee/aspeed/patch_up/linux/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml /home/slee/aspeed/patch_up/linux/arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml: sdc@1e740000: sdhci@1e740100:compatible: Additional items are not allowed ('sdhci' was unexpected) From schema: /home/slee/aspeed/patch_up/linux/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml /home/slee/aspeed/patch_up/linux/arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml: sdc@1e740000: sdhci@1e740200:compatible: ['aspeed,ast2600-sdhci', 'sdhci'] is too long From schema: /home/slee/aspeed/patch_up/linux/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml /home/slee/aspeed/patch_up/linux/arch/arm/boot/dts/aspeed-ast2600-evb.dt.yaml: sdc@1e740000: sdhci@1e740200:compatible: Additional items are not allowed ('sdhci' was unexpected) From schema: /home/slee/aspeed/patch_up/linux/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml ``` > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel