From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 663EDC433B4 for ; Mon, 10 May 2021 08:33:41 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD0356143B for ; Mon, 10 May 2021 08:33:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD0356143B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BO2ShVQRwYNzMfqPrHAHW5p3NjLmWk5iTJ+0oXvOvZs=; b=MBkQmpn2PNUa2CiH65qodIGhO Q0DIjSRESM1DMEn1iFAuvIk8K/OjvLSM4mf/UU3st2ygPhoXXz68vRQ5cL1LGCpOxK8Bs3RRwaFI9 2WBW5zMGPB4PLhnF6jBmhZwT638H8z4esab15HD3hUSfrExicxE4J0uDH5zVBgNPUOc3ZLH8eOZa6 2zVzt5HqUELNUNPuJS6t5Xoq4CK+EQR3ORxR2RpLi49bIjqYrvlIujqR0IJEiXLXX+nG+WMEBLQMC Z0i+fxOWY4FCtL8U7sH/wCPbixv/pfFjgrhrhccBLVRy5z2lm2t4yU1Y3fVIICdbr1pImEO1hub8T H2z99T1iw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg1KR-00DdIG-Gp; Mon, 10 May 2021 08:31:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg1KO-00DdHd-Hb for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 08:31:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=SdE/VJ2o9cGTy6qoWAHGyPuqEVjbPc4tBZutYm37Gl4=; b=o+fQ+HqdtUBdumjOSOel3Ecvvx 5PIgEwSUI3dSjMPYrlspQhgtgBornZ5ayUuDoyobJ3uDDmgLxoqhzyR5ZdvFaK5NGAfee4ZrSo0Qp jx/zfvs5K01QllxrjZKgLcMx1gDllu9gcYe1PWyi43Fk/8hb2U6V9olP9ksgKSLh07cUE1INZ3xyD rqxoSQx9JNApmyScXpLRt5zu4+Va7MqqGJU7v5jqIWH0huTso6b+4vhNQVF0f9q1Qf9IGzbg/rzHQ 8nU4ROo07xFxzLQ3L+XEqDz55I2+k0qFcfAWHFqGO5Wq4qWJWLAhSj2EG56eMdztyXsrSixhJBz/v R3Urh1gQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg1KL-008Pqx-H1 for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 08:31:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C760F106F; Mon, 10 May 2021 01:31:29 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E7B363F719; Mon, 10 May 2021 01:31:28 -0700 (PDT) Date: Mon, 10 May 2021 09:30:36 +0100 From: Andre Przywara To: Jaxson Han Cc: Mark Rutland , "linux-arm-kernel@lists.infradead.org" , Wei Chen Subject: Re: [boot-wrapper PATCH 1/5] Decouple V2M_SYS config by auto-detect dtb node Message-ID: <20210510093036.37ddfae4@slackpad.fritz.box> In-Reply-To: References: <20210420072438.183086-1-jaxson.han@arm.com> <20210420072438.183086-2-jaxson.han@arm.com> <20210426123016.76947383@slackpad.fritz.box> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_013145_721680_E585CF59 X-CRM114-Status: GOOD ( 27.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 28 Apr 2021 03:23:18 +0000 Jaxson Han wrote: Hi Jaxson, > Hi Andre, > > > -----Original Message----- > > From: Andre Przywara > > Sent: Monday, April 26, 2021 7:30 PM > > To: Jaxson Han > > Cc: Mark Rutland ; linux-arm- > > kernel@lists.infradead.org; Wei Chen > > Subject: Re: [boot-wrapper PATCH 1/5] Decouple V2M_SYS config by auto- > > detect dtb node > > > > On Tue, 20 Apr 2021 15:24:34 +0800 > > Jaxson Han wrote: > > > > Hi, > > > > > An auto-detect switch is added to make it an option to enable/disable > > > 'arm,vexpress-sysreg', because not all platforms support this feature. > > > > The change itself is fine, only has the side effect of now printing an message > > about the missing node: > > No matching devices found at ./findbase.pl line 37. > > > > I will have a look if we can avoid this, or we drop this message in findbase.pl > > at all. > > Thanks, if you have any suggestions, please let me know:) As Mark suggested, you can just add " 2> /dev/null" at the end of the findbase.pl call. That allows to do this warning suppression on a case-by-case base, and is preferred over dropping this message in general. Cheers, Andre > > > > > But for the sake of this patch: > > > > Reviewed-by: Andre Przywara > > > > Cheers, > > Andre > > Thanks! > Jaxson > > > > > > Signed-off-by: Jaxson Han > > > --- > > > Makefile.am | 2 +- > > > platform.c | 4 ++++ > > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/Makefile.am b/Makefile.am index af694b7..e131207 100644 > > > --- a/Makefile.am > > > +++ b/Makefile.am > > > @@ -19,7 +19,7 @@ NR_CPUS := $(shell echo $(CPU_IDS) | tr ',' ' ' | wc > > -w) > > > DEFINES = -DCNTFRQ=$(CNTFRQ) > > > DEFINES += -DCPU_IDS=$(CPU_IDS) > > > DEFINES += -DNR_CPUS=$(NR_CPUS) > > > -DEFINES += -DSYSREGS_BASE=$(SYSREGS_BASE) > > > +DEFINES += $(if $(SYSREGS_BASE), - > > DSYSREGS_BASE=$(SYSREGS_BASE), ) > > > DEFINES += -DUART_BASE=$(UART_BASE) > > > DEFINES += -DSTACK_SIZE=256 > > > > > > diff --git a/platform.c b/platform.c > > > index a528a55..d11f568 100644 > > > --- a/platform.c > > > +++ b/platform.c > > > @@ -23,10 +23,12 @@ > > > > > > #define PL011(reg) ((void *)UART_BASE + PL011_##reg) > > > > > > +#ifdef SYSREGS_BASE > > > #define V2M_SYS_CFGDATA 0xa0 > > > #define V2M_SYS_CFGCTRL 0xa4 > > > > > > #define V2M_SYS(reg) ((void *)SYSREGS_BASE + V2M_SYS_##reg) > > > +#endif > > > > > > static void print_string(const char *str) { @@ -59,6 +61,7 @@ void > > > init_platform(void) > > > > > > print_string("Boot-wrapper v0.2\r\n\r\n"); > > > > > > +#ifdef SYSREGS_BASE > > > /* > > > * CLCD output site MB > > > */ > > > @@ -66,4 +69,5 @@ void init_platform(void) > > > /* START | WRITE | MUXFPGA | SITE_MB */ > > > raw_writel((1 << 31) | (1 << 30) | (7 << 20) | (0 << 16), > > > V2M_SYS(CFGCTRL)); > > > +#endif > > > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel