From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18256C433B4 for ; Mon, 10 May 2021 20:51:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB0D361469 for ; Mon, 10 May 2021 20:51:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB0D361469 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=+GQ16DIn1Rrh/BFFVgnXwplqc4Ei3GL8vn5RDYZAEk0=; b=ClNTWODkanNOJYBulty0fdH2W O7gsL72BGvA4gFLbq9lTHfc2Atl8ruPmS2ROrIm6Zp5MOJCgga9SHYQf5af1iOjMG5wryTBeL6L7n d7TwPeHO7rziegoxn8ZRJ01dwC+Az594oUTqCx1dqX9HxgTlrJEzSdljBFc0fU0INbDmWc3sOUqRx 8ZbTeMA6KFnkCD4Pw3j/192omO8lWF/D8teHTW6rkK32QaupEYLfR551+9nk0RKcVl6ZyrbKfLTSD /UH7LnLmRXDeHGSfonCLqYGwXNveYv2hehOcXDygFdTStwQiOuwZZE+T1riQNhnFUw2bKCxZFtRqU 9fZLjxmXg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgCqO-00Fhk3-Ap; Mon, 10 May 2021 20:49:36 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgCqL-00FhjV-Oo for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 20:49:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:References; bh=imQTFAq7Blo8XkW3I5AEZQERw7+IXrIEpRjwChHKBdE=; b=zoIij3Yjt9Ogx5fYw8RsSc0Mks e2S0CQpobH0Duk471XPO7YnxJpeQKo/qrHRggcnXGeXlCogPJab2qxpsAPavn8b0JG/eoe+z5psqh UocJX4At/mh7zgNPrECSazHXQuYSmI/NHWjr8v1IQlhG+6tiAw0tS+YV/vsDSvBAnAwm6xDDNtU/Q SaENs55hIVDEnSgnT8d0tFBvi67Lx8yV1yZPWuW7Nb3HLqiYCFqwfw02uuXeJl6YdXpiQIyBj/gQX ixGEDvlcyqCRZ33S0YcXhgKL0ZsyIoV5xZSZ732cT4l36o27w8JxINTvz9kYKRiWK7LUHS4IkIwwk lhZr9mhA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgCqJ-0097EA-AW for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 20:49:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 74E7D61469; Mon, 10 May 2021 20:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620679769; bh=XF65myxk1R6rOg5TYwVWxf8E6nFqE+GuICaIhKIyTog=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=UspqD4CbBTKGiecvztlrhHTjyY3LdvOoM1sn035adapkriaaOEu5mQUViPdRN5f2H DWVamS6jnyXPA68W4SAni6LBuK6r6PhY4WdYz9fwxOInHjWlHU+3eZtw0NCaLXXsJn Za7Xb96U6hO7Xfrz8Rmp784Lhnq2w35HLxJ9MLX3frLcvPLASWrxK6JyA11YasEfR9 AThLYbn1CA/RGCJ6bbrJMnNbR9/EgZk9qw8cCV4B/9BRQGkhyRzQ9pbkPW2s4ZB1QH EpqDIlVsUSiIe3BUX9u7UfygdpaE1FFe5OtfjOUlWFZRlTHt5i7QtFaIzROvYJZS61 ZuLHnxnCLxD9Q== Date: Mon, 10 May 2021 15:49:28 -0500 From: Bjorn Helgaas To: Nobuhiro Iwamatsu Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, punit1.agrawal@toshiba.co.jp, yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] PCI: dwc: Visconti: PCIe RC controller driver Message-ID: <20210510204928.GA2299570@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210510074736.jlxq44o3duwlmylo@toshiba.co.jp> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_134931_404926_B1C53195 X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 10, 2021 at 04:47:36PM +0900, Nobuhiro Iwamatsu wrote: > On Thu, Apr 29, 2021 at 06:10:40PM -0500, Bjorn Helgaas wrote: > > > +#define PCIE_UL_EDMA_INT3 BIT(5) > > > +#define PCIE_UL_S_INT_EVENT_MASK1_ALL (PCIE_UL_CFG_PME_INT | PCIE_UL_CFG_LINK_EQ_REQ_INT | \ > > > + PCIE_UL_EDMA_INT0 | PCIE_UL_EDMA_INT1 | \ > > > + PCIE_UL_EDMA_INT2 | PCIE_UL_EDMA_INT3) > > > + > > > > Please wrap the code here and below so it fits nicely in 80 columns. > > checkpatch.pl allows up to 100 characters, is this a PCI driver rule? The general rule is "match what's around you." So I guess that makes it a drivers/pci/ rule. > > > + pp->irq = platform_get_irq_byname(pdev, "intr"); > > > + if (pp->irq < 0) { > > > + dev_err(dev, "interrupt intr is missing"); > > > > Make your error messages consistently capitalized (or consistently not > > capitalized). > > Sorry, I didn't understand this point correctly. > Does this mean capitalize the first letter of the message? Some of your messages are capitalized and others are not: dev_info(pci->dev, "Link failure\n" dev_err(dev, "Failed to get refclk clock: %ld\n" dev_err(dev, "Failed to get sysclk clock: %ld\n" dev_err(dev, "Failed to get auxclk clock: %ld\n" dev_err(dev, "interrupt intr is missing" dev_dbg(dev, "Applied default link speed\n" dev_dbg(dev, "link speed Gen %d" dev_err(dev, "Failed to initialize host\n" I don't really care whether they're all capitalized or none are capitalized, but they should all be the same. Otherwise it just looks sloppy. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel