From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE673C433B4 for ; Tue, 11 May 2021 12:43:57 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40E796121E for ; Tue, 11 May 2021 12:43:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40E796121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5W8NF2Ht3/T4ODc1YZ54GnWp2LvcE2tM031gI/G7cNg=; b=kk9blB7y0PFxpBPFO9HzVmlJR yA8K0XqtJsaWOv5xaBt1cZbkou2xSfl6oxiYubafcJFwmVJbpyWiSD+69TSPjNz8PMkrNuPFQCMLI N+HvC8ubCpWmczcFdXA4J23+TS2N2U4k6wsVlzB7J3RT/+qfmdNx7S0x5khAnUdP+zxq5cx6N1bWd bUmlvDku8NZeFdBCB1mIIhAcHpK+Ok3WZZnD8V051xjV0rb9+sugggsAAJswSV63RCBBFmjKYSgAc VxQfdH3sqpvcRJ5snB2ipaRZ0Yq/uvMdWI/UKnluwfPPVXfKGG8B6X8itVvau+WdCDR1HCl9c4VjL SUJVcG6Sw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgRiN-00HRYo-4q; Tue, 11 May 2021 12:42:21 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgPEh-00Gozy-QB for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 10:03:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:In-Reply-To:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PoB6tmhK0ojxZqg4RY27A1X/0CCVW4jvcBEro4rmZ2U=; b=OppXQEEMmNhexDxPS7NpdmeHEC f3TIiXPU5TM6Az7h4Lpyqbg+fdiVApd1D2Aen4vQAiITEpEX4c/Ocr8Ef4Nstb2DgyyKTzk9SkJG5 llMPTB5pqJwJl/lD6Aq2a27rSlG7GSDOd6se8KLtO3DZdonim3t3wcoAJwUQBveS6d5MStDfXLPzJ aB5A6A1Bkj85InJX/2It+7EUbTy0qHo0V0cpY7OqdO4uQ37xyutmXaZgd0E8qCZ9pIGNv4ptvOZg5 EioqNZIjL02J1p1sW323NV0NcjzLEDOIPKOFHwMHyuuR2osGd/bSYb3U45/BwMDka/e7oRm/gbQO0 pz3BbZ8Q==; Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgO3q-009POv-I2 for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 08:48:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620722891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PoB6tmhK0ojxZqg4RY27A1X/0CCVW4jvcBEro4rmZ2U=; b=irpWL9PTRrMKtO6LcENj6D06qy/fgSMjpned4iyZa3A2ZeeMea/uOnqaLivhSsvPDZy6pA QvczkwHWI6OaevAOdOJIcBJsgjx3lgxPGspYp9peL4hhxqonfP41nWzWesxKn4YGf1SAEn EOcCehYXyLGiprFFR9lAkax6GrieYTM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-cI5glUWHOnOeKF2rcsYx6Q-1; Tue, 11 May 2021 04:48:08 -0400 X-MC-Unique: cI5glUWHOnOeKF2rcsYx6Q-1 Received: by mail-wm1-f69.google.com with SMTP id o10-20020a05600c4fcab029014ae7fdec90so475318wmq.5 for ; Tue, 11 May 2021 01:48:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PoB6tmhK0ojxZqg4RY27A1X/0CCVW4jvcBEro4rmZ2U=; b=HZFF3XK8r8R5Ge9z9QTd6z7G0tD3GSUVR3+Mqr9veXij3MoM/rvVwvq39ij10IxfXZ hVuG4H/urAC9kYiQZZlxnpT2fgBYpMipqCF7SHtzYXKUhrrzbgGeLURlHDpP8Fm5CtDo e/3d+6+85a6Dd9Fv5Qp9HwqICd0q+pjEH4NQWsfb2OD7aO7q08ICSeNMOiEqJ4IQ1wP4 bNcIuC42QrqH1aozRr1087q7hBcDbjcyZ2sdWrYUVQnUvmMZYwLCnrd0U6J4gnWAL0QQ n3Ams14IMq6YElBKRsrVs46p6kxyph91nxKMOh+c75oofY0oSrpsmugszKMwkW4wL81z j1MQ== X-Gm-Message-State: AOAM533wIPSMQLhZ1AB1CUl+2OWRUbGiwoFgV+rqbmiel/huzNZ0cwoX jrfyM7vLLZEuonzWJOTnINK4lAXo2ZI/EUt0CHvauJemua5gs5HWV2dgMFVS50pGRUGZkj9Qrsj jMcVjUc1rhkzJCoxYwyAEKOLewzGJ3v1W2Ck= X-Received: by 2002:a1c:4d01:: with SMTP id o1mr31902622wmh.42.1620722887553; Tue, 11 May 2021 01:48:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSGeb9zeNJcEJc46A/MASJMpLh0cSVeptzLQX8/dyHTwjbhVOWjTy0K8ideXs9zrKhUkYH5w== X-Received: by 2002:a1c:4d01:: with SMTP id o1mr31902599wmh.42.1620722887375; Tue, 11 May 2021 01:48:07 -0700 (PDT) Received: from redhat.com ([2a10:8004:640e:0:d1db:1802:5043:7b85]) by smtp.gmail.com with ESMTPSA id l18sm26972171wrt.97.2021.05.11.01.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 01:48:06 -0700 (PDT) Date: Tue, 11 May 2021 04:48:03 -0400 From: "Michael S. Tsirkin" To: Zhu Lingshan Cc: jasowang@redhat.com, maz@kernel.org, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, cohuck@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" Message-ID: <20210511044756-mutt-send-email-mst@kernel.org> References: <20210508071152.722425-1-lingshan.zhu@intel.com> MIME-Version: 1.0 In-Reply-To: <20210508071152.722425-1-lingshan.zhu@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_014814_699526_42F05483 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 08, 2021 at 03:11:52PM +0800, Zhu Lingshan wrote: > This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88. > > The reverted commit may cause VM freeze on arm64 platform. > Because on arm64 platform, stop a consumer will suspend the VM, > the VM will freeze without a start consumer > > Signed-off-by: Zhu Lingshan Acked-by: Michael S. Tsirkin > --- > virt/lib/irqbypass.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) > > diff --git a/virt/lib/irqbypass.c b/virt/lib/irqbypass.c > index c9bb3957f58a..28fda42e471b 100644 > --- a/virt/lib/irqbypass.c > +++ b/virt/lib/irqbypass.c > @@ -40,21 +40,17 @@ static int __connect(struct irq_bypass_producer *prod, > if (prod->add_consumer) > ret = prod->add_consumer(prod, cons); > > - if (ret) > - goto err_add_consumer; > - > - ret = cons->add_producer(cons, prod); > - if (ret) > - goto err_add_producer; > + if (!ret) { > + ret = cons->add_producer(cons, prod); > + if (ret && prod->del_consumer) > + prod->del_consumer(prod, cons); > + } > > if (cons->start) > cons->start(cons); > if (prod->start) > prod->start(prod); > -err_add_producer: > - if (prod->del_consumer) > - prod->del_consumer(prod, cons); > -err_add_consumer: > + > return ret; > } > > -- > 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel