From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E87C433ED for ; Tue, 11 May 2021 13:17:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2CB1613CD for ; Tue, 11 May 2021 13:17:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2CB1613CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=5tkE9+jMBVQB1c+iU2Eiq1hOlqFYRWv9Atl6zP+sqOI=; b=Ei45RXH3ArkdXHFnweE9dC7ZaM sGhj6yRilhAiOgZLSby9QJaBj6SFOSt9ERMYbyJ2wn4TLzoPIq+ShofLr4hG6a6VKWY9/uNKBINOW r3YefjSSxHjzLH1eH4jbEBcRMXz+7JswutFgrtYkZ+alaH9smdkV+/eLjuffkW5yyS8lycGIJBh/+ 7cMsSJUYgK6mPcmN+bAZCyFN9pJFeI59snigCdBWQQhihy+g0OKy1Lgsira0vdPvNl8n9bcEjfwui iViLradgW0F47uTyvTjj62f4vjGUCbTFWCg9q2lQaRfulfn9f7DHu+ZRUuUg0heguof8Vng3xHk7R 6H9Mqc6Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgSF0-0001ww-Gx; Tue, 11 May 2021 13:16:02 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgR4r-00HGlG-Fd for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 12:01:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=oS3VWGl1qjUiuuVUccoYHWbNFE/IhIlHRr3bSwsEdq4=; b=KrzXJkt8hb/CXInHYQYR19+9zO qvy2k7Gup/beiO1vVktTTnMzQgZMx6ob+7Tpgg2IYvgclypNCbbPUZhWm+Rmg0pMWgi15Wm7J0XBV gY0izsz1d73NsUP1JPiY8BimnOXdCBBu2g86wNKmxH/RWQwaG/JeKwYdCurQiKBMRyRtjJeBJ4NhJ 5/daJiXvcurrCVxQlgt+4KrT1BEK0wSas9/DX5TnJoaZAM2WsVAaYtHqONPWpVsWUSwRkIwcm+XVR ahcvIMqSZZehW6cS9pv47AY3hm19/YjQgz1BoHtQt9zuG3NSeFFk56r4XKfYw8wzPg1wuMPZcetoL 4/8Kd0jA==; Received: from szxga04-in.huawei.com ([45.249.212.190]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgR4o-009Xqz-5p for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 12:01:27 +0000 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Ffbzh3fdLz1BLBh; Tue, 11 May 2021 19:58:40 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.177.72) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Tue, 11 May 2021 20:01:12 +0800 From: Zhen Lei To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , "Marc Zyngier" , linux-arm-kernel CC: Zhen Lei Subject: [PATCH 1/1] irqchip/irq-mvebu-icu: Remove redundant error printing in mvebu_icu_probe() Date: Tue, 11 May 2021 20:01:07 +0800 Message-ID: <20210511120107.5781-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.26.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_050126_402326_E48E28F5 X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Reported-by: Hulk Robot Signed-off-by: Zhen Lei --- drivers/irqchip/irq-mvebu-icu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c index 91adf771f185973..090bc3f4f7d883d 100644 --- a/drivers/irqchip/irq-mvebu-icu.c +++ b/drivers/irqchip/irq-mvebu-icu.c @@ -359,10 +359,8 @@ static int mvebu_icu_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); icu->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(icu->base)) { - dev_err(&pdev->dev, "Failed to map icu base address.\n"); + if (IS_ERR(icu->base)) return PTR_ERR(icu->base); - } /* * Legacy bindings: ICU is one node with one MSI parent: force manually -- 2.26.0.106.g9fadedd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel