From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E892DC433B4 for ; Tue, 11 May 2021 11:58:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 437E1613BC for ; Tue, 11 May 2021 11:58:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 437E1613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=synaptics.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3EzyS253tSiWU7Kjyj7gMxXG1AuKNmuP/CCNx5nyPrI=; b=Xb3fpRTUOV4RSmnOAFDUc2I1p YXSv1QBHs3/MDswh8FJsoBmjcVJpccXmrSN3w0o80huD3JmDYqpEF1CfLeu0u9EIekdW+rL0Nir8n BOTXDDNFxl4BIqZXuWtjq36xvykoL2Sy8YzX0VVdoOjKrIRj8Q24pwQvKy+sE0PKp/pVFtl/fVSr/ M5MTOSrWBERnXc5Cp7kun0PBAekxismsVazoQnqBzFtrbLFcOijji8wj7nLFEOgK+FXvyTcjlxTzb lii73NyqBmwIQwhaUDJJTqkLMt0nBtOXi7pIQwWcnLfYmxU/RUBxtTXI9CdsyeW9y9UVRraGSyq4L X5+uGLoYg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgR0U-00HFXP-Ch; Tue, 11 May 2021 11:57:00 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgNCm-00GY2I-1S for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 07:53:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=6jTccCSG1v6NdPO13+pxp2A7JULnoKd4YxjikWkJNQo=; b=y3yaAHaedzcb/Z3TbjebrfR7kB p6A68SWY7vJYdXwvWS5gm+BS3x8C0AoeuQrtWWovlDXjy+eoNDJZ90vM8t2EPBAa/xkO9yeoMrM/H sfwOzUn4TQdMPn3zNNAWgjd/5vxVnCiGT9uHW4LDNBCGfJFjSlZihAgNjdD4c7t2pZyZqdyqEh9ma fvPqqRhzQByvbRXCw5H/urBScz+OjQyNteuRcKlsxknZ/SDjly6I6Mk8QwcBIKTFhjnNpoiJjXIbM 3Bx5J2x5uTu/naNSxeS2se++Rwwso/LwV/G4YNZdz81sSRG8Awi2DUgtE4w3grxTPxhSUPg7YOhq3 +92Lqf0g==; Received: from mail-bn7nam10on2065.outbound.protection.outlook.com ([40.107.92.65] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgNCi-009NK7-Sz for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 07:53:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ct1NoeuivRMkdE3UwAV1u8iq/ZmCGNNic65KZhl1RSB/JMsFCIDO2uOs6TOeMazR3lx6TgkAv6rPCdSjP4itjkR5NVwtuRZ/kktzrwND6SKbuSngb40DFnAFPBAr7Ghb1pHEkx3UmnCuT0BNJ945Dfmb/XOj1z9jrtlUI4sIllNDR/HX8PuXrU8PIdfJONUAtch9lqdDZmjpZ1lhlNBCVu932GEphmUvf49Njh+8tvHwnlZc8f+Oja5NXiZVkA9cJhTSfDRQV3eFZhX+XbNwOU6p5U6fwPPZ1wc00JJMIMoluGd0ys0Nx0rmXoxykgxc3F2oMqJsglrU+BX3qp/NmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jTccCSG1v6NdPO13+pxp2A7JULnoKd4YxjikWkJNQo=; b=hgzS2U/2PhroYcm2lxm6tY8CkZDCoMWNMngbed/DOgLbYU5pHaVR9pWh/P92TBM8g8/3FerujqoEpD+lpCH7g66itvuq/QV5kVv1Obo+6KG6wyKzJwY+YJPg4kjBG4YwcET3M+1GtJ3335fIEO99d6u7N5gyYSfMGz/2W+Env+5bU6a/NvKZ9ZusUEgQzba7bb+iALoJtR1UBCEp6HhIOAonMHzwrjAsS6DKg0ppJByj579LMvj3hkFHMZuZrQ8iARvYS1cXbqLMtoOr38mWT3u4RUyaKGQn0axK0Fnby02J2PG0wL+6/OUWFU3k96T/j6m29bvR+e3VmwWvS574Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=synaptics.com; dmarc=pass action=none header.from=synaptics.com; dkim=pass header.d=synaptics.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Synaptics.onmicrosoft.com; s=selector2-Synaptics-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jTccCSG1v6NdPO13+pxp2A7JULnoKd4YxjikWkJNQo=; b=Key0pbAk4dKiwQ0x04P0B6JVhxlFJpBrp33o9l6/nxHmnoVynzB/mV/l8rc0nSIYHWTdLteBopZ5GlhtXILhSOWjxXCVza3dPEb3Wh9MdTBvefGg7wj2klgWGcUreyd05CoSbE7R/lgxBnDsoCtPXFqCbbysCVPP6W5ZDNTqFf4= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=synaptics.com; Received: from BN9PR03MB6058.namprd03.prod.outlook.com (2603:10b6:408:137::15) by BN3PR03MB2196.namprd03.prod.outlook.com (2a01:111:e400:7bb2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.27; Tue, 11 May 2021 07:53:18 +0000 Received: from BN9PR03MB6058.namprd03.prod.outlook.com ([fe80::308b:9168:78:9791]) by BN9PR03MB6058.namprd03.prod.outlook.com ([fe80::308b:9168:78:9791%4]) with mapi id 15.20.4108.031; Tue, 11 May 2021 07:53:18 +0000 Date: Tue, 11 May 2021 15:53:08 +0800 From: Jisheng Zhang To: Marc Zyngier Cc: Zou Wei , , , , , Subject: Re: [PATCH -next] clocksource/drivers/arm_arch_timer: Make symbol 'arch_timer_rate1' static Message-ID: <20210511155308.0f66b6b0@xhacker.debian> In-Reply-To: <87pmxxoi71.wl-maz@kernel.org> References: <1620715583-107670-1-git-send-email-zou_wei@huawei.com> <87pmxxoi71.wl-maz@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) X-Originating-IP: [192.147.44.204] X-ClientProxiedBy: BYAPR05CA0106.namprd05.prod.outlook.com (2603:10b6:a03:e0::47) To BN9PR03MB6058.namprd03.prod.outlook.com (2603:10b6:408:137::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from xhacker.debian (192.147.44.204) by BYAPR05CA0106.namprd05.prod.outlook.com (2603:10b6:a03:e0::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.11 via Frontend Transport; Tue, 11 May 2021 07:53:15 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a5466a3-9659-4b0c-cfc5-08d91451d6ea X-MS-TrafficTypeDiagnostic: BN3PR03MB2196: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PAtAkgdfEQpcL8LMweMqOLTPwl35cQAmDHJez2v7CQ62EHCLHVsppHNmMQ281j1w8DLSRRReAG/kxCN1LEa4GIETv26t+QNYiqIGuS5vW+g+VHwyJL8VdzkMsycXs47UN9e6Ma0ipRADmztONner6XZlr05x3HFus+bIZ4NBmlUGeYndPO0cWs5XTwpVbiLXL+EKCOSzdHKo5Q+leMQOcjH2NboMP2alVbgMK50W+hLXVYks5yXkQGlo3RkAojyms5OCWDsltIqQyePvWpl2sZz2m1ZYIwndca81/WUuosYh33nf8hoGzR3W6QaYgfGVDRIADBqogoYuaLu+phcTVhcHTPlEpcCSvVjoxSUtRJfAbxaUskOKdHQnBm5BTGLPzVQ8IwUzaBTkUTgcjDiiC7DeG7DK9Af52962rMNj4rLMRiXShpAEZXYRL3+9fKqS5GViZqJ52y9HYPro6mflohIZM+cqKu5cM4L9g0FMh6kJcTBbXRioFheHmGSNVbHPrHYd0RLI1BYXiU9c3SNDkQ5xDAMDoVQfJewmab0YaP9gnXpUvdYSPXjVCx8B6kI76FlZGv5/+o9f3kxlRnlkjqbHhoTm66RQXNhYXwW9mg208Fjp3Td8W/irbYf+bTZMYdU7pVwHFygyhjITEEXlXB0fje3f0WXYUXeHImkgK1c= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR03MB6058.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(376002)(39840400004)(136003)(346002)(366004)(66476007)(66946007)(66556008)(956004)(38100700002)(54906003)(8936002)(4326008)(6506007)(316002)(8676002)(6916009)(6666004)(55016002)(478600001)(86362001)(83380400001)(186003)(16526019)(26005)(38350700002)(52116002)(7696005)(9686003)(5660300002)(1076003)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Tdg+TMJye91VXQI4N4BZik3er3/zW/9M0PcKq+cQpDakJ1HBw0ezWhDLu7f4?= =?us-ascii?Q?yJUPRxKk9WG4/bbLGU91/009qnA8Sv02dOLKIIhdTFcYqjOyLAVHnZ+GJXv4?= =?us-ascii?Q?lmrs87nnOzKl+qd0542bhmOsw3WqltcykK3adDxcqcCCECXOHRMuObvoTC60?= =?us-ascii?Q?6scSO3urZtBy90cN+ZvYoWYHO0I674SJrRHBkVHosKrMKSJIUwuzFuQjv4d5?= =?us-ascii?Q?B8GWtcYrPSNU/EESlvi+/tjK5nGrLtNskCjRBJK3Dh8EN3mVIk4rzzIEws2r?= =?us-ascii?Q?i9eSk2d3OV8i8BTv5YGNtFaJ10MFvf+yKsSnxTq3RPF6UmbmhECYSHdO/32T?= =?us-ascii?Q?KWsLRvFoxtLy69HgUIulCTucLRxIYtgLB09ZlVPnWb4H2MJdpV/g9xY0osRn?= =?us-ascii?Q?LlxChnr/5H1jC+DmNI55gs80rKsZKHTrFIk+cFK35qSl59iaveCK63fWUwtU?= =?us-ascii?Q?YO3g6TtQAcDHNcwo3jzToE9ZjMsMQTBX7bpY4pOj5IkpipPcTx+LnSgzrKGJ?= =?us-ascii?Q?GjZFhzDD6MCpe5EUl4WKQBmxGiHhxMw2Q6CuWiFo8s+OZxNP00PeEgZ7fbI2?= =?us-ascii?Q?Kf25oNZCD46cbpcCTHH6EFNX0MlxL/ivNKvZzs05fnEJdL7DjpAWSxiYQ0xt?= =?us-ascii?Q?i+cyBKoiLvJA65WI+AemibMrh+1C1oihBVXlp7XYwWRxODHTlK9Vddd6Jplu?= =?us-ascii?Q?9FHOawAWbUlt1doYuPCLcnEhiLv+7SdOgSTLSjCzGoJfRb429A3qXJfpDTJ1?= =?us-ascii?Q?arPgKidjIqvZvg3jwPSimr7gVXRhCOCKnvSFiHIoXCoP9qbL+oT/zBBZ1Mcg?= =?us-ascii?Q?jrSaSDgm6pIjAAfXh/FbdWWWaH3ynFQ+qm2hmr/oJSNt3tVNP5P0I0rp5/ra?= =?us-ascii?Q?I6s7EyMaDsV4F+7X3jS7t2tFqI8aTdFMkvONLal9SS/HrTb1xvUkeRWbe/sP?= =?us-ascii?Q?R1xAXwihm5SyWl29NtilgdFeX01dD8/1IGogz6aFEdwbREtEaOFWTIag9hTp?= =?us-ascii?Q?mWTea7MdQaH3LL/YMvxXSqLBaiOBWm7tXEsjeN6nDrVTvsGLhIBYnEzgCyQ3?= =?us-ascii?Q?EuO5744BZQ30ewM3YYA+CYAbk/dfVFQj75F9jAvH5TzEPVBLw5iHHDLHiP9n?= =?us-ascii?Q?6rzYte5LuTp5CjOcBfoHfrsM4BHsS8Xm7piaTRdUAXgtRsR5Ijfisxs9Zxcw?= =?us-ascii?Q?yvRTS4HjjEOBW1sTC2pu14MxJIeJKwtRMn2qSq/1NQ97IgPf4EAVllDoRG46?= =?us-ascii?Q?kTtoCEPDwi9R3nN1NZEG24yM0/LVxMD5F80kYqhE9k6Ww8GMxFR7JVG19O1e?= =?us-ascii?Q?cZngdZ6HW3G9EVOjD35/artq?= X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a5466a3-9659-4b0c-cfc5-08d91451d6ea X-MS-Exchange-CrossTenant-AuthSource: BN9PR03MB6058.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2021 07:53:18.1718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PP6TiTMCTl6hAxdhQwazsval4iXdMzhxaLxHWUtBxZTwhMvVGy6DQ08raBAP/JGelzIJTY2nclSLppHmnldP+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2196 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_005320_978691_F535B795 X-CRM114-Status: GOOD ( 22.12 ) /bin/ln: failed to access 'reaver_cache/texts/20210511_005320_978691_F535B795': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_005320_978691_F535B795 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 11 May 2021 08:14:42 +0100 Marc Zyngier wrote: > > > [+ Jisheng Zhang] > > On Tue, 11 May 2021 07:46:23 +0100, > Zou Wei wrote: > > > > The sparse tool complains as follows: > > > > drivers/clocksource/arm_arch_timer.c:67:5: warning: > > symbol 'arch_timer_rate1' was not declared. Should it be static? > > > > This symbol is not used outside of arm_arch_timer.c, so marks it > > static. > > It is worse than that. This variable is not used *at all*, and has > been added by e2bf384d4329 ("clocksource/drivers/arm_arch_timer: Add > __ro_after_init and __init"). Not sure how we missed that. Oops, my mistake. Sorry for that. IIRC, I added the __ro_after_init marker, then want to prove the effectiveness of __ro_after_init with a new and non-used variable. But later forgot to remove it. > > Please post a patch removing this variable altogether. Just sent out a patch to remove this variable. > > Thanks, > > M. > > > > > Reported-by: Hulk Robot > > Signed-off-by: Zou Wei > > --- > > drivers/clocksource/arm_arch_timer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > > index fe1a826..800aaa9 100644 > > --- a/drivers/clocksource/arm_arch_timer.c > > +++ b/drivers/clocksource/arm_arch_timer.c > > @@ -64,7 +64,7 @@ struct arch_timer { > > #define to_arch_timer(e) container_of(e, struct arch_timer, evt) > > > > static u32 arch_timer_rate __ro_after_init; > > -u32 arch_timer_rate1 __ro_after_init; > > +static u32 arch_timer_rate1 __ro_after_init; > > static int arch_timer_ppi[ARCH_TIMER_MAX_TIMER_PPI] __ro_after_init; > > > > static const char *arch_timer_ppi_names[ARCH_TIMER_MAX_TIMER_PPI] = { > > -- > > 2.6.2 > > > > > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel