From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DATE_IN_PAST_24_48, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD18C433ED for ; Wed, 12 May 2021 20:09:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEE2B61413 for ; Wed, 12 May 2021 20:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEE2B61413 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=s9cm7HmpRpIh9F6ZyC02Xj/ac6kZEObNZzYu8UPJnYE=; b=RkXUFnilTAMIuvmzAaMHYH5uJ iZ7lJ+SEhgaXPahY//l4cnMtgBktAZTEAozgfAueK2g/gxCzXvNRdQpkNjS+ICr/W9F+P0znU6LmT CCbBhpgBWbuEolA4brsbAxwrIquAn08jDy56qb6UPghYc9eXEKJY6yJ5FyZfk3GBsrDk9NyYEZ6Q0 pE7ghVSk/a4VajR9iTwBG0lfUy7GHoNgwiODHHuu56skaHstVtt7FEPoN4X8vvayDy7mTgDKKa3l7 6j/cVOsEY3C9rutuF1B+DzTKleANdzosBQt0bmZStMufRVaddhrFTXOR2ZkEtC0NIw8mYDuHDTrtO slOSrKQTQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgv86-003qtq-N7; Wed, 12 May 2021 20:06:51 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7Y-003qor-7Y for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 20:06:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jo6Dz46BspHZ5QKYcvfVJgbPf+bpiO7/FDHcJz0o1TI=; b=x/Lo2YLLApGFHsF9XGC3S6QdQk qEhAUgttFPLB0ZCqE04EV/89ytQFHtg1QbInWFHgvCr8bsAmmaLlR49K2s1/6tJf7bSn83En/SRP6 dPYV6d9yEKuqqCB0NgQg/zSJodwkPsXjK7krX0sOiRcrGvMV3tRaqTC/DZgmnmCS3UmjxTQHJUGcj Dr5OKSCzUubxCJwWlXOKQ7yGk5poQCV/JBwVieCWL7p0KWmrl7Mac+gDEFXrXPiykITc8wuAnxrxz ZOrFWMsajC1LDzSO90HTMDKrEkxun6dsQpYerwrkRhGSKiR6ROCyosquu1u1Ln81MquOthg6SZUFk ELep8afw==; Received: from mail-oo1-f46.google.com ([209.85.161.46]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7V-00Amji-Fd for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 20:06:15 +0000 Received: by mail-oo1-f46.google.com with SMTP id e7-20020a4ad2470000b02902088d0512ceso2383453oos.8 for ; Wed, 12 May 2021 13:06:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jo6Dz46BspHZ5QKYcvfVJgbPf+bpiO7/FDHcJz0o1TI=; b=AwM7vBlSNSjCHGpkGD3SAsMJbNtf07JFtAhWHG1tguDxH+kN8wpZPuPh9VE4laHRre BvrD68fS+6GYnod59BHHvNyUOYSUnCTbczAP9fdnP7xeG+4XHJc7pSOeXamqeJlHK0Fe SYU/lXWjqb4jnMl/faOZDpgGux/IBGziL4sDzuQTRj1dV6NlnXYX/eG89u9cVOzLYoVu UBnqyLQAuwk7pKdJX1gLhW425mutuPQUbLwaSwMez9Se1IQqh0rMKGh8p3z2Ars9+vzR rnQ9vmscp17ZhME/URemrcK0PiUpjvutOrJpv65Gq/HH7k3lPEMAvtZDOowRtXwA0fSv cc3Q== X-Gm-Message-State: AOAM533N6yw6QiGCbr7NegbcF9NPWTJXVUTH8tob03AmRD9YwR0D95Zt bAHzVpEm65V4CRDdVg5hqQ== X-Google-Smtp-Source: ABdhPJxDFSQVxLClkJTg+b6TFZAy9l8JrP9W5GwVfM62sQew6UGxQEpVQ1d+msGrVdPqxIQ5m7el5A== X-Received: by 2002:a4a:a3c3:: with SMTP id t3mr18346160ool.50.1620849972488; Wed, 12 May 2021 13:06:12 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id r10sm192474oic.4.2021.05.12.13.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 13:06:11 -0700 (PDT) Received: (nullmailer pid 2214054 invoked by uid 1000); Tue, 11 May 2021 16:16:48 -0000 Date: Tue, 11 May 2021 11:16:48 -0500 From: Rob Herring To: Linus Walleij Cc: linux-crypto@vger.kernel.org, Herbert Xu , "David S . Miller" , linux-arm-kernel@lists.infradead.org, Imre Kaloz , Krzysztof Halasa , Arnd Bergmann , devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] crypto: ixp4xx: Add DT bindings Message-ID: <20210511161648.GA2209918@robh.at.kernel.org> References: <20210510213634.600866-1-linus.walleij@linaro.org> <20210510213634.600866-2-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210510213634.600866-2-linus.walleij@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_130613_544487_C79C5AD8 X-CRM114-Status: GOOD ( 25.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 10, 2021 at 11:36:33PM +0200, Linus Walleij wrote: > This adds device tree bindings for the ixp4xx crypto engine. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij > --- > Herbert, David: This can be applied separately once we are > happy with the bindings, alternatively it can be merged > with the support code into ARM SoC. > --- > .../bindings/crypto/intel,ixp4xx-crypto.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml > > diff --git a/Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml b/Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml > new file mode 100644 > index 000000000000..28d75f4f9a76 > --- /dev/null > +++ b/Documentation/devicetree/bindings/crypto/intel,ixp4xx-crypto.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2018 Linaro Ltd. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/crypto/intel,ixp4xx-crypto.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Intel IXP4xx cryptographic engine > + > +maintainers: > + - Linus Walleij > + > +description: | > + The Intel IXP4xx cryptographic engine makes use of the IXP4xx NPE > + (Network Processing Engine). Since it is not a device on its own > + it is defined as a subnode of the NPE, if crypto support is > + available on the platform. > + > +properties: > + compatible: > + const: intel,ixp4xx-crypto > + > + intel,npe-handle: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + maxItems: 1 > + description: phandle to the NPE this ethernet instance is using > + and the instance to use in the second cell > + > + queue-rx: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + maxItems: 1 > + description: phandle to the RX queue on the NPE > + > + queue-txready: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + maxItems: 1 > + description: phandle to the TX READY queue on the NPE > + > +required: > + - compatible > + - intel,npe-handle > + - queue-rx > + - queue-txready > + > +additionalProperties: false > + > +examples: > + - | > + npe: npe@c8006000 { > + compatible = "intel,ixp4xx-network-processing-engine"; > + reg = <0xc8006000 0x1000>, <0xc8007000 0x1000>, <0xc8008000 0x1000>; > + > + crypto { The parent schema needs to define 'crypto' and have a ref to this schema. I'd put the example there rather than piecemeal. > + compatible = "intel,ixp4xx-crypto"; > + intel,npe-handle = <&npe 2>; A bit redundant to have a phandle to the parent. > + queue-rx = <&qmgr 30>; > + queue-txready = <&qmgr 29>; > + }; > + }; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel