From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EFC6C433B4 for ; Wed, 12 May 2021 13:43:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17B4661007 for ; Wed, 12 May 2021 13:43:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17B4661007 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c+vUA4Br4vN+NPxtsFDdLRlGLsZG7a8sYWEIPsAX3Ug=; b=hdD+Lj2p7qXWEfEqI0yysZK9R KOm3UwqQkde4o+X+2ji7RrE9eAPtvjx8W+LxButHUcuDWu4MsM3gOaoygk6RwMg2q4xvkTTF87k0G 9L1+Q1e13+QMaPzJPO8wCt1RCvHBEbCmvt25j04DowkacWKTEux+kFQpigzwYr5e/2EeDcumWA77z Ru/IdZ+09t+JYvvhXp5K2aNzwx5Hq1LKnG3cYQfQCcBQnojeM0RVLFu15WYmLKun4pUoIczWxGwse qkkOAer0LFiDn39Y5L0tin23EZTgDnz0tRrLEt527ncLS+li7n3m6/x70CG+xxDO0QZCYwiZKz4TG 1JOgx+iDA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgp7S-002vrl-Dm; Wed, 12 May 2021 13:41:46 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgp7N-002vqr-U2 for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 13:41:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ie00U476GPJAxxlZzkQv34TNl377MTLanFZGfFeppag=; b=MJDpDyQLr2Yq5HHfAYDAX+fihb O+VKsuBUdBzOcuQe1gVgXI/613YCW7aOgJBLk16TGm2MpeIfTbbijstMhtWcpD79/a5wQNMqO/mfQ cgPF38NuRjPcP+4odItqBLoMfe6zlI7MGQFhSGF50riiP8NNg9Umw63kGjWH3G0fov8/pIvxEwIa6 a9MBC8qYB0Mpxc2TReusROUfIYv89hqLZvUvMJHw01N60Oep7AAmeYj9epvpujV0Pu2RgtcGN9Pd9 sab8Nr27YTKryQQDEvXQKdA4w4bKwXiEtzwbokcpHwikB3Qs7kGgyHW+7Fzromct0jaTydq//pPah +qJtSxnw==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgp7L-00APqG-1n for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 13:41:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCADF6D; Wed, 12 May 2021 06:41:31 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13B2F3F718; Wed, 12 May 2021 06:41:30 -0700 (PDT) Date: Wed, 12 May 2021 14:40:42 +0100 From: Dave Martin To: Mark Brown Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] arm64/sve: Use the sve_flush macros in sve_load_from_fpsimd_state() Message-ID: <20210512134042.GE4187@arm.com> References: <20210511160446.42871-1-broonie@kernel.org> <20210511160446.42871-3-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210511160446.42871-3-broonie@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_064139_167883_82C0AD00 X-CRM114-Status: GOOD ( 18.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 11, 2021 at 05:04:45PM +0100, Mark Brown wrote: > This makes the code a bit clearer and as a result we can also make the > indentation more normal, there is no change to the generated code. > > Signed-off-by: Mark Brown Reviewed-by: Dave Martin > --- > arch/arm64/kernel/entry-fpsimd.S | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/entry-fpsimd.S b/arch/arm64/kernel/entry-fpsimd.S > index 7921d58427c2..dd8382e5ce82 100644 > --- a/arch/arm64/kernel/entry-fpsimd.S > +++ b/arch/arm64/kernel/entry-fpsimd.S > @@ -63,11 +63,10 @@ SYM_FUNC_END(sve_set_vq) > * and the rest zeroed. All the other SVE registers will be zeroed. > */ > SYM_FUNC_START(sve_load_from_fpsimd_state) > - sve_load_vq x1, x2, x3 > - fpsimd_restore x0, 8 > - _for n, 0, 15, _sve_pfalse \n > - _sve_wrffr 0 > - ret > + sve_load_vq x1, x2, x3 > + fpsimd_restore x0, 8 > + sve_flush_p_ffr > + ret > SYM_FUNC_END(sve_load_from_fpsimd_state) > > /* Zero all SVE registers but the first 128-bits of each vector */ > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel