From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C8AC433ED for ; Wed, 12 May 2021 15:25:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2F92619C8 for ; Wed, 12 May 2021 15:25:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2F92619C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qrG9gdzk2x25FT6LyWOeglKOVbXCZD4jcwTJtnL1ie0=; b=p+il1E8FGHruZMZ67DuYcoitf t/AT5RSm7XxwCEvtl4UrXZy9UEu3lfFneWyqa4KTwhlPdA6eYd71b2Fh82sN24F7ekbmJ1qG6/h7n 0mI9LE52z8WxBX5F9yDg5YrELlT7ooWAS+Vc0jc7cazr3JZLfoysjb7udnbIlB9WXmPsa7WjIzgxl Pp8FI3eJzcZpmuZCSPPsz56+M2bNuWmhl6i0/ATm7lfzTgMybt6nS/CBAat2h5WYZCGOwddbwvfBd 9gmZRiFBajh3r7f3n/kmNBMIOI/vaF5+8egHQFLA/b+O64pMJ7TxZWVCUA2lJq6kbqsbw2od63Tmo Iia3gNSQw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgqiC-003B7A-Oy; Wed, 12 May 2021 15:23:50 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgqi7-003B6O-RB for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 15:23:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+WmCdrS1TMn2hGqp3nbYKTeNACXqD6MvKMsrI4Gekn0=; b=QAGvVFEyHTTBqXJaZZapD46I2W iZwhS8RadaghG1b9xHw5W03xzJ8CPg1LoyspFaBm1vpZs/S8EMyoZ3zNA44lQ17qnzOc+AUPt+Es+ gnmsckcvvVrLe9miDZh/4HGJvDZl2tDUrxcfL6LxAGlwp5A9HhYgxzWISaOWrYxRjQj8Qs/zJb8Ae pK3FYSjytwEzeh7/h461m7zubE02pGN8iSEdo1MiD3x0ptCuWJ2XsQcWhkwMnflnjezGh377nG9IL t0rU36kG+1XNUn71tq3NSS12KRGZGkf9iecHBFn94h74JWby4P6zWj2RmM/c+1aBpBaU9W8pFCvOv qxZ8IeCw==; Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgqi4-00AVt5-VP for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 15:23:42 +0000 Received: by mail-pg1-x52b.google.com with SMTP id k15so5663983pgb.10 for ; Wed, 12 May 2021 08:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+WmCdrS1TMn2hGqp3nbYKTeNACXqD6MvKMsrI4Gekn0=; b=ByPtxvKS8saS9qVWc0y5uY71My/u0HVJpMZCgL608n9bGPKRUYdqAbwEkPBzAc7uwM fBi0WhHoWYUwqA/au/wpGSRUtAhP1jQtA8bu8YFZg5D/OUWsbZQtYZ/uvmpSIut+WDLb bv1/OWBmIlGFZAFLXnxwkdLQ+uxtVnSGBvaF4x5UwgIbL7npedNrw39k+qTJxPXu0I5J gvS+f3WD2j3/ko6dWje+/9NNLpWRWrRnaKiCVip0yXo6f3l4dVoptqbOlzxRcZH6OK0J S5T8nNXXKurgnm38yzt6GCCs6gMGFkFuxsx9j5r+A06BjrCgPjRubBUU+SlJhSincUMu vozw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+WmCdrS1TMn2hGqp3nbYKTeNACXqD6MvKMsrI4Gekn0=; b=YZzh4ef7zdCOvwiDY+LhCnCIJJyq6dV3KSltKTDTPGOJz1eROFe7fjAu6fbgaRx+fC 3HKrCsOr3HMTrVR393N8ikokGYR5kcV7aW2li37Xb88Up1D+a80PJmOTHaww1dQ4FMuN wyc8cZ2w1RYsabVYvShWAqxK1rGBC0nbPgVDmcytkSDq4nqUs/AR2SSCmHeqy6BEu82C nRKig9rfFXjgL90fGY5bkGSt/y0s2sIaUZz6zr1iEvA2OqI83yHyHAu82wI3SlIkNb8c ns45vXaKkumbtMccjEvKMiwDZwh9pnaawttxfAwVaT1fyzLVlDXQcMMdyLZCeEboEAS3 UCPQ== X-Gm-Message-State: AOAM532ZXmesC0geIk4tfJUFZSP+5Clnuu/2gmpqAGTNhVR6Vwe4ZP2I Vv/xGpUOX2jTU32ZYJVtvHr00g== X-Google-Smtp-Source: ABdhPJwLY9XaqFKgJYjrtqEiHAdJ+BCmFC6M2x0Zd5NgpwhcCAVsHQlmHoBmG8QVDwp0HmaHYuKyyA== X-Received: by 2002:a63:8f15:: with SMTP id n21mr35823079pgd.366.1620833017838; Wed, 12 May 2021 08:23:37 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li1207-178.members.linode.com. [45.79.108.178]) by smtp.gmail.com with ESMTPSA id u15sm4893693pju.44.2021.05.12.08.23.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 08:23:37 -0700 (PDT) Date: Wed, 12 May 2021 23:23:30 +0800 From: Leo Yan To: James Clark Cc: Arnaldo Carvalho de Melo , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Al Grant Subject: Re: [PATCH v1 2/3] perf arm-spe: Correct sample flags for dummy event Message-ID: <20210512152330.GA121227@leoy-ThinkPad-X240s> References: <20210429150100.282180-1-leo.yan@linaro.org> <20210429150100.282180-3-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_082341_070606_CAC1B6CF X-CRM114-Status: GOOD ( 30.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 12, 2021 at 05:39:56PM +0300, James Clark wrote: > > > On 29/04/2021 18:00, Leo Yan wrote: > > The dummy event is mainly used for mmap, the TIME sample is only needed > > for per-cpu case so that the perf tool can rely on the correct timing > > for parsing symbols. And the CPU sample is useless for mmap. > > > > This patch enables TIME sample for per-cpu mmap and doesn't enable CPU > > sample. For later extension (e.g. support multiple AUX events), it sets > > the dummy event when the condition "opts->full_auxtrace" is true. > > > > Signed-off-by: Leo Yan > > --- > > tools/perf/arch/arm64/util/arm-spe.c | 30 ++++++++++++++++------------ > > 1 file changed, 17 insertions(+), 13 deletions(-) > > > > diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c > > index 902e73a64184..f6eec0900604 100644 > > --- a/tools/perf/arch/arm64/util/arm-spe.c > > +++ b/tools/perf/arch/arm64/util/arm-spe.c > > @@ -70,7 +70,6 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, > > struct evsel *evsel, *arm_spe_evsel = NULL; > > struct perf_cpu_map *cpus = evlist->core.cpus; > > bool privileged = perf_event_paranoid_check(-1); > > - struct evsel *tracking_evsel; > > int err; > > > > sper->evlist = evlist; > > @@ -126,18 +125,23 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, > > evsel__set_sample_bit(arm_spe_evsel, CPU); > > > > /* Add dummy event to keep tracking */ > > - err = parse_events(evlist, "dummy:u", NULL); > > - if (err) > > - return err; > > - > > - tracking_evsel = evlist__last(evlist); > > - evlist__set_tracking_event(evlist, tracking_evsel); > > - > > - tracking_evsel->core.attr.freq = 0; > > - tracking_evsel->core.attr.sample_period = 1; > > - evsel__set_sample_bit(tracking_evsel, TIME); > > - evsel__set_sample_bit(tracking_evsel, CPU); > > - evsel__reset_sample_bit(tracking_evsel, BRANCH_STACK); > > + if (opts->full_auxtrace) { > > + struct evsel *tracking_evsel; > > Hi Leo, > > I know the "if (opts->full_auxtrace)" pattern is copied from other auxtrace > files, but I don't think it does anything because there is this at the top > of the function: > > if (!opts->full_auxtrace) > return 0; > > The same applies for other usages of "full_auxtrace" in the same function. > They are all always true. I'm also not sure if it's ever defined what > full_auxtrace means. Good pointing. TBH, I also stuggled for handling "opts->full_auxtrace" when wrote the patch; IIUC, "opts->full_auxtrace" is also used in builtin-record.c to indicate if the recording contains AUX tracing. Will follow your suggestion to respin the patch (and refine the code) to remove the redundant condition checking for "opts->full_auxtrace". Thanks, Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel