From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0625C433B4 for ; Thu, 13 May 2021 02:11:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49BD260FE9 for ; Thu, 13 May 2021 02:11:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49BD260FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ATGuGdFqY0NvlAhIVE+vZ8t1ahjcXZGtfjoKgW5mQ7A=; b=LjWOLPA34Dj1n9XUmcLDwOdba DOI5fWAlMg2e2/Jw1jquZf+rTYnlOQ2dpdU73wjewWrzO6Keq5tn9REzuckE5UN1KjbozWZs11yOj 7LI5kffNCdqv9I45Ymlvm67byxs6LhKh8p78twpomyDsbtCgLf3NCSw/CBE61ORRnHV76JQ48S2WP cc0fYNOookoUHBaP4pBEZpHjd4DJ11qNBiGSHaPzRtPZzJx6yC8hqO5ChoNXsoZU39tt5RqVxzpmQ nQeGVMfN6jbd1ZiI4ar1EdbfW8Wf5kVcZGLV5QtcCNwYeSVrAOKEfOsbkEL2QavKVJjPtzsL/RIqz VMcLws7QA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lh0mm-004ST1-Ms; Thu, 13 May 2021 02:09:13 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lh0mj-004SSt-6c for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 02:09:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SVwLEck/V7daSQM/aMr+JHThUTerGpNJYz63BS3t9LI=; b=E4BpztWCRbORfmQEYgjH388y1M PH9d6S+S+WklSgvO7nWEmcVB+RxxAyjWy8KOGcYEvuphHr1oU6rMElbvZHj9lCPF0RH/8nbxBNo9z MN6Az7Kchx3NcAH77yINnAMJRVKlcn90dzJ2k/QhNIS8fIIqlJ02xlNVpz4woST/plbmoJgtfeSW5 sO4wwJRiW57LirqxnUi+K6HeLeYNwqobNvsPdvteZ2JLts37A1hizI87TvrdRkd8IYzryDdkXUgwP r2sDEWZtWdMwnYdeUijoFRZi98qQjNK17pUyaiuR3eP+rsIxy0KOIomr/6XlST6iUTzWFO2LYFlGE NgLZfXaA==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lh0mg-00Axwn-B0 for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 02:09:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 04F0660FE9; Thu, 13 May 2021 02:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620871745; bh=VGw1fMdv7a1LyI1pnnicV4IuFjxiNwdg/mYbWWDFhHA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cra+afcn4f04+Ui4+XAyl1MzvES37KAqkJocA6GKzLJcNHurLa02CD7gEnj0JR0X6 v/o1/o3oukhhXGJIB0d4ggspmzvuoututtLhbjI2Y3g4OF3I42uw5LA0NDtL4AJcBb ECh1W5NDfGGu64DXkDsXrTjr7YUg+yGvkirWZK9MtNwcb1XtAOhX6LKQ9KNZ0GvQXf asMbA5yOQPeWUJZp2najeUon31au7gPkA/abtobbb7Nu1gKKTVjOpttt0OyOoGc5I8 XD1GXTizzHkxkRJtOa7/Mt7nlh3iQkAPlQeQU/puVMYF6+fCuogGehC0ENouoKj3hO VVLPaSw983b7w== Date: Thu, 13 May 2021 10:09:00 +0800 From: Shawn Guo To: Adam Ford Cc: Robin Gong , arm-soc , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH 1/2] arm64: dts: imx8mn: Add spba1 bus Message-ID: <20210513020859.GI3425@dragon> References: <20210406013344.124255-1-aford173@gmail.com> <20210511024604.GE3425@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_190906_417313_228330AD X-CRM114-Status: GOOD ( 22.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 11, 2021 at 09:48:38AM -0500, Adam Ford wrote: > On Tue, May 11, 2021 at 7:20 AM Robin Gong wrote: > > > > On 2021/05/11 18:45 Adam Ford wrote: > > > > Also may I ask if you have a real use case for this bus node? > > > > > > The reference manual shows the SPBA bus tells the DMA controller which > > > peripherals are associated with it. Nearly all the i.MX boards use this. The > > > boards I support have Bluetooth devices connected to a UART running high > > > speeds, and if the DMA driver isn't loaded, I can see a performance change. > > Compare PIO with DMA on UART, but not w/o this 'spba bus node ' patch? > > > > > In fact, if the DMA firmware isn't loaded, I often get transfer errors. > > UART use SDMA ROM firmware instead of RAM firmware, so it should work > > even without sdma RAM firmware loaded. Still curious what really happen in > > your board without this patch. > > What I am seeing is that at times, the HCI UART loading before the DMA > firmware is loaded. > > [ 10.582037] Bluetooth: HCI UART driver ver 2.3 > [ 10.586867] Bluetooth: HCI UART protocol H4 registered > [ 10.593566] imx-sdma 30bd0000.dma-controller: sdma firmware not ready! > [ 10.594548] Bluetooth: HCI UART protocol Broadcom registered > [ 10.600108] imx-uart 30860000.serial: We cannot prepare for the RX slave dma! > > When I get the above message, the bluetooth chip I have throws > timeouts and does not function. > > [ 10.615090] imx-sdma 302c0000.dma-controller: loaded firmware 4.5 > > Once the firmware is loaded, I can unload the HCI Uart driver and > re-load Bluetooth works again. > > Based on that, I've been having my system delay the loading of the > Bluetooth modules until after the firmware is loaded, but this tells > me there is a relationship between the DMA and UART. Yeah, I can see how DMA firmware impacts your Bluetooth device, but do not follow how this spba node change make a difference here. Nevertheless, patches look good. Applied, thanks. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel